From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: RE: 23.0.50; savehist save invalid syntax Date: Mon, 10 Sep 2007 18:18:05 -0700 Message-ID: References: <25364.128.165.0.81.1189472104.squirrel@webmail.lanl.gov> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1189476975 32674 80.91.229.12 (11 Sep 2007 02:16:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 Sep 2007 02:16:15 +0000 (UTC) To: Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 11 12:16:02 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IV1tG-0004py-8s for ged-emacs-devel@m.gmane.org; Tue, 11 Sep 2007 11:18:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUuOt-0007jL-DN for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2007 21:18:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IUuOq-0007iw-1T for emacs-devel@gnu.org; Mon, 10 Sep 2007 21:18:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IUuOn-0007dR-4n for emacs-devel@gnu.org; Mon, 10 Sep 2007 21:18:43 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUuOm-0007cv-S0 for emacs-devel@gnu.org; Mon, 10 Sep 2007 21:18:40 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUuOm-000411-IK for emacs-devel@gnu.org; Mon, 10 Sep 2007 21:18:40 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUuOP-000523-0j for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 21:18:17 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IUuOi-000409-PA for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 21:18:39 -0400 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IUuOi-0003zw-D7 for emacs-pretest-bug@gnu.org; Mon, 10 Sep 2007 21:18:36 -0400 Original-Received: from agmgw2.us.oracle.com (agmgw2.us.oracle.com [152.68.180.213]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id l8B1IXoQ002978 for ; Mon, 10 Sep 2007 19:18:33 -0600 Original-Received: from acsmt351.oracle.com (acsmt351.oracle.com [141.146.40.151]) by agmgw2.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id l899EbNb018199 for ; Mon, 10 Sep 2007 19:18:33 -0600 Original-Received: from dhcp-amer-csvpn-gw1-141-144-64-225.vpn.oracle.com by acsmt350.oracle.com with ESMTP id 3200019561189473485; Mon, 10 Sep 2007 18:18:05 -0700 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) Importance: Normal In-Reply-To: <25364.128.165.0.81.1189472104.squirrel@webmail.lanl.gov> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3138 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-Detected-Kernel: Linux 2.4-2.6 X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78550 gmane.emacs.pretest.bugs:19842 Archived-At: > > The newlines are not necessary, unless you're thinking of > > someone viewing .emacs-history. That is, any whitespace will do. > I used a space, but a newline is OK too. > > If we don't care what the file looks like, lots of things become optional: > (setq foo'bar) works, for instance. I thought I'd err on the side of > readability. OK, it makes no difference to me. An argument in the other direction, FWIW, is that something _very_ readable might give the impression that hand editing is OK (in spite of the comment to the contrary). > > In that case, you might want to comment the Lisp code to that > > effect. It's not very obvious that a Lisp reader error could be > > raised by `prin1'. And I think it's probably still better to > > leave the general `error' handler. > > I think the documentation for the (new) variable > `print-unreadable-function' may be sufficient, but I could add one. I > specifically don't want to catch all errors there, because any other error > ought to be noticed, not suppressed. By "there", I assume that you mean in the C code. I think that the savehist code should catch all errors here. This is run on kill-emacs-hook. I doubt we want to kick error messages back up to the user here. But do as you think right. I have no strong opinion about this. > > What Lisp value can I test for [the new print feature]? It's > > obviously not `emacs-major-version' >= 22. Is there a featurep > > or fboundp or boundp I can test? If not, is there a minor > > version I can test? If I can't find something to test, then > > I'll have to leave the `read' in for new Emacs > > versions also, which is obviously a waste. > > You can, outside the `let', test (boundp 'print-unreadable-function). You > can also test >= 22.2, if it's added there, or >= 23 otherwise (CVS has > such a version). The first option is preferable. Thanks. > > Do as you think best. The doc string suggests that a decimal value is > > used, so I used one. Also, I think decimal is what will be used by most > > users in Customize. That is, even if one can enter #o600 in the > > Customize editable field, I doubt that most users will think to do that. > > To me, the doc string helps in this regard, and a decimal default value > > helps. I don't see a real benefit in using octal here, but that's just > > my opinion. > > Once read, there is no difference between #o600 and 384; there are no > "octal integers", only octal integer literals. The user never sees it, > then, and it has no effect on Customize. Of course. I was explaining why the doc string speaks of a decimal value and explains the equivalence. It is what users will see in Customize. It could also be what they see if they examine the source code. Or not ;-). > > OK. As I say, I don't recall the specific need. I do recall that it was > > preventing one from quitting Emacs, because `savehist-autosave' is in > > `kill-emacs-hook' (as well as on a timer). That is, if, for any > > reason, it has a problem, then it gets in the way of exiting. > > That was what was happening, but perhaps that problem will never > > arise in the future ;-). > > I wonder why `kill-emacs-hook' is allowed to stop Emacs exiting; if a > function on it signals, shouldn't one just proceed to the next function or > to the actual exit? It's not supposed to be able to veto exiting; that's > what `kill-emacs-query-functions' is for. I honestly do not remember the details. It may have had to do with this in combination with using a quit confirmation (query); I don't recall. I've explained why I added the condition-case, and I don't remember any more details. You are free to take it out.