From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: RE: Info-clone-buffer-hook should be renamed Date: Thu, 6 Dec 2007 14:51:45 -0800 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1196981592 8567 80.91.229.12 (6 Dec 2007 22:53:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 6 Dec 2007 22:53:12 +0000 (UTC) Cc: Bug-Gnu-Emacs To: "Juanma Barranquero" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 06 23:53:22 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J0Pam-0007Jh-Nw for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Dec 2007 23:53:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J0PaV-0003O8-Te for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Dec 2007 17:52:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J0PZx-00031E-Mk for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2007 17:52:25 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J0PZv-0002zB-R4 for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2007 17:52:25 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J0PZv-0002yu-7K for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2007 17:52:23 -0500 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J0PZu-0001JW-KJ for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2007 17:52:22 -0500 Original-Received: from agmgw1.us.oracle.com (agmgw1.us.oracle.com [152.68.180.212]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id lB6MqHMl004798; Thu, 6 Dec 2007 15:52:17 -0700 Original-Received: from acsmt351.oracle.com (acsmt351.oracle.com [141.146.40.151]) by agmgw1.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id lB6EV1Ex008318; Thu, 6 Dec 2007 15:52:16 -0700 Original-Received: from dhcp-4op11-4op12-west-130-35-178-158.us.oracle.com by acsmt351.oracle.com with ESMTP id 3412204981196981492; Thu, 06 Dec 2007 14:51:32 -0800 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3198 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:17136 Archived-At: > > It is a function, not a variable, so its name should not end in = `-hook'. >=20 > Like allout-find-file-hook, calc-graph-kill-hook, ...=20 > you mean? Yep. It's OK if the function name says to do something with a hook (e.g. = `add-hook', `mmm-run-major-mode-hook'), but I don't see it as = appropriate for many of those you cited. Just one opinion, of course. BTW, at least the following functions have no doc string, but they = should have one: delete-selection-pre-hook, delsel-unload-hook, = ediff-xemacs-select-frame-hook, Info-clone-buffer-hook, = next-error-follow-mode-post-command-hook, ps-gnus-article-prepare-hook, = ps-info-mode-hook, ps-rmail-mode-hook, ps-vm-mode-hook, = savehist-minibuffer-hook, vc-default-find-file-hook, = vc-default-find-file-not-found-hook.