all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "Juanma Barranquero" <lekktu@gmail.com>
Cc: Bug-Gnu-Emacs <bug-gnu-emacs@gnu.org>
Subject: RE: Info-clone-buffer-hook should be renamed
Date: Thu, 6 Dec 2007 14:51:45 -0800	[thread overview]
Message-ID: <DNEMKBNJBGPAOPIJOOICGENIEBAA.drew.adams@oracle.com> (raw)
In-Reply-To: <f7ccd24b0712061433q5773efb5u8d8ecd3782155854@mail.gmail.com>

> > It is a function, not a variable, so its name should not end in `-hook'.
> 
> Like allout-find-file-hook, calc-graph-kill-hook, ... 
> you mean?

Yep.

It's OK if the function name says to do something with a hook (e.g. `add-hook', `mmm-run-major-mode-hook'), but I don't see it as appropriate for many of those you cited. Just one opinion, of course.

BTW, at least the following functions have no doc string, but they should have one:

delete-selection-pre-hook, delsel-unload-hook, ediff-xemacs-select-frame-hook, Info-clone-buffer-hook, next-error-follow-mode-post-command-hook, ps-gnus-article-prepare-hook, ps-info-mode-hook, ps-rmail-mode-hook, ps-vm-mode-hook, savehist-minibuffer-hook, vc-default-find-file-hook, vc-default-find-file-not-found-hook.





  reply	other threads:[~2007-12-06 22:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-06 21:34 Info-clone-buffer-hook should be renamed Drew Adams
2007-12-06 22:33 ` Juanma Barranquero
2007-12-06 22:51   ` Drew Adams [this message]
2007-12-06 22:57     ` Juanma Barranquero
2007-12-06 23:03       ` Drew Adams
2007-12-06 23:09         ` Juanma Barranquero
2007-12-06 23:34           ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DNEMKBNJBGPAOPIJOOICGENIEBAA.drew.adams@oracle.com \
    --to=drew.adams@oracle.com \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.