From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: should search ring contain duplicates? Date: Wed, 3 May 2006 08:54:45 -0700 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1146671795 29907 80.91.229.2 (3 May 2006 15:56:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 3 May 2006 15:56:35 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 03 17:56:31 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FbJh4-0003WY-BQ for ged-emacs-devel@m.gmane.org; Wed, 03 May 2006 17:55:14 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FbJh3-00043U-UK for ged-emacs-devel@m.gmane.org; Wed, 03 May 2006 11:55:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FbJgj-0003yW-PC for emacs-devel@gnu.org; Wed, 03 May 2006 11:54:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FbJgh-0003xi-Jd for emacs-devel@gnu.org; Wed, 03 May 2006 11:54:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FbJgh-0003xX-G1 for emacs-devel@gnu.org; Wed, 03 May 2006 11:54:51 -0400 Original-Received: from [141.146.126.228] (helo=agminet01.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.52) id 1FbJh6-00031x-Kc for emacs-devel@gnu.org; Wed, 03 May 2006 11:55:16 -0400 Original-Received: from rgmsgw301.us.oracle.com (rgmsgw301.us.oracle.com [138.1.186.50]) by agminet01.oracle.com (Switch-3.1.7/Switch-3.1.7) with ESMTP id k43Fsloq003255 for ; Wed, 3 May 2006 10:54:47 -0500 Original-Received: from dradamslap (dradams-lap.us.oracle.com [130.35.177.126]) by rgmsgw301.us.oracle.com (Switch-3.1.7/Switch-3.1.7) with SMTP id k43Fsi1O003602 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Wed, 3 May 2006 09:54:45 -0600 Original-To: "Emacs-Devel" X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1807 Importance: Normal X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53855 Archived-At: BTW, is there any reason why history-delete-duplicates defaults to nil? I agree it should be t. I didn't even realize that variable existed when I started this thread, which is why I asked - why not (always) remove duplicates? I still wonder what the nil use case is - why would anyone want to keep duplicates? See the thread at http://lists.gnu.org/archive/html/emacs-devel/2004-09/msg00038.html Thx. The only argument I see in that thread for ever allowing duplicates is the point RMS raised about a command history. I can see that that might make some sense in a shell interaction (although there are better ways to see the shell history with duplicates). I don't see where it makes sense for, say, the Emacs command history (and certainly not for histories like the search-ring). But perhaps I'm missing something. I think that for most uses of a history it makes no sense to keep duplicates. I'd vote for making the default value be t and letting those few modes where duplicates might make sense (e.g. shell-mode?) bind it to nil unless the user has explicitly specified otherwise. IOW the option values could be: nil - means never remove duplicates t (default) - means remove duplicates, but this can be overridden by a mode (e.g. shell-mode) non-nil, non-t - means always remove duplicates (never override) This would require code changes only for those few modes that want to override the default (t). Plus a change to the defcustom.