From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: German Pacenza Newsgroups: gmane.emacs.bugs Subject: bug#64417: 30.0.50; keymap-unset :REMOVE keyword not working Date: Sun, 02 Jul 2023 13:54:38 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33441"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64417@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 02 18:56:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qG0N7-0008TV-D6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jul 2023 18:56:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qG0Mm-0003ph-Qh; Sun, 02 Jul 2023 12:56:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qG0Ml-0003mV-88 for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qG0Mk-0002oB-Vv for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qG0Mk-0000fg-8e for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: German Pacenza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2023 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64417 X-GNU-PR-Package: emacs Original-Received: via spool by 64417-submit@debbugs.gnu.org id=B64417.16883169022505 (code B ref 64417); Sun, 02 Jul 2023 16:56:02 +0000 Original-Received: (at 64417) by debbugs.gnu.org; 2 Jul 2023 16:55:02 +0000 Original-Received: from localhost ([127.0.0.1]:60970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qG0Lm-0000eB-4L for submit@debbugs.gnu.org; Sun, 02 Jul 2023 12:55:02 -0400 Original-Received: from mail-dm6nam12olkn2020.outbound.protection.outlook.com ([40.92.22.20]:62272 helo=NAM12-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qG0Lg-0000dg-FI for 64417@debbugs.gnu.org; Sun, 02 Jul 2023 12:55:00 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lZpZL0NxQzi7YZbHDJcJegPCulycsE55zOacHbuD2YPHOjQvIDPZ5btpcXwK1d8kqE51oTwBTQuw8XBmM26BzLg7wDfIuxTv276HUz0++DzM8nq+cuQTcFLWwmM2TKUXeHgFVIPZw9Jd6TeBtotqO4bIpLUURhC1xdBTqRLlDPKIrsM/s6G13eTb7YajZuQGhgO0Q0Phq+wX1QcBCrRfZizaHmU795OOKxf3N+UYjjMiALAKoSYzN4fCcOaUrb7N/jnU+skAOpY6LAU69Y2sddKSiVnN39vpRUp/8KEOUAqJNyhr0hyArod1/XEo7GUOyb3/avsj8cCKpcKaUVz+IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9SsaLBjE1+F1nqgQZTdyll5e/e/LAtxTuH2eqmTt8YA=; b=ceuVNRrsSj4VQI+Qh5bu8MPPXPugwqT6jKIomTYvLMIDlQ54QXlHz0wjg+AjJXJskI1sOW4Kn0f+N4jxtBwA/BzpECscsYRiW8+xSzzLfjkTJp+7rR/oQ9T+bRpZ1eg4xGY1KDhBlQFRcmxciLHXG+ROtD31e647yzWQMToHFo07+xr7boBJu7mdPJvlhbl0XJ59FAknXSo1Jkp1i6h3aGzhvX1MCX/KJ+EIC2C0XDdguh7wR/k88q6nixejKRYuPBB6GP9p93AiV5meTOAaUP+NX3Dojrp0QD0gPihnfjN9DPNdi+K1yqSFBjuy1rKpZxpv5Tl5ZOkinZ+vDGp5Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9SsaLBjE1+F1nqgQZTdyll5e/e/LAtxTuH2eqmTt8YA=; b=S6uawzyN61U2+Uf2td+q0WpJNUw1CENXSmtKmkPmeXzY3w22tHdlLweaLqD7srkqqEA/iZgBtV/wNHXxGSBu+4dbjVzR0LfwqX/68X0qe/Dzqni08ybt2GjAO0fFdYG3Wfe2cMMb0ijgcKQpRUa5JVsp8pZFBPawYwa7ShMHfXwVONAqFE1asB1MaPly6gCpF78PBh+2GOx+BL1jGk0LfhNfMl+E1UAIgTKJ0hRaUYfLrAruQnNfttSASnF+odreG+FzzHoodP4/Adqb7cAg3cGHZcODJbzHE8dCbiO1YlOURI3SnZGWoG+GwtVINSVjTqET3Cwhp83PKEBal42tvw== Original-Received: from DM5PR2201MB1161.namprd22.prod.outlook.com (2603:10b6:4:2f::19) by CH3PR22MB4538.namprd22.prod.outlook.com (2603:10b6:610:197::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Sun, 2 Jul 2023 16:54:45 +0000 Original-Received: from DM5PR2201MB1161.namprd22.prod.outlook.com ([fe80::e45c:6831:9564:7b18]) by DM5PR2201MB1161.namprd22.prod.outlook.com ([fe80::e45c:6831:9564:7b18%7]) with mapi id 15.20.6544.024; Sun, 2 Jul 2023 16:54:45 +0000 In-Reply-To: (Stefan Monnier's message of "Sun, 02 Jul 2023 12:02:25 -0400") X-TMN: [d5u0f34ytidbEIJycwtJxtrze5Jj6LO6] X-ClientProxiedBy: CP4P284CA0004.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:128::11) To DM5PR2201MB1161.namprd22.prod.outlook.com (2603:10b6:4:2f::19) X-Microsoft-Original-Message-ID: <87sfa6z229.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR2201MB1161:EE_|CH3PR22MB4538:EE_ X-MS-Office365-Filtering-Correlation-Id: f178ecc7-396d-48d5-8493-08db7b1d09b9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qdKYtVu+ggR8ci3uets3F+o+4HMrbYLFymdeA+c8t72MWwXBKrev7aA1F9TwuUDpdoRMtuQw8KLauxHPfq5RT+Q1WPRMlN6EA4H839AKM5kL29Vs0k+O0W5N0F8XuShEj44AkAyTzqxAsGAcKHeI6l5wFK5kHJtjGidhjm1T+kE5YyzNpP01LZgqxJLYDieYA9ZX/Lxt59lWAYYW5tlCnvDX4zgO5bIwLsOAT/utqwWKj8gbxva52cEaxMv0sW3aZ21lSICM4JgmUfneGaAxfB7eugaSoiXY7OLst/aFN7Ya+UyEqV4PVYTG8Y6ZiuZ5qQDTf34EJmKi9coUQZG0O4RTFWGWHN0NkZystVgaDbMcNq2ZRSGaGnbLkWoSrGHnE84rCo6wBNkI8s3kjBDAMc4C4dAmRk7eHfu2SNp8dS/2pZmkHOjhJU4sgq76QHJERKkZ4CDfjjG0+Ycgi3aXYeb2F39m0xUxJEYns/B0gcQexARfEENyQmIw31oHUv42Rj8zCUDNPt0ygzlUHtP9Q9Jo/FEFG0VvpKFPgz+X07Oe4fDQ0WtByqVPEQMvNt5r X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oBJ/fwEm/GgOuIoxH5TNK4p9/3FSMup0aIrncz9nZ8kHD/EoyTD4w/emjmdjAqeguuR1Rx0lXY1lDdxhtQ6NNE6YCKi7oUPkwIff5zbr9vmvZK8fZYQRgUiQPsBUHIR9x7XOygBf6RHqvmdttWIjvIsvSGpNr0cwhpfruJAmA9jZT2H5Dbi6tqVQ4hVMVLGa/xS9qk42skmdbXzUcNjZp3F/qGZMyur8BACCfGV5O1KVZDoyUROY1BL3HbewkciNpqwY3Jmi/X0tbGspYGQBb9RDU+vuSwWo4eEZ2/WHqYfUDz+LvS/dkdI0Qx8Pb2B1PEJcw0nUNDVn5y+iv137oPtKUEm6vBTaf+onSA+o6qAWWkBfDP3SVU2yOq8eFhKGjaDYZ1XSRuQ7+nvtWlW10hE74icZFmSUS85+NWBvirnaOl78miEopI9cAhB4fnt02eSVqahTDHa/x+FPOB6ppL0q8qEC9ijcO4Z856xVVTbjZq9B847cURXFfsCFW1FRmdFdXAML5naTkYuYL9RlvE1dcT8rIFjDzVWly65LTVZLxS72QbYx1IW2P528Pq4JHv/I5Dxq65WdjRGH6k+YRlpwGqqzBNHDQ50Tr4SIBDigFBhPiVkUzwzc7Foq0We9Dm5dRTcfI+jUTVDmdojjgbEjhhSSwt2gu80dGeFwE6+X24Bu/UoV4W6WE3h8bBY70qQTAWOpbc+oo92lLQDIWCxQDSmNSv9ps1s2JmDR0dlvREQ7hxjLbNhmqe koXoELd3yNzyJLFunS3cYGaLs5uhXrKDNj9uSA3nImEKhuB7A2zDHh8kmPUxwUx97NsidOA0e6lEXa12Q4YWX9UYKvNAuSt9wR X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-c3c87.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: f178ecc7-396d-48d5-8493-08db7b1d09b9 X-MS-Exchange-CrossTenant-AuthSource: DM5PR2201MB1161.namprd22.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2023 16:54:45.2864 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR22MB4538 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264493 Archived-At: Stefan Monnier writes: > Thanks for providing a great example of why the `remove` arg of > `keymap-unset` is a problematic feature :-) > > The technical reason for the above: while `diff-mode-map` has no parent, > the keymap bound to ESC in `diff-mode-map` has `diff-mode-shared-map` > as parent, and `M-SPC` is the same (for keymap purposes) as `ESC SPC`. > Of curse, there's no binding of anything to `scroll-up-command` itself > in `diff-mode-shared-map` itself: the binding is to be found in > `diff-mode-shared-map`s parent, `special-mode-map`. > > So we can't *remove* the binding from `M-SPC` to `scroll-up-command` > without modifying some other keymap. > > So, the code is doing The Right Thing :-( > > > Stefan > I added that line to my init in October last year and it worked fine. I git bisect and found the commit that broke it: commit bb3e0ded9eba71596b34806b302d63977259c3dd Author: Robert Pluim Date: Fri Mar 17 09:50:38 2023 +0100 Don't add a key binding when REMOVE is non-nil * src/keymap.c (store_in_keymap): Don't add a nil keybinding if we've been asked to remove a non-existent binding. (Bug#62207) What I do is setting M-SPC in global-map to 'execute-extended-command' That gets shadowed by diff-mode-map to run 'scroll-up-command', so I use keymap-unset with :REMOVE to remove it. Currently keymap-unset removes the binding _without_ :REMOVE and doesn't do anything _with_ :REMOVE. -- German Pacenza