From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Smith Newsgroups: gmane.emacs.bugs Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. Date: Sat, 10 Jun 2023 13:34:32 -0400 Message-ID: References: <834jnl4ub9.fsf@gnu.org> <831qio4z3d.fsf@gnu.org> <83bkhq2s19.fsf@gnu.org> <83v8fvznmn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31892"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: spacibba@aol.com, 63913-done@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 10 19:35:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q82Uf-00084Y-Sl for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Jun 2023 19:35:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q82UW-0003zO-Is; Sat, 10 Jun 2023 13:35:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q82UQ-0003z6-UH for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 13:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q82UQ-0001Ot-82 for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 13:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q82UQ-0002aA-3v for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 13:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 17:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63913 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63913-done@debbugs.gnu.org id=D63913.16864184869894 (code D ref 63913); Sat, 10 Jun 2023 17:35:02 +0000 Original-Received: (at 63913-done) by debbugs.gnu.org; 10 Jun 2023 17:34:46 +0000 Original-Received: from localhost ([127.0.0.1]:36208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q82U9-0002ZU-S7 for submit@debbugs.gnu.org; Sat, 10 Jun 2023 13:34:46 -0400 Original-Received: from mail-bn8nam11olkn2010.outbound.protection.outlook.com ([40.92.20.10]:56289 helo=NAM11-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q82U5-0002Z9-LN for 63913-done@debbugs.gnu.org; Sat, 10 Jun 2023 13:34:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TK7Kebsd8ctyM/jZDKCbT5b07QFqm99Wa9rW2EAwrr5wf09U3PhrxH5abD2uxit15Bp1gy4CSftanAkkvsVOqDz3yUvi8AhEf+Fl+OCm/tXrbI0Hgqq0cbYxZp9zdNCSSKjN2TkvdArnYk/jX9b2TZU/lUUNGKSKTshjjUOTZ/+6FHWoDvxb72HkAaSJqXPeEI1B/90y2AzmMk4aw9s3FwHmEnqYI5Zk809q0kmyzwCkP0vaiBLgl50CQQQ60dVVt+zmB/99JWAfIdV0YrF2eUcCxbe6pgrlmQAffrJKpf4NKM70LB+2hwSsv6w8GX01hcWuI3ikj0uEiEhynJaPkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dn4fxbcFhjHua9S0xxAmziUgLQgh5s18bF7ZsZAb0KU=; b=OYP5OTvl6yYcsZRdPONDjezxmZxuckGxywvVQI/P/RGI7KzI1EXwfJrIVZpjL/lttLs9gnugAtP6TWPb2Hy8SuRshjvaKa8v03fN+m1xNC6vXgiCK9F551GOHq8w5lHLFcbqdi/rZU431857USaYw90giASsXMs1FT8rkFJXQ1vMoY1O7/BuLUms3zftMoRMA2R4+BLqPBNDzvhrxS2T3T/k238fe5xeVQR1YzYu5KXKGaeEFHjMfRnHI/Ng0WkOtzFOj4Jch0TCLQV95/a6WFerMqA5zha0RVT0B890GPq6ChBP6OysJGJXnaUg+oMTaA4cGcdsuetvHPQwwpwafQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dn4fxbcFhjHua9S0xxAmziUgLQgh5s18bF7ZsZAb0KU=; b=LRLzr4Lm+neJ1j4f6Mw8VbtJpOGBfWLfExh87otSFw1EKv8kh09oH9wN5qLo0hK6/9NNZpJvoBNfCRERAsp0zeTMNedKLdh2D3NEWOaSiQ5SThKnRoeZOLXu8EVEfw4JLGUVP8zMS2yGTqs6HdkdTEIDLADeEvYIwABRbrPZxpFolzVrCjYUrtCxKvCIaSnJ0rWFKKFfrAI5ohtTGf4evts4vHZ0/0g8UEGnYn9rqRPGU+/NJoVxFd21LdTas/FgxN6jqJikRP3O0nMASx2ucpJzplgM5TCl/3F14pmzbyKvjln9hCw91ehW0CYFkt846sIrN75aEJxLq0BByXKRjA== Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by CH0PR03MB6148.namprd03.prod.outlook.com (2603:10b6:610:d3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.44; Sat, 10 Jun 2023 17:34:35 +0000 Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6455.030; Sat, 10 Jun 2023 17:34:35 +0000 In-Reply-To: <83v8fvznmn.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 10 Jun 2023 05:12:54 -0400") X-Hashcash: 1:20:230610:spacibba@aol.com::jho/zhSz4wAEUoPY:0V+D X-Hashcash: 1:20:230610:eliz@gnu.org::rRClE3cFzhBthhnO:3E/M X-Hashcash: 1:20:230610:monnier@iro.umontreal.ca::em2GPgobreBR/trW:2yYl X-Hashcash: 1:20:230610:63913-done@debbugs.gnu.org::bPYLn924vWeIOJqh:5AKr X-TMN: [ikP+6tRKuU5VK3GMj1sFMmmVnpNyRBTr] X-ClientProxiedBy: YQBPR01CA0041.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2::13) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <878rcrb4rb.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|CH0PR03MB6148:EE_ X-MS-Office365-Filtering-Correlation-Id: 76dbb1e9-3db6-4453-b880-08db69d8f54c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ogfd81vczS5bg2vIAZpEGcPSYzaCLsLWtlntjZ43Fhc7qI0GYRljOHHT48S5IFhKuO5AA41TjxiUBoDymDrQ7743AIxCTN6ZuGDy1ZmWgDTYGrbtiR31OwM6WASYumf/Yz+1bQvJyf2rAW4sKR/B1jgItEyOh7pG5bPPsL5LFe6/nWcIxUowIBu5zEWzDa4A6rqUSl+Zz5Gga6+UbwhEh2U+0Em29SGw+voRGg7yVXnMXab1KNVtptLxLQ9fJJqw50doMtUTR3eaTyioxy+2PYdcaTXa96PhXTSNFLNHHnwcmsZJWhKP9U9al2J6oqMuLCxezW0JxBXOdD9l8cl/8oyrkHRGyFystC4ivRK0BJCIYZDbPaWCcBuS+uQOrBokwuMynTItFs4h/w9c37loIvX/L3+8LPOHoGQAQPePnZgK5XzXr7tHu7hsIpSZDX6CpeZ8N2LvFgukgML0rPmCZCJT148Lo4v1O/maC64ri7b7uc+X9rCwwi8axMiDVRMD9iQWQJXi+b5vTto3JgdwEQf1RAe88IMp1c0RfzHrpUlZPrnRIKXQwoMexIAcZ7pJrMKw2nie/ja+umezEEIuLxQEckMGdo4rXU/NaAbt4B1I00Ghx2hEzSrRKCTdvkiX X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: E1UENnDGSXp91QE2mNACTWAyscKlCkZQE8aD1DpB71+rAN/2cFrjVAReUgtEPDGBYlhEr3i9ylUVXkpSBMwA1eeXfAQrXruJ2ueZdEbozNXUrUgWwBXVxVQwPTmOIWt0VqAyzBAy4/sL5SpMbliv9dTdpOE1bxQzztbpXe9/gXGk/4wuEiL+A0ih2n0MLCLRjXigmZdPtk8ndCp7UStgjWE9uK8vMfwVGO/51w7K0tiymLhiuDE9nXAluJwSmvSJTONDELytN1gOUhm+9Q/qHzsADKt6H7Ze2e9gvxzr7Km2GtpzLCt/H2jTB7ekgA6u/tEqsUuSzeFYT46pWA2dj3MSAc+R+w5zW4hHGXl/TA4Bchziefn1sVrytbQVtNr08AjdIGr+qRLaJOFsH2UOr+NLGtIVirHwdMo1w/IJMLQ/+f+MsnCstxbkG61jBj46S/eX5thyCuXq0+fKxxSZP+HTaoiE/tD3CWn9LsBYW9NGuMEKUb68QscSo/4KRmOTFRVBFOc3/ZBp3oDgNRzUTuq2fmMCJ6mRhMHTfYRxoqoIp00rI8PIZ2n6qeB7GO2Sqgco5efSPdEFOtH9hzdQ4f/B/vnd6B+SDlQIimE7765aLqhAdif/0u85KuOYPzvBqY8EglgI8kjqcKBYtFZ30FUivyDcQa1kAtiOHNPWo2TMW1gY+OIjV7D3JSSW8zUbuOGGMCRBbqfWLOT018hDB8hBlZGYz/om+aaQXFtH7oRmzjakNtnFxL8Exu KzbU99gOW7PjLrH8tVeAX/cMHQtOG9j3YF72JmcoTqq7WbsT/98pxF5eO87ub9z+y6hDb3k+MN6WrA/ROO3Kts14aHY4GZe7/x X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76dbb1e9-3db6-4453-b880-08db69d8f54c X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2023 17:34:35.7023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6148 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263229 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > > Thanks, installed on the emacs-29 branch, and closing the bug. Would you also consider installing the test patch I sent previously? I've reattached it here for your convenience. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-test-for-when-completion-auto-help-is-visible.patch >From d2265c26afa087ca38e449490c63e07e60224a82 Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Tue, 6 Jun 2023 15:02:57 -0400 Subject: [PATCH] Add test for when completion-auto-help is 'visible * test/lisp/minibuffer-tests.el (completion-auto-help-test): Add for for when completion-auto-help is 'visible. Also test for successful completion message. --- test/lisp/minibuffer-tests.el | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/test/lisp/minibuffer-tests.el b/test/lisp/minibuffer-tests.el index 1de8e56cbd4..a67fc555772 100644 --- a/test/lisp/minibuffer-tests.el +++ b/test/lisp/minibuffer-tests.el @@ -353,12 +353,23 @@ '("a" "ab" "ac") (execute-kbd-macro (kbd "a TAB TAB")) (should (equal (car messages) "Complete, but not unique")) - (should-not (get-buffer-window "*Completions*" 0)))) + (should-not (get-buffer-window "*Completions*" 0)) + (execute-kbd-macro (kbd "b TAB")) + (should (equal (car messages) "Sole completion")))) (let ((completion-auto-help t)) (completing-read-with-minibuffer-setup '("a" "ab" "ac") (execute-kbd-macro (kbd "a TAB TAB")) - (should (get-buffer-window "*Completions*" 0))))))) + (should (get-buffer-window "*Completions*" 0)) + (execute-kbd-macro (kbd "b TAB")) + (should (equal (car messages) "Sole completion")))) + (let ((completion-auto-help 'visible)) + (completing-read-with-minibuffer-setup + '("a" "ab" "ac" "achoo") + (execute-kbd-macro (kbd "a TAB TAB")) + (should (get-buffer-window "*Completions*" 0)) + (execute-kbd-macro (kbd "ch TAB")) + (should (equal (car messages) "Sole completion"))))))) (ert-deftest completion-auto-select-test () (let ((completion-auto-select t)) -- 2.40.1 --=-=-=--