From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Smith Newsgroups: gmane.emacs.bugs Subject: bug#57367: [PATCH] Speed up em-smart Date: Mon, 05 Sep 2022 17:48:09 -0400 Message-ID: References: <87r10q6byc.fsf@gnus.org> <9257e0e5-232e-7e20-f4d1-385066c4337e@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24750"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , johnw@gnu.org, 57367@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 05 23:49:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVJyF-0006Jx-Jf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Sep 2022 23:49:31 +0200 Original-Received: from localhost ([::1]:33496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVJyE-00022T-4W for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Sep 2022 17:49:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVJxn-00021s-CF for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 17:49:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60371) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVJxm-00086e-AH for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 17:49:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVJxl-0003qC-TL for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 17:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Sep 2022 21:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 57367-submit@debbugs.gnu.org id=B57367.166241450214714 (code B ref 57367); Mon, 05 Sep 2022 21:49:01 +0000 Original-Received: (at 57367) by debbugs.gnu.org; 5 Sep 2022 21:48:22 +0000 Original-Received: from localhost ([127.0.0.1]:49070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVJx7-0003pG-QK for submit@debbugs.gnu.org; Mon, 05 Sep 2022 17:48:22 -0400 Original-Received: from mail-mw2nam12olkn2040.outbound.protection.outlook.com ([40.92.23.40]:32736 helo=NAM12-MW2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVJx6-0003p3-AF for 57367@debbugs.gnu.org; Mon, 05 Sep 2022 17:48:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CG4wRagMeCZexwqOx8TAxr63HNQzUMJdT7zE0bkKjPQ88ps95ZJ7dlMgcJIXlrts+LP4QN8Crh5EmGPBNox1AfH4nCxmGF/xIUwyCNWt2NaLu6y9a9t0CR7USHf3C9/X5qM6lwtJy73eX1eubBR/9ZNu2HUA0ET2Wou6T98y9/qjgSd4TBpUHoHwXpzeoNPVx9wPqpSoOzmqUVhm5YFLFHd3RvktlY8DWs1wxE3AEH8yZDD/DdIw9OhZAcBcqGnl/+ksHXYAzoqx0sB3OEVakZtob08xNaQz+tng+v2Vq+jv9HEzVJDtANg+m0roEmiJXZ4sDFCLlkbVyOhdU8MFNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zdQgneFUGz+x6V2m9HKFmsuxHBSdCc+5YpuRG86i9zU=; b=FPbJu6S3y+A2xrTdH8kzED5ijlV8pDNcLB4MdF4wAktJNXi+KwRw3PjDkEASjpv6iKJnDdmkHzM7ZsceqdFiXh3/tt1UUU5qxWy9XnJDf8FHKfwWmAIF9X8qMSo/C8pWS+E4PQJWCKUJ4qTUveTBhxrCL6/gy77KFldYmrZfEuhQBd0Zmrjna/ZbFsaXTtfvHyCtLf3rRD9Y/SQEzR+W90NfI6rG/1uuk7f7QXy2RhQ305KAweHqDBy8/BGNyPSMJozZ2/rZtBhDgr+0QLV+TzKnVkfArI74G8kpYlZ308MAPqkqA0R3oHka0D/RscqTsyp0xwA7AkRn+O4ew+B1sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zdQgneFUGz+x6V2m9HKFmsuxHBSdCc+5YpuRG86i9zU=; b=ruL46mdf1pssTJuKZ2bSIktM6T9IudL6hbJKi50WHiCNLKD5/Okjh+sONZqs9MECP0ZdoVAhZ+87i7QMqOEhT/3DhxllgHzXyRXw+E2h5H4Zp1O75DEpIjHb4qj7EutiBnWj8GUMJK96eVMUy/5FGYcs3l0xEEsieT/gbkVPd0DSUXwv5N+Zoj8f2vJn+JSP0H1xI7SdJbyu0QyG2OACi+DHHkfxQEl6AdRDBVU7NRrakXRdGb1OUyNJWVUIi0jIsMvRvz7GyLdToD+CgLKbGCkp86XqcIrEPcO7z+mZbUp7XJr29jOVj/jEKnZX0/Vgn7YGowrns/AQxZE4+/th/Q== Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by SA0PR03MB5449.namprd03.prod.outlook.com (2603:10b6:806:bd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Mon, 5 Sep 2022 21:48:11 +0000 Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::1cf8:e25b:a93b:ffac]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::1cf8:e25b:a93b:ffac%6]) with mapi id 15.20.5588.018; Mon, 5 Sep 2022 21:48:10 +0000 In-Reply-To: <9257e0e5-232e-7e20-f4d1-385066c4337e@gmail.com> (Jim Porter's message of "Mon, 5 Sep 2022 12:01:21 -0700") X-TMN: [MsM+OKhy6iW7hjobGbem5PaL97KR8NbC] X-ClientProxiedBy: YT3PR01CA0098.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:85::9) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87wnah5w86.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2fb0570b-5a9b-44ec-5a6d-08da8f885378 X-MS-TrafficTypeDiagnostic: SA0PR03MB5449:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pwFID6hwBZwRubQP3gegXgcK6KjXEf21XcTZ2E+lcbt6SayRcTpdvHpUDOdJr65jQFoXYFmLgqUbP9mBlKponXLLHVGxjxqvRNzQDAmyUW/kwtbiJuym1OWA4LHHgxGf9mOM/twwW5xgrk+SvubuS0rI4cK5uY9OFJR2F0deQ+/JjOJ3AWDVlwpuWs+IfwMcZ/IlpHhQn4GrYYrKhQkseWpe8JXcTLVL/8aFOSi363XVlqp3CmEQNlcKlA+7MBP+R4tD93Z1VUW8KpisymQbBaDW7ixB1FWXZvQ4uneQBh0Po6iQyO3RHGDQjOAAeDc8//iI6l9wL4SZaqRR6k2jxA4aAlKhEmg/uItGGlZBW0iUXjIywqTkeN8rhSJV6MlDx+dSm5LSxiiDX/w7RwIXgYSOhmR02a9xZSlDavLF8xlFUINwAX5MF7nxpuklCkIjAkqejdTpoLpwTOqxfLfVzi6cG/c4NWeo9QQplGcRZKMNfVx4AmJDz1AyZhu3qd1iEMxVcr/3V9Ze2muzjHfiIEiu6uw87OtIyxDALdc+0aPkfjm/O9+OYVkxDpsIkAdbQeecw/AleMwxin2qJebKXQ7o83+mTng8uXx0+ihELqU8YBbq15aWYam6hLsG3Af68FEEyMCcnL3sq7QPxiz9WygnxCUv5KAtajSZBRsY1LyVtq0OHlDbfbEnz4VNjbJ/ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zPTJdzgZVmbhbBNERsuFY+sHa2e3eXySnnnY4ClEhOqELeCJo1FY0h/oq1RdFgeAvU0RzOrnYazFhDO5RhlOllThN9w4nosG2fIHuh656J33Svrv7VOqX40JW+e5P30o+B+PIMD672ZQNrgSzhcUQZUpoPw2opP+fzSIU9DnpyeKZEMwu+YYTtCrZudWZCJF9dMSFP2iUg9lfaP3Rx0USm0A9G0YwAqom9sKn5Vqn8L2YfYw+2Et4z8bz7yo2e1r776Yta1v9xgFgMqqVwmgPLGe70tTHw+Esim1r44HMDjP2R02oyEGb+rJsGThnLeK+nC3EGZCoG6gXmW19EKgZuMGWZiGvBREZRpIkWorHHWHp8/CnOrdCTfQBe7Cqqw6j3TeSSZabywk9fWEBh5xm3GWvK49PZb4dF3+GvpIV+UQEa6Tvq9QtrGq7aGbtDSV1ju8X67huurONc/SGVULLTTQAipTUjKiB3orvFHQlB/59dFQ/UF261WZP/kisSUh3pYs0ZPGYE6SE3oSNJx5QVHzN+YNMTkLZy7+wawXfEkHmSK3gnSgSjSvPB5QbqlV+4CIK6O9LkEqbpFVdV1l15oT/YqBdzlDneOibja0bggjxAuIkOmntdrfbckvnK13Q/bWzh+5/K/J87JdxkGzO5tB9YtGCNuA12dTAye5BzznnYUh1mN0Zme8QR9Pgi0KG7ZtZ635nLA1orUNRf+Yhn7ee/HwWQG5JxHY0TaYJP8iD38ZcoIXFF/+ml OAfGMh6rtGhpfynUIgpkcgNXS/iu9CyXLQByBIRUDwwJ6vopyw9phyUJXL6yHfrsIjPiQX+o3w9B0ro42yfXeBdLcTyymdhfNz X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fb0570b-5a9b-44ec-5a6d-08da8f885378 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 21:48:10.8973 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5449 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241602 Archived-At: Hello, Jim Porter writes: > ;; @ While output is being generated from a command, the window will > ;; be constantly reconfigured (until it would otherwise make no > ;; difference) in order to always show you the most output from the > ;; command possible. This happens if you change window sizes, > ;; scroll, etc. Yep the window is constantly reconfigured and that remains true even with all the stuff I removed. I only removed stuff which forced a redisplay. From what I can tell, we don't need to force redisplays as everything shows up just fine. If I did my job correctly (which I didn't, see below) then there is zero change to the logic and user experience. That being said I have discovered one bug in my patch. I use this little tid bit to determine if I should scroll or not in the eshell-output-filter-functions hook. "(when (eq (window-buffer (selected-window)) (current-buffer)) )" Whereas the previous code used this logic in a few hooks: (walk-windows (lambda (wind) (with-current-buffer (window-buffer wind) (if eshell-mode ))) 0 frame) My code prevents the hook from being run on buffers that aren't the eshell buffer (no clue how but it does) but it doesn't allow the hook to run if the window isn't selected. The old code seems very complicated though and will scroll all eshell buffers. Is there a good way to ensure a hook is performed only on the buffer that it was installed to? Thanks, Morgan