From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Smith Newsgroups: gmane.emacs.bugs Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. Date: Tue, 06 Jun 2023 15:08:26 -0400 Message-ID: References: <834jnl4ub9.fsf@gnu.org> <831qio4z3d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15546"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 63913@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 06 21:09:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6c3R-0003r6-CZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Jun 2023 21:09:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6c3F-00066D-8p; Tue, 06 Jun 2023 15:09:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6c3C-000654-T0 for bug-gnu-emacs@gnu.org; Tue, 06 Jun 2023 15:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6c3C-0003iO-Ke for bug-gnu-emacs@gnu.org; Tue, 06 Jun 2023 15:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6c3C-0001xR-5C for bug-gnu-emacs@gnu.org; Tue, 06 Jun 2023 15:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Jun 2023 19:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63913 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63913-submit@debbugs.gnu.org id=B63913.16860785217497 (code B ref 63913); Tue, 06 Jun 2023 19:09:02 +0000 Original-Received: (at 63913) by debbugs.gnu.org; 6 Jun 2023 19:08:41 +0000 Original-Received: from localhost ([127.0.0.1]:53049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6c2r-0001wr-5q for submit@debbugs.gnu.org; Tue, 06 Jun 2023 15:08:41 -0400 Original-Received: from mail-bn8nam12olkn2015.outbound.protection.outlook.com ([40.92.21.15]:6016 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6c2l-0001wV-Sl for 63913@debbugs.gnu.org; Tue, 06 Jun 2023 15:08:39 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G3zW/qjEXlYh6+qjPDf/6oF5IKKiaaEcb5CYGyRskOdeGQgO2k6PrALNwDtsUf+uPVefOOKman23UAaRcNPCCUQrjThO0JZ+nz2qb3BUkHe8pkF2jMk0bWCYNxSqGw0+vVtQJxRDvnuLBAn5SEMzK1M0izDc+2F89ipo1lW4sw6e0cVa2Sa2aii/tygQBFrRbDqgyFpg8fU7ufZXd/B+Fi1XAtjMDdshbhTcbaIS6llaQzMZGYrsd20DfuiiwExnhYsyXBxEeN2DB8EvzjvU2pvTCh7ocOnaoa0tJSXTrBo8ZxUZsgvhkmfZNUJRs5u+eatLM4lVNHLeQNHILcluCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TiA7+2ECNDH7QYhWHZsB1wdmXGktUuUuM/6SVpWWErg=; b=nMyIDQwbmCrJq5pF3DY7YbfR8PSc865jKzDE8WMO6gBRa+sCGmk6hgXxKDUUnpNBJYfi3puUP6btQxY9Chiv7ZMl0fyLIRbpFliAnL0r8ySadgY5fdJy7t5ssXTitlh3Whv7Y3n6WEbI1pxZTV4VE9p+hynCDVJ1Pf0+of2gG+owA9evXeuie1KwxjqS8aNXXd03vL91AeVFgjJwwSVJs/4Mqx8M4qJcA6nS3pj0VSC0kRSpdPYi+1XJwE3DMHKvIqMNQ2sMIeFZSLOKiiwZnth69vplQcn3yBDcJ1TR6mu1Z+sXnDIP+fD6OPSlnVRtAl2+6Oebfv/gtXfmwMf7GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TiA7+2ECNDH7QYhWHZsB1wdmXGktUuUuM/6SVpWWErg=; b=i0rm3IQJ480haEzuJNg3yO1fiO+NJHqjrpmWhm2z18lhiN1a4w0TksrbyZIw6YtRznhMLZkZRpLcP+2JrN8NTfNXlf3Y0KsHXVe/G+xR3ixP9Evw6S11R9Gd3Qz3mPvwg89uCbiO9s+0Fi0XwvTvgdaFmhgrNd4CK1cX1Ua9tDHJFhu7mCsyHJye5wblYiavgAd68XuxOES49/g8BVF3ISprBCSN/Q6x3lx/AKfuEFVv7N2xkxpbYzoGexspL5uGIIgfk/E5LA6V6wiDBMG6aEvLdR+5uUoCEtHr4td0dYOnuanbPTKE/wv/82rbbrKU7meqsxDvjIb/WUeGo5aZCw== Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by SA0PR03MB5532.namprd03.prod.outlook.com (2603:10b6:806:bf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.19; Tue, 6 Jun 2023 19:08:29 +0000 Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6455.030; Tue, 6 Jun 2023 19:08:29 +0000 In-Reply-To: <831qio4z3d.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Jun 2023 07:19:51 -0400") X-Hashcash: 1:20:230606:eliz@gnu.org::UJZKVDfb2vEA5zRH:68eR X-Hashcash: 1:20:230606:63913@debbugs.gnu.org::sk+7VoQ2AgmQjXAz:3wgG X-TMN: [W3Mc6hWpQ1eQbu89CXwOnwDxJvOw1nhw] X-ClientProxiedBy: YQXPR0101CA0055.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:14::32) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <871qioz9w5.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|SA0PR03MB5532:EE_ X-MS-Office365-Filtering-Correlation-Id: b5b3be15-7df2-4432-1749-08db66c1693e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rfcoWcHHw3OUeuzKV0N7Pk2xFk+mYNE+0PkzaiSrejNF46EFjripSmVdgXFKHczRtJdhpOHYExys+F7G9EMi8FRgZocdXXzF1ZUFmcehHHReDFWIepE7oo1bI3sRbo29AThLgk+cTt73wq4h0NNG+vsorkxQRcHEiD7oUr8UAVt+awO27HLzWrT/ha9dO39zh72wwFlDY/O9EqHJaS50M5crdKTMl2eTBwEv7nMfkTWZquYo8pryvPvcenxrwe7Jakx65bJmCg7SASspuYyPDXFEtKmYKRFreprqQ5WG47olDDeXXCRwGzVKucdfudJMxKBuwz9lkRcu5e1NPiNfNozR81y2MtKvyOp96sdfzj6dQ41Sf1CrjlI0AFIBA87q3Crl2J92kx23Ie+g+WIwZ/XQa055sf0nHNiHYVvIeq7bUJxIpFi/nOywkLK4aSGZ/eC4FaHHnGi6GT2gl0GL94Ld09iYsYR1ZqrM4aZZ2rTJSJmMJkhsITo/itK5mJRU9BC/HQ9XMj6bw77j91cRZPB59iXDFwbtYoNiQRw308mW8IwuVIe9BZq+Ur+yEg4dJanp8TxSjYj/AsrlA2SzHarstPu/FZb9gQOFKSIEIguQhQDiVJEETxnAekASauLB X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iCVYgRG9us10DxpvVs7aY/cPjMX3B2ZliPvyrsarwUFnP+Jk+mU1Cwgee9VIs0oWnYcVYS7NLZCl4EN72fxXrrnGbLLQpd/vjvOGKGiMX95U+k/4fbFrRkFx5oY+EKh+3f3DvP27u93AaRB9+k6/QdTrT5cOGYg/W2FeP3uVTMEYMswWzkjr1oXYkFwWAAoAe1rORyH2DJdO+wAPG7fE+D+Yba7szNgYdqnZHKeUYTWuryNpjoCHOuAAnPee3fHH91fz7951TclzlmSLaBPUiuS7Wh70+Y1b7q7o9nH4DMNbWqhhN+dN49CuEZ0Ico5BWd53HJuHNbudParoOqy7wqk+c+POBex1HbZQiyGPT00e3enyLH3NcUARmmXytCPBxVQ3o0e1CFdEH7wAzVlXDe/XKm0XnDsPxe1n9yiYeGoQ6tBktq0HMxnlSS1oCObosoCry/y261/iKb0PEuNiCMhnvS6/d4e8EQj6L3dmHFQu2asxEbUDLbbGGs18C6slVDlF2aHaqFCigWnIJwyOvPW4WxURrpLYHnUULT8fFPnJwZCRueXZwj4M95lIqjGGa4s0aGxGgJAfXYaAfqXRC4dVLizrcYnoM4Q1HtuDq04yV8+LRTjTuakugyhFjadVS9+2+dFL63aD2nRdHhYZROYmcB1FSbddydlDf6ii2hj1eKA6ZAhlInD98tQjkALglMSPe7hV1wjj4DB5S4aXts0dYMEegpl+pVkOsOFN2pHlCzgfUqYr4+Yyoo ZLG/6BUD0VSHAbg0U5laGpzSU9FRuEKqcnBmW3kgIOac88viWRZFhyx9+Xxv6Fu7TOP09ITUbHPg/yTy1Nmw4MI5OVcMB8mk0p X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5b3be15-7df2-4432-1749-08db66c1693e X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 19:08:29.0844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5532 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263063 Archived-At: --=-=-= Content-Type: text/plain I'm running on commit 7ca1d782f5910d0c3978c6798a45c6854ec668c7 from the master branch. I really hoping you can reproduce it with this: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-test-for-when-completion-auto-help-is-visible.patch >From a1f095c8b26000d7526ce4791767c8a69eb915ea Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Tue, 6 Jun 2023 15:02:57 -0400 Subject: [PATCH] Add test for when completion-auto-help is 'visible * test/lisp/minibuffer-tests.el (completion-auto-help-test): Add for for when completion-auto-help is 'visible. Also test for successful completion message. --- test/lisp/minibuffer-tests.el | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/test/lisp/minibuffer-tests.el b/test/lisp/minibuffer-tests.el index 1de8e56cbd4..a67fc555772 100644 --- a/test/lisp/minibuffer-tests.el +++ b/test/lisp/minibuffer-tests.el @@ -353,12 +353,23 @@ '("a" "ab" "ac") (execute-kbd-macro (kbd "a TAB TAB")) (should (equal (car messages) "Complete, but not unique")) - (should-not (get-buffer-window "*Completions*" 0)))) + (should-not (get-buffer-window "*Completions*" 0)) + (execute-kbd-macro (kbd "b TAB")) + (should (equal (car messages) "Sole completion")))) (let ((completion-auto-help t)) (completing-read-with-minibuffer-setup '("a" "ab" "ac") (execute-kbd-macro (kbd "a TAB TAB")) - (should (get-buffer-window "*Completions*" 0))))))) + (should (get-buffer-window "*Completions*" 0)) + (execute-kbd-macro (kbd "b TAB")) + (should (equal (car messages) "Sole completion")))) + (let ((completion-auto-help 'visible)) + (completing-read-with-minibuffer-setup + '("a" "ab" "ac" "achoo") + (execute-kbd-macro (kbd "a TAB TAB")) + (should (get-buffer-window "*Completions*" 0)) + (execute-kbd-macro (kbd "ch TAB")) + (should (equal (car messages) "Sole completion"))))))) (ert-deftest completion-auto-select-test () (let ((completion-auto-select t)) -- 2.40.1 --=-=-= Content-Type: text/plain It should error out because apparently dings cause ert errors. I did not know that before but I am happy about it. Eli Zaretskii writes: > >> Also that situation doesn't respect completion-fail-discreetly if you >> where to type in a failing completion before the final TAB press. > > Recipe, please. I said this from a static analysis point of view but I couldn't seem to reproduce this with a test. It might be a dead code pathway but it would still be nice for it to be correct. --=-=-=--