From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Smith Newsgroups: gmane.emacs.bugs Subject: bug#53200: 29.0.50; C-S-u shortcut fails with 'PGTK' enable Date: Sun, 22 May 2022 13:44:54 -0400 Message-ID: References: <2ac4ad1d-711a-ce8b-7553-9e9c446f28f1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20488"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: luangruo@yahoo.com, 53200@debbugs.gnu.org To: daanturo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 22 19:46:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nspew-0005BU-0F for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 May 2022 19:46:30 +0200 Original-Received: from localhost ([::1]:38622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nspeu-0005YL-VI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 May 2022 13:46:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nspeU-0005YB-IU for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 13:46:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52387) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nspeT-0007W4-UP for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 13:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nspeT-00038k-TE for bug-gnu-emacs@gnu.org; Sun, 22 May 2022 13:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 May 2022 17:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53200 X-GNU-PR-Package: emacs Original-Received: via spool by 53200-submit@debbugs.gnu.org id=B53200.165324150511990 (code B ref 53200); Sun, 22 May 2022 17:46:01 +0000 Original-Received: (at 53200) by debbugs.gnu.org; 22 May 2022 17:45:05 +0000 Original-Received: from localhost ([127.0.0.1]:46284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nspdZ-00037K-5t for submit@debbugs.gnu.org; Sun, 22 May 2022 13:45:05 -0400 Original-Received: from mail-bn8nam11olkn2103.outbound.protection.outlook.com ([40.92.20.103]:11072 helo=NAM11-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nspdX-00036U-DR for 53200@debbugs.gnu.org; Sun, 22 May 2022 13:45:04 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gn3M+D2k+50M0BnIPExCB1P+hCyfLy4X2KSSpiSr2LTRgHrMeWW5D7MiliOj4mZ6057ve7XBBE0QQybO7QwF55VJL8qsdo8/21/mjdy6wglhj7esDnQTTxxAx27j3xUJrCQeFbi4IzmwKAf0Alq6CwnCbEuRRQ/xG5GXd8/2kfiVpAsm6OB607DlyIcNJbdJGM2PCJA5C7/K4dxujegXph5TP17YR6LWytcazGuf57xuMZ66TdZoS2B2oZginHq6FCj+VP8RMPMDoJan9KLhdOrwPISnykiFaW4V6Urxxam6ywQN5HPz5TZhd2LzJ966jxw25yYM96u44JC8x05/qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h0vU7QTxFPnzouhrynB3iHnSoQcDnjWEJckhof5Dhcg=; b=PSVX5e/PM0i+QigCHkpH0GkyeYArlP7Bi1VH8XOLe2mTzW0YLJkPKuouiIEFAu/FehWXLz6BKiI4KwyTxvX0nDU3oOjRt4c8Iv5ojPDz060lMVOHZX/fN1N3jUfqdiu8d627d0huz25LiBF0Pk0DOeUYKaF2kvKApgFWd/1TNAHQjJwdd+zfVMa72Y7KPMujXFt3++dHsZ2pRD/GsInnVcYfYGEE8bq+RdR1EgFLvWgv97g26zDIOKtbseqZxYmMlDpBo9el1sKOaPEUkkvbrpLnUZd7/pMMZZUCNRAttmVlwxkLWlohMe2iteDiqJuKiO8MxXP+os3YFl9WGgI5HA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h0vU7QTxFPnzouhrynB3iHnSoQcDnjWEJckhof5Dhcg=; b=qqVyyR+ilagApD0E92eFjAEIkMqX6xb6Cqp690/pqtNCr5mPECzfwk3Yhgb8HFWyGdqy2gd67FFtNMOdKuAPF3q4z2Mjnobj2uprRC0O4JAU1TCkXgYMapJY3vYOFSup0jB2jjWmDbVj1seJGSSkAAHvpssK1Cs6i3zxjba59D0tqSKCkY8B6Z9IPNb9TqdoiwrI0VHARLuIcz9PRNRc47/ywmPprvdEKynWh7DI0imhlgrO6vqgOYAeJIxz69S2Eqhn4aUFXRfU6aWObdM5caDcAqrfNhBvYmoypMy+9o+V5+rfFS0fkElvzc7BjhWMMj9NVTFIJZ3MdQCSm8WD3Q== Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by CH0PR03MB6161.namprd03.prod.outlook.com (2603:10b6:610:d0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Sun, 22 May 2022 17:44:56 +0000 Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::a0ba:5643:dda0:2e64]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::a0ba:5643:dda0:2e64%4]) with mapi id 15.20.5273.014; Sun, 22 May 2022 17:44:56 +0000 In-Reply-To: <2ac4ad1d-711a-ce8b-7553-9e9c446f28f1@gmail.com> (daanturo@gmail.com's message of "Sun, 22 May 2022 23:25:05 +0700") X-TMN: [F9X5DJtB8YMI5iHtPG4MYgjkdBpVq3I9] X-ClientProxiedBy: YT1PR01CA0124.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2c::33) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87fsl1a2cp.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1246faa6-0553-4c85-3f29-08da3c1ac8d7 X-MS-TrafficTypeDiagnostic: CH0PR03MB6161:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iS3yK49MceoZ3Z6LcpgJMgEflvev5Sp6t5nj+VZqg40kp9HqqE2/uRAWYLI9FFaUFJvC2ceIkuiyxbffioPclCTEbBwxQ3sAIai08d4PgBsGTepO/rRpoD/o17IlLTQ7ut3hEra8dK0JgCTnwiFBDHBzUOft0B357LM/xqyEjidaqD8oolkDM5Y57s3jzndVwR4yBcULmKm/XRX5igzqZcrjtM7cmvgixUwWbHWtzRWxY3rDOoezUucrjrPbdbJsu9QKhURVdBgbYw8XO0DaxSlVL7hgaOPjBcYVaPqt4EykgbtC9oiBV+QDe+vRQnBpo/M7qTPyHiYNObhdbKFKt0Z+tm6QDBkPpjrDltrdpw6DKDfdhAuRKr/ItxTTB/i5RjPY9QuiGSdSahmvkqhFPHH2U7Se69RjHeDLU3i0xl2NlAw7RWAEFoGW5Di2Y2MdQxMEPr3cGldRJ7KPMciyphBrs5ej56bS171wMcLhTXC90j2gyRKt7urAEpw8KLjNssCOEp5unfJAnF3clXnxO2w6QXiilQYbZaaiEuwR5Qj7MXVkHCgpz2QqsGAs/nVQEETb9YrJMAHAfGDjz9cTuQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: k1myuLjXUWIZuuWS6aDCC95p8HgWsR09nz4e13hpK6VKSgSwo1UCH2wkzexSJes/lTR/97lQRqhsbceeD/bOjQvhgSEHI2Oj0GfEbl9YY5OT4giypLA8aqtz30ScyRqGJUsRWSEHc2HZVUhRQRfuWVPGwas325LcUO1+65fpvPLqyoNpQwjznBMS/cA4U/nBSgAXTxa9l6DrFnhNvUnWccDwNlYRDxAZ4U3+4PXkdJeJ4L1sIyatO7VDDPCE3jTbH5psEKhjGcUx8MEXMs5Weo3O+0Q57l2fjlg7YH+1H4qn1uM136UpTFRN5uoeW086cd8L21ejZO+CUGnXibHMV+Xpgoy4vKOC4kYKjMfpRA5NLdF0uxH7OkG2X2XPcHkZTWpotmdZTId9FMhmaxdli6Dd/ZBuhjb/f/Se3RR2eVslEM4aZvh8n7gTmsTO/d2SRR7IIIm3h8jGiVHkJe+qu4BG/3zcVe8ANChIbMfEG7vDXwNaRFl6xaIkr1nVSfoLhwXGU3QSLC2inPwkhyYv3/T2c6CWSgg3YiZk9+DWM2B1128Qhj/uh9cnxCdqvgxB6i00vYbQdEQGymUIkM/uJASRfpkQJZppCtkv0/SwXXOPy06dUUEkGWpWlgasxgxjMgZC35UoMkzFjMGFwhwZZEJnViwHU5Cg3eV9XFzSsp+k5my1MT0262HUEulHnqL2lr90aVkoB2gfxga+02teswgxzVJ1wUH+4N39OmZ5W1XdL4/RwQJyraQCK4 T+ueQbt5vgJndUWbDlLLo7X0AnQ5UqVsTEQs8BBvlPf/myTnM2cegNqPEsy0d2h23SMJWsF9ITsun4fKWU7SwQ+b3lGzGjdVs7 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1246faa6-0553-4c85-3f29-08da3c1ac8d7 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2022 17:44:56.6618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6161 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232913 Archived-At: Hello, daanturo writes: > Emacs is unable to recognize any Super-modified keys. My bad, I gave the wrong git hash. I meant this hash: 1c1ae6ba80. If you want to re-enable super modified keys you have to make the following change. If I remember correctly Po Lu thinks this is a bug in some other software and that the GDK_SUPER_MASK bit should be set so they don't want to add the GDK_MOD4_MASK bit. Personally, I think GDK_MOD4_MASK should be added and we should just add a todo comment to look into it more later. I suppose the thought is that in theory someone could use MOD4 as a custom modifier instead of using it as super but realistically I think someone trying to do that would have lots of problems. It would be cool if that was possible though so I do support trying to rid ourselves of odd grandfathered in quirks. diff --git a/src/pgtkterm.c b/src/pgtkterm.c index b9d0b7b512..3ef643a075 100644 --- a/src/pgtkterm.c +++ b/src/pgtkterm.c @@ -5018,7 +5018,7 @@ pgtk_gtk_to_emacs_modifiers (struct pgtk_display_info *dpyinfo, int state) mod |= mod_ctrl; if (state & GDK_META_MASK || state & GDK_MOD1_MASK) mod |= mod_meta; - if (state & GDK_SUPER_MASK) + if (state & GDK_SUPER_MASK || state & GDK_MOD4_MASK) mod |= mod_super; if (state & GDK_HYPER_MASK) mod |= mod_hyper; @@ -5151,7 +5151,8 @@ key_press_event (GtkWidget *widget, GdkEvent *event, gpointer *user_data) /* While super is pressed, the input method will always always resend the key events ignoring super. As a workaround, don't filter key events with super or hyper pressed. */ - if (!(event->key.state & (GDK_SUPER_MASK | GDK_HYPER_MASK))) + if (!(event->key.state & + (GDK_SUPER_MASK | GDK_MOD4_MASK | GDK_HYPER_MASK))) { if (pgtk_im_filter_keypress (f, &event->key)) return TRUE;