From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Smith Newsgroups: gmane.emacs.bugs Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. Date: Mon, 05 Jun 2023 15:09:02 -0400 Message-ID: References: <834jnl4ub9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2868"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 63913@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 05 21:10:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6Fav-0000aW-4y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Jun 2023 21:10:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6Fae-0001Qq-MI; Mon, 05 Jun 2023 15:10:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6Fad-0001QS-6a for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 15:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6Fac-0003iY-Uj for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 15:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6Fab-0000Jw-Pr for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 15:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jun 2023 19:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63913 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63913-submit@debbugs.gnu.org id=B63913.16859921621176 (code B ref 63913); Mon, 05 Jun 2023 19:10:01 +0000 Original-Received: (at 63913) by debbugs.gnu.org; 5 Jun 2023 19:09:22 +0000 Original-Received: from localhost ([127.0.0.1]:50378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6FZx-0000Iu-MY for submit@debbugs.gnu.org; Mon, 05 Jun 2023 15:09:22 -0400 Original-Received: from mail-co1nam11olkn2062.outbound.protection.outlook.com ([40.92.18.62]:60609 helo=NAM11-CO1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6FZs-0000Ic-Ln for 63913@debbugs.gnu.org; Mon, 05 Jun 2023 15:09:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/nIG6xLbf8vyOo2oXhPTQI7bCA0LlJ/QtDlX5eZVIMaivDnT7XuahyftbNHLGiReRZtfF533tNdZkqFnlgnG3Yc6ndNDyb0p1MuBJea09mPsSrCRCfwCtsjryeopYLOCwjX3JCNj3eJ9/WiLG/IiVIB1vrD+ge9UK+c8Wida2wGiVLpqa/Pt2yzXyeocyHUpW6/fjPI2MqqUgBUmNBf7zegW+oqWuG0ay6gy4Anf0zBvj3e8uqeb9pSCxSsrA7hWTLpqgeSZQjP94SS74o6GskpeBG2QjQtqxh9g5IIy9EW9N+zAdoTQPREUV2YRLelLK6WIfgPXB/r89lyuudOEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y2fMwu44XF/ULmYSX7Mv/H0KptnJ5GafOEIpzSKlOuc=; b=dw22z2xnmpq2RyArthuRqePkqUXabia+gy9R7zgz3jBNXn4U9Fie8EBvgbupCwjW5DH1jiiD1iiERc3lOrkX26qaXKlP6GsLTzRO57sqJWV21+9l3uFy2JXecvLxnr4v2anlsiCMvZbUABLD8b8qfsJ7xLO65FXNmAN2ZPcbsjtTYPSMfh/PIy0Y0GY+GsA4lgI6wHuHzXcCP4t5+LlJ8dUOOkFv1BkkRfHMETjn06nkIt1bnyyLxiyLZK3ZQhzlxO8cGTnl+p0w4omvV6ch2rOx0EA4u1Kx3jPG+wlb+bc79CziivDl8pKNxhTQOhIIJ17KybMYeknIUlx2PBuR3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y2fMwu44XF/ULmYSX7Mv/H0KptnJ5GafOEIpzSKlOuc=; b=I2hWHGIbXH7elEms+ONfHJI/A+9QKGdj3ybTTZQ4Fj6CMKv0ABD2nsSWrxo5lWOumDkqwTLRd/WBOWzr6FusJDMRRYw3nKqzHY88Im8t7yLBx6ispINLt4pFRGe4A23gSzPaWVyqwyDGtcWYyPmOdjZap6mieD38WqEm70RcgPSb4P3gSjDdaYmFSM7R15ZHfHPAczeGZTcd51wVioiG1wzENYZtB+/3N+yF4Mfw0bozuoTuB7L7uLsB89/tezJj6XoOhfyXqOG1Z2ImcgCyDjU3bBJy8Rqi1f8W3WWdIMEJugAmBDwtPgmTxt8hFck6NCs5Ha6DiHuJQHyHMXQ4MA== Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by SJ0PR03MB5421.namprd03.prod.outlook.com (2603:10b6:a03:289::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Mon, 5 Jun 2023 19:09:09 +0000 Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6455.030; Mon, 5 Jun 2023 19:09:09 +0000 In-Reply-To: <834jnl4ub9.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 05 Jun 2023 14:50:53 -0400") X-Hashcash: 1:20:230605:63913@debbugs.gnu.org::ht7HAC547XCXxwcM:2eQj X-Hashcash: 1:20:230605:eliz@gnu.org::q+3GX7uoYvta9SWs:9Li+ X-TMN: [R2Wa+etnAHV9Bx3UR/T7YufB/eS8GyAq] X-ClientProxiedBy: YQBPR01CA0047.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2::19) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <874jnlvi9d.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|SJ0PR03MB5421:EE_ X-MS-Office365-Filtering-Correlation-Id: 47f7a382-6277-4279-6782-08db65f856ed X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +jyjcMZVjcuDtFBIlyNG6HR4UjKdQhTaJ5L27AZiAGEUaZWfs0lBOzn0R6UzFwqD96EuD2YSskiBJfcx6pgBIE2rrTehLbbnHW6CIiSRINbNK6TuKadV5DgAjwzPv/Rk/OINefNrlEx9qh2AlmIrDQhXjmLBepD/h8ewbQQUjcfgxUVDOWrPhlShjE78qrIGRSl7nus4vEP/Iupk0gTRHamq/nRHXUUAXEwQezmbbOjOkw0y+2Ibm+U57zO543lVy/r+u9/Oh4P6rXkAbocOzFDZyxTzoEALbRkk2bIMsk1jYnu4t9d2kHJsY4p+A0v5MLpCrsoGgiV4zi0ObVIZfOHtpu4ETuV8conaDCrrmlh9dNFDygDqsldaHKFahVTNyiAuchb/boOS9aVMU5PExMxcYDU4OvJa+chqzDLIRIMr3eDpmWtj++pP95ZjUm+muIEPGVKVjJAgsM79hLobq7XZ/YVuBwN/RcPRphYREgBlS7QHi54fnUxh0XCKJM5HDJ42HqjVmU1RberrOzQTHY38HsUTDvKn7F8L6VohY1scnJtAePEk1L/QguN5B+xGN3imZB3Rl75boV3J/Slk1hp1jBJr+GDuNh/Vb8fIVvw= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4H+WaZNQ13AQ0AaqJRTdxb+SeJE9nOOruUJGcAafn6EdS5NglIOLKayDRscV1vCqAh/yeYC0KM384fpiEH0SdxofwuAyxlA/Ak9gc+9WNT69JGoWMS0HWngJvOjiFf5xc2hAnJhreKKdvbQX9YO8b+0YFE6x3a9RPZkbhBr/beltZ30j+/VWPA986qISIMepo/AW0GrTc2uhGTccSTF2zo6ewyEZiTK6R1+7Ng0vTLBy7Rz4nAqHlS39pxu2SkFIkXRG6R/Hns/xA4n/ppPw1nouRKD747NjHb9BVzVKoTm9vpBesxp7rNatZia8eHz6Z4xGdRzLdxhbxeQkF8Rf3VyiCkATfUAgW5yQI8o9bl7Lk98p/SWpR5AuLb1+kYaqlWDLIKw37PQsQ/I7csp/BeZ0heDqzuoSOYbNjyYLgockSuGHKukDAQcR+zo4aICD9QxQoK9KjuQoPWYzNnq7YgfA1sRJAKFCK5V9RwKDCk14H3ySKNqlTWiihSFHnAkDb8+6DmMT3oZR1wduOO65zE/EVPQjmr8GK/Oj1wywEDciuogI2a8mHub84/OECgFkkx5f6dufpZyN8nrbO3iIn3CejTmyVHLut0KTkbowp88Be1nnmSD/C7wpWlUpYic2PumzqAZBTIPDegbNdzSCRtiScbL6glUCOT8fy94sKUwfmwVM844zvUyT6J58cwgJDRC26TOcNFCNcmZp5dAUFGkRkdVuh5oL9wMEYjYhKg3+ZwVmvh94P2EozY E+lOBXAZJMjPbciOeDQRDD3W/Xj8vH0biG0AePMjmN0oXgz0aXlZ2cirkm/YiQG/pgU9Msk+oR/WNqal/va5W4ZR44/6pker5Z X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47f7a382-6277-4279-6782-08db65f856ed X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 19:09:09.2990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5421 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263029 Archived-At: Eli Zaretskii writes: > > Sorry, no, it isn't obvious to me. So please do provide a complete > recipe for reproducing the problem, starting frm "emacs -Q". > > Thanks. I apologize for my assumption. emacs -Q (setopt completion-auto-help 'visible) (debug-on-entry 'ding) ;; just so we know when it dings `M-x eshell` then spam TAB until the completion buffer pops up. Now type in enough to select a unique completion. I'm completing `eshell-command` so I'll make the minibuffer look like 'eshell-comman'. Now press one final TAB to select the only available completion. It should ding. Obviously it shouldn't ding in that situation since it is a success. Also that situation doesn't respect completion-fail-discreetly if you where to type in a failing completion before the final TAB press.