From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: help-make-xrefs Date: Sun, 26 Aug 2007 23:33:42 -0700 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1188196519 4575 80.91.229.12 (27 Aug 2007 06:35:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Aug 2007 06:35:19 +0000 (UTC) To: "Bug-Gnu-Emacs" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 27 08:35:15 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IPYBs-00015K-5B for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Aug 2007 08:35:12 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPYBp-0001Sx-2a for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Aug 2007 02:35:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IPYBm-0001Ss-Og for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2007 02:35:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IPYBi-0001Sc-01 for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2007 02:35:05 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPYBh-0001SZ-O4 for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2007 02:35:01 -0400 Original-Received: from agminet01.oracle.com ([141.146.126.228]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IPYBh-0003rL-CF for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2007 02:35:01 -0400 Original-Received: from rgmgw2.us.oracle.com (rgmgw2.us.oracle.com [138.1.186.111]) by agminet01.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id l7R6Ywgb005070 for ; Mon, 27 Aug 2007 01:34:59 -0500 Original-Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by rgmgw2.us.oracle.com (Switch-3.2.4/Switch-3.2.4) with ESMTP id l7R51nV8013818 for ; Mon, 27 Aug 2007 00:34:58 -0600 Original-Received: from dhcp-amer-csvpn-gw1-141-144-64-31.vpn.oracle.com by acsmt350.oracle.com with ESMTP id 3159059701188196401; Sun, 26 Aug 2007 23:33:21 -0700 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3138 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16453 Archived-At: help-make-xrefs tries to be smart about providing links, but it could use some improvement. In the *Help* buffer from `C-h b', for instance, it provides links for commands that follow `M-x', even for cases such as `C-M-x'. The comment for this code says "An obvious case of a key substitution", which is not correct in this case. The regexp should at least be changed to prohibit a symbol character just before `M-x'. Another problem in the `describe-bindings' display is this code on line 465 that tries to back up over non-whitespace: (skip-chars-backward "^\t\n") This works only if `indent-tabs-mode' is non-nil in the *Help* buffer. The string should be "^ \t\n" or equivalent. Otherwise, no commands are linked. In GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600) of 2007-06-02 on RELEASE Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --cflags -Ic:/gnuwin32/include'