all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* help-make-xrefs
@ 2007-08-27  6:33 Drew Adams
  2007-08-27  8:10 ` help-make-xrefs martin rudalics
  0 siblings, 1 reply; 2+ messages in thread
From: Drew Adams @ 2007-08-27  6:33 UTC (permalink / raw)
  To: Bug-Gnu-Emacs

help-make-xrefs tries to be smart about providing links, but it could
use some improvement. In the *Help* buffer from `C-h b', for instance,
it provides links for commands that follow `M-x', even for cases such
as `C-M-x'.  The comment for this code says "An obvious case of a key
substitution", which is not correct in this case.  The regexp should
at least be changed to prohibit a symbol character just before `M-x'.

Another problem in the `describe-bindings' display is this code on
line 465 that tries to back up over non-whitespace:

 (skip-chars-backward "^\t\n")

This works only if `indent-tabs-mode' is non-nil in the *Help* buffer.
The string should be "^ \t\n" or equivalent. Otherwise, no commands
are linked.

In GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600)
 of 2007-06-02 on RELEASE
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Ic:/gnuwin32/include'

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: help-make-xrefs
  2007-08-27  6:33 help-make-xrefs Drew Adams
@ 2007-08-27  8:10 ` martin rudalics
  0 siblings, 0 replies; 2+ messages in thread
From: martin rudalics @ 2007-08-27  8:10 UTC (permalink / raw)
  To: Drew Adams; +Cc: Bug-Gnu-Emacs

 > help-make-xrefs tries to be smart about providing links, but it could
 > use some improvement. In the *Help* buffer from `C-h b', for instance,
 > it provides links for commands that follow `M-x', even for cases such
 > as `C-M-x'.  The comment for this code says "An obvious case of a key
 > substitution", which is not correct in this case.  The regexp should
 > at least be changed to prohibit a symbol character just before `M-x'.

After C-h b I get the line

C-M-x		eval-defun

with a `help-function' button labeled `eval-defun' which doesn't seem
entirely wrong.  We could change the regexp in question to

"\\_<M-x\\s-+\\(\\sw\\(\\sw\\|\\s_\\)*\\sw\\)" nil t)

but that might break other uses of `help-make-xrefs'.  Alternatively we
could write

"[^-]\\<M-x\\s-+\\(\\sw\\(\\sw\\|\\s_\\)*\\sw\\)" nil t)

Suggestions welcome.

 > Another problem in the `describe-bindings' display is this code on
 > line 465 that tries to back up over non-whitespace:
 >
 >  (skip-chars-backward "^\t\n")
 >
 > This works only if `indent-tabs-mode' is non-nil in the *Help* buffer.
 > The string should be "^ \t\n" or equivalent. Otherwise, no commands
 > are linked.

I fixed this on 2007-07-02.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-27  8:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-27  6:33 help-make-xrefs Drew Adams
2007-08-27  8:10 ` help-make-xrefs martin rudalics

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.