From: "Drew Adams" <drew.adams@oracle.com>
To: "Emacs-Devel" <emacs-devel@gnu.org>
Subject: toggling a minor mode should not tell Customize that the value has been set
Date: Sat, 5 Jan 2008 09:48:47 -0800 [thread overview]
Message-ID: <DHEEKFAFJEFOJHLCFPFDAEGACDAA.drew.adams@oracle.com> (raw)
`define-minor-mode' adds this code to the definition of every minor mode:
(if (called-interactively-p)
(progn
,(if globalp `(customize-mark-as-set ',mode)) ; <=== WHY?
;; Avoid overwriting a message shown by the body,
;; but do overwrite previous messages.
(unless (and (current-message)
(not (equal ,last-message
(current-message))))
(message ,(format "%s %%sabled" pretty-name)
(if ,mode "en" "dis")))))
This means that if you so much as toggle a global minor mode, and you later
use `customize-customized' to see which options you have edited and set, the
minor mode variable shows up in the list of customized options.
This is wrong, IMO. Toggling a global minor mode should simply change the
variable's current value; it should not also tell Customize to set that
value (or tell it that the value has been set).
What was the rationale behind this behavior? Why should toggling
`iswitchb-mode' or `icicle-mode' tell Customize that the user has customized
the mode variable?
A user should be able to use `customize-customized' (including perhaps in
`kill-emacs-query-functions') to see what s?he has customized and might want
to save. It is unlikely that a global minor mode variable is in this
category, and if it is, it should only be the use of Customize that counts
for this, not merely toggling the mode.
next reply other threads:[~2008-01-05 17:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 17:48 Drew Adams [this message]
2008-01-06 2:14 ` toggling a minor mode should not tell Customize that the value has been set Stefan Monnier
2008-01-06 8:01 ` Drew Adams
2008-01-06 16:16 ` Stefan Monnier
2008-01-06 20:47 ` Drew Adams
2008-01-06 21:20 ` Stefan Monnier
2008-01-06 23:00 ` Drew Adams
2008-01-07 1:32 ` Stefan Monnier
2008-01-06 22:41 ` martin rudalics
2008-01-06 23:41 ` Drew Adams
2008-01-07 1:26 ` Stefan Monnier
2008-01-07 7:34 ` martin rudalics
2008-01-07 11:31 ` Richard Stallman
2008-01-06 10:46 ` Richard Stallman
2008-01-06 16:19 ` toggling a minor mode should not tell Customize that the value hasbeen set Drew Adams
2008-01-07 17:15 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHEEKFAFJEFOJHLCFPFDAEGACDAA.drew.adams@oracle.com \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.