From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jean-Christophe Helary Newsgroups: gmane.emacs.devel Subject: Re: package.el strings Date: Thu, 26 Apr 2018 22:32:59 +0900 Message-ID: References: <83y3rpeubc.fsf@gnu.org> <07C02D08-66BB-4454-AA25-B512BFC39A2A@gmail.com> <83vamk965y.fsf@gnu.org> <84FCCBF3-F20F-48E2-B05E-F6DB218D8896@gmail.com> <87lgdarcwi.fsf@gmail.com> <87in8eqk93.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_F7250C6D-7B2A-40BD-BDE0-56E983B3EE1F" X-Trace: blaine.gmane.org 1524749472 21870 195.159.176.226 (26 Apr 2018 13:31:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 26 Apr 2018 13:31:12 +0000 (UTC) To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 26 15:31:08 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBgzM-0005ZL-4T for ged-emacs-devel@m.gmane.org; Thu, 26 Apr 2018 15:31:08 +0200 Original-Received: from localhost ([::1]:42363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBh1S-0002Xv-Se for ged-emacs-devel@m.gmane.org; Thu, 26 Apr 2018 09:33:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBh1L-0002Ws-26 for emacs-devel@gnu.org; Thu, 26 Apr 2018 09:33:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBh1G-00076q-GZ for emacs-devel@gnu.org; Thu, 26 Apr 2018 09:33:10 -0400 Original-Received: from mail-pf0-x235.google.com ([2607:f8b0:400e:c00::235]:42019) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fBh1G-00076C-8G for emacs-devel@gnu.org; Thu, 26 Apr 2018 09:33:06 -0400 Original-Received: by mail-pf0-x235.google.com with SMTP id a11so387669pfn.9 for ; Thu, 26 Apr 2018 06:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:date:references:to:in-reply-to:message-id; bh=pydb+7JGnKK9DzymEDa2QukNi/m0H4BrX04vB3MaZI8=; b=mc3y7Fye9TP7k3+MIP0bz2BmwrZJU5D5GNKCS+Nxz+YVb/DNphb5c5ZPTGpCXCgx4h occCsld4qTybmYdaysGd64gBGtBfJBynq2HBpgMNElcQd+e/ObMoMtW+doH81kLnTO8i 0a3Fgb2s/OXcpKfyx1zKfyheYv4uY37aWpeqX24C8gDr23st9GeDC8HpmtVcrsMTvvl5 W1nMhuEvvzIBrZHTof3OrIY/D5SQPl2xNeIpChmMLxkMMGO5ZyE7VQknNatAoLXX0k5b g6KJfiAYzJexg0vqYEGsUjcFdUCG1MjdiZW4xMvWxMR5MEv5oVIsU5rLO7+TUpYXrpjh oXeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:date:references:to :in-reply-to:message-id; bh=pydb+7JGnKK9DzymEDa2QukNi/m0H4BrX04vB3MaZI8=; b=k1RTlHwtmNBrO1/YNXEFsP2E/q6XzhTQDyTI6ocsfGGyc/QfaYC1kurXu1s3pBs2iu 2fQX0fRJxbsx1Zg9o32Dhh1sL5iUBfXO06OAsdnsURFE4Cy2E8aL33k07n8YbIeoARRo 0xDwQm6BecKHfHKCGW9ggnDh3T3pZvoS6t7IGHqE6MtVPj+A3jOnIOsuhEYc48Ot/Pxg qxpKQsv4+opBBTsc9u6Qjuf5BwXiIKI2wJZCzfhjCLV0KKRn6v6pshYFk6Bkl94s6cfo WOQZ+PTGF4JUnv6/JGLx+3H1bVZ5vlKRD1IOZ3S7ieqOZHIro8Em6ZtTZVybo0I4lVij /U4w== X-Gm-Message-State: ALQs6tDBe26UyK+s36/nph9XTFaKnA9B2VKKcl7XJocIAxRY7e4x9f+x kmtKDCnbCqUdDhhDPqYmgiVcgQ== X-Google-Smtp-Source: AIpwx4/NTUPmE+770LUyvSSe3rg1sgqH9jXw0eeT0zImPxQEm2pZfhuJQrGuRBRjUgdR60U3aB1rvg== X-Received: by 10.98.5.196 with SMTP id 187mr32255040pff.151.1524749584972; Thu, 26 Apr 2018 06:33:04 -0700 (PDT) Original-Received: from [192.168.1.7] (pl31219.ag0304.nttpc.ne.jp. [111.89.224.243]) by smtp.gmail.com with ESMTPSA id y10sm38042635pgq.30.2018.04.26.06.33.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Apr 2018 06:33:03 -0700 (PDT) In-Reply-To: <87in8eqk93.fsf@gmail.com> X-Mailer: Apple Mail (2.3445.6.18) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224905 Archived-At: --Apple-Mail=_F7250C6D-7B2A-40BD-BDE0-56E983B3EE1F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 26, 2018, at 20:28, Noam Postavsky wrote: >=20 >=20 >> I'm not sure I understand the question. This format call produces >> messages that are semantically equivalent to the original concat = calls >> but the concat calls were not localizable so I changed them to = something >> that we'll eventually be able to properly extract and localize. >=20 > I meant just the outer (format "%s%s%s%s" ...) vs (concat ...). Is = that > also needed to make strings localizable? If yes, I think adding a > comment would be helpful, because it looks a bit unnatural to me. Oh, you mean (format "%s%s%s%s" ...) vs an eventual (concat "%s%s%s%s" = ...) ? I checked the lisp ref to find something that would make it a clear = choice but did not find anything really conclusive. What I did is I try to keep concat for simple strings. And anything that = involved fixing complex native strings was either moved to format or = something else. There is nothing that makes concat of format etc more or less = appropriate for l10n in my understanding. I guess I was influenced by = the way the original authors abused concat to put native strings = together... >>>> + (message "Operation finished. Packages that are no = longer needed: %d. Type `%s' to remove them" >=20 >>> This line is getting pretty long, perhaps it should be broken up? >>=20 >> I guess you mean the line of code? >=20 > Yes. It there a length limit in emacs code ? Jean-Christophe Helary ----------------------------------------------- http://mac4translators.blogspot.com @brandelune --Apple-Mail=_F7250C6D-7B2A-40BD-BDE0-56E983B3EE1F Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On Apr 26, 2018, at 20:28, Noam Postavsky <npostavs@gmail.com> = wrote:


I'm not = sure I understand the question. This format call produces
messages that are semantically equivalent to the original = concat calls
but the concat calls were not localizable so = I changed them to something
that we'll eventually be able = to properly extract and localize.

I meant just the outer (format "%s%s%s%s" ...) vs (concat = ...).  Is that
also needed to make strings = localizable?  If yes, I think adding a
comment would = be helpful, because it looks a bit unnatural to me.

Oh, = you mean (format "%s%s%s%s" ...) vs an eventual (concat "%s%s%s%s" ...) = ?

I checked the lisp ref to find = something that would make it a clear choice but did not find anything = really conclusive.

What I did is I = try to keep concat for simple strings. And anything that involved fixing = complex native strings was either moved to format or something = else.

There is nothing that makes = concat of format etc more or less appropriate for l10n in my = understanding. I guess I was influenced by the way the original authors = abused concat to put native strings together...

+ =             &n= bsp;  (message "Operation finished. Packages that are no = longer needed: %d. Type `%s' to remove them"

This line is getting pretty long, perhaps it should be broken = up?

I guess you mean the line = of code?

Yes.

It there a = length limit in emacs code ?

Jean-Christophe Helary
-----------------------------------------------
http://mac4translators.blogspot.com @brandelune

= --Apple-Mail=_F7250C6D-7B2A-40BD-BDE0-56E983B3EE1F--