From: Yuan Fu <casouri@gmail.com>
To: Noah Peart <noah.v.peart@gmail.com>
Cc: 70464@debbugs.gnu.org
Subject: bug#70464: [PATCH] Add font-locking for Rust macro variables
Date: Fri, 19 Apr 2024 00:41:01 -0700 [thread overview]
Message-ID: <DD9CAE2A-0B21-4832-BA3E-58CA34296E86@gmail.com> (raw)
In-Reply-To: <CAPVBTSeieWU87m8a=47skgV5x=GpYwUmDkf0MmkftX3u_NF92g@mail.gmail.com>
Noah Peart <noah.v.peart@gmail.com> writes:
> Tags: patch
>
> Adds some tree-sitter font-locking rules in rust-ts-mode to fontify
> meta variables, their types, and repetition operators in macros.
>
> These rules add new font-locking as indicated in the following
> snippet:
>
> macro_rules! unsafe_raw_call {
> ($env:expr, $name:ident $(, $args:expr)*) => {
> // ^ font-lock-variable-name-face
> // ^ font-lock-type-face
> // ^ font-lock-operator-face
> // ^ font-lock-operator-face
> {
> let env = $env;
> // ^ font-lock-variable-use-face
> let result = unsafe {
> let $name = raw_fn!(env, $name);
> $name(env.raw $(, $args)*)
> };
> env.handle_exit(result)
> }
> };
> }
>
> I also removed the last occurrence of the following duplicated rule from the `type` feature:
> (type_identifier) @font-lock-type-face
>
Great! Thanks! I’ll merge this in some time once I figure out whether
should we apply it to emacs-29 or master.
Meanwhile, it seems that you’ve recently working on tree-sitter modes.
If you’re interested, maybe you can take a look at ert-font-lock, and
add some tests that cover the bugs your patches fixes? This is
completely optional, of course. I bought it up because I think you might
be interested.
Yuan
next prev parent reply other threads:[~2024-04-19 7:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 1:42 bug#70464: [PATCH] Add font-locking for Rust macro variables Noah Peart
2024-04-19 7:41 ` Yuan Fu [this message]
2024-04-19 8:02 ` Vladimir Kazanov
2024-04-19 16:44 ` Noah Peart
2024-04-19 17:38 ` Noah Peart
2024-04-22 5:00 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD9CAE2A-0B21-4832-BA3E-58CA34296E86@gmail.com \
--to=casouri@gmail.com \
--cc=70464@debbugs.gnu.org \
--cc=noah.v.peart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.