From: "Jan D." <jan.h.d@swipnet.se>
To: martin rudalics <rudalics@gmx.at>
Cc: "18215@debbugs.gnu.org" <18215@debbugs.gnu.org>,
Keith David Bershatsky <esq@lawlist.com>
Subject: bug#18215: 24.4.50; OSX 10.6.8; set-frame-size by pixelwise does not work following `make-fame`.
Date: Wed, 13 Aug 2014 12:33:57 +0200 [thread overview]
Message-ID: <DD140404-86C0-4369-8292-3FCE45D8FCC9@swipnet.se> (raw)
In-Reply-To: <53EB0447.4060402@gmx.at>
Hi.
> 13 aug 2014 kl. 08:23 skrev martin rudalics <rudalics@gmx.at>:
>
> > Thank you for the new patch. I was able to successfully apply the new
> > patch for 'nsterm.m` to a version of Emacs Trunk downloaded tonight
> > (08/12/2014). I also tried patching the previous file for `nsfns.m`,
> > but received a message that the patch had already been applied.
>
> Jan applied it as revision 117687 with the slightly misleading commit
> message: "Fix default width not being 80, but 77."
That was what I fixed. I have not looked at your patches.
>
> > After patching `nsterm.m` and building Emacs Trunk downloaded tonight
> > (08/12/2014), I was not able to set the frame size to 1920 using any
> > of the settings previously mentioned relating to bug 18215. I was
> > able to achieve a little less than 1920 or several pixels more than
> > 1920, but not exactly 1920.
>
> Do you mean with `set-frame-size' and PIXELWISE non-nil? I have no idea
> how size hints work on OSX so that's easily possible. Around line 5843
> nsterm.m has these three lines
>
> sz.width = FRAME_COLUMN_WIDTH (emacsframe);
> sz.height = FRAME_LINE_HEIGHT (emacsframe);
> [win setResizeIncrements: sz];
>
> These seem to say that resize increments should happen in multiples of
> the frame's character sizes. Note that in Lisp you get the values of
> FRAME_LINE_HEIGHT and FRAME_COLUMN_WIDTH via `frame-char-height' and
> `frame-char-width' respectively.
>
> So if you did something like
>
> sz.width = 1;
> sz.height = 1;
> [win setResizeIncrements: sz];
>
> instead, this should tell your window manager to resize your frame in
> increments of 1 pixel instead. You should be able to try this out by
> mouse-dragging the edge of a frame after such change.
>
> But I'm not sure what happens when you omit the
>
> [win setResizeIncrements: sz];
>
> entirely as in the diffs I sent you. It might leave the hint values at
> some earlier default which inhibits pixelwise resizing.
>
> Note that nsterm.c also has two occurrences of setResizeIncrements in
> toggleFullScreen. I'm not sure whether these apply for getting the
> entire screen estate. You could try to replace around line 6462
>
> sz.width = FRAME_COLUMN_WIDTH (f);
> sz.height = FRAME_LINE_HEIGHT (f);
>
> with
>
> sz.width = 1;
> sz.height = 1;
>
> and look whether maximizing works as expected then.
If you remove or set to one, you loose the resize feedback in the title bar (w x h) during resize.
Jan D.
next prev parent reply other threads:[~2014-08-13 10:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 18:40 bug#18215: 24.4.50; OSX 10.6.8; set-frame-size by pixelwise does not work following `make-fame` Keith David Bershatsky
2014-08-08 8:45 ` martin rudalics
2014-08-09 19:29 ` Keith David Bershatsky
2014-08-10 9:19 ` martin rudalics
2014-08-09 19:36 ` bug#18215: Fwd: " Keith David Bershatsky
2014-08-09 19:37 ` Keith David Bershatsky
2014-08-09 20:00 ` Keith David Bershatsky
2014-08-10 16:51 ` Keith David Bershatsky
2014-08-11 7:40 ` martin rudalics
2014-08-12 2:47 ` Keith David Bershatsky
2014-08-12 13:03 ` martin rudalics
2014-08-13 4:43 ` Keith David Bershatsky
2014-08-13 6:23 ` martin rudalics
2014-08-13 10:33 ` Jan D. [this message]
2014-08-13 12:21 ` martin rudalics
2014-08-13 4:49 ` Keith David Bershatsky
2014-08-14 3:44 ` Keith David Bershatsky
2014-08-15 15:52 ` martin rudalics
2014-08-16 23:35 ` Keith David Bershatsky
2014-08-17 10:12 ` martin rudalics
2014-08-17 18:29 ` Keith David Bershatsky
2014-08-18 8:31 ` martin rudalics
2017-09-02 17:44 ` bug#18215: [PATCH] Set frame size to actual requested size (bug#18215) Alan Third
[not found] <m24mxnknho.wl%esq@lawlist.com>
2014-08-09 9:44 ` bug#18215: 24.4.50; OSX 10.6.8; set-frame-size by pixelwise does not work following `make-fame` martin rudalics
[not found] <m2ha1l4nxl.wl%esq@lawlist.com>
2014-08-09 17:14 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD140404-86C0-4369-8292-3FCE45D8FCC9@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=18215@debbugs.gnu.org \
--cc=esq@lawlist.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.