From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: Highlighting bug with org-agenda-set-restriction-lock
Date: Fri, 5 Apr 2013 16:12:19 +0200 [thread overview]
Message-ID: <DCDD7529-1A1E-4567-98F6-A16A5E115A07@gmail.com> (raw)
In-Reply-To: <87bo9tyvdj.fsf@norang.ca>
On 5 apr. 2013, at 15:12, Bernt Hansen <bernt@norang.ca> wrote:
> Hi,
>
> The highlighting has changed for this functionality. I finally updated
> to master (1200+ commits) yesterday and when I use C-c C-x < the entire
> subtree is now highlighted in bright yellow on my Windows Emacs.
>
> GNU Emacs 23.3.1 (i386-mingw-nt5.1.2600) of 2011-03-10 on 3249CTO
>
> Org-mode version 7.9.2 (release_7.9.2-2030-g29a75d @
> d:/bin/org-mode/lisp/)
>
> This used to highlight only the first heading of the subtree.
> Highlighting the entire subtree is _very_ distracting and makes working
> in the org file on the narrowed subtree difficult (for me).
>
> I can fix this by changing the face and completely removing the
> highlight but I'd prefer the old functionality if that is possible.
This is causes by this commit:
commit aa0e0068de109eef2ac7897c4659d545b351de01
Author: Bastien Guerry <bzg@altern.org>
Date: Sat Feb 16 23:09:57 2013 +0100
org-agenda.el (org-agenda-set-restriction-lock): Put the overlay until the e
* org-agenda.el (org-agenda-set-restriction-lock): Put the
overlay until the end of the subtree, not the end of the
headline.
When the agenda restriction is on, user expect agenda views to check
every entry in the subtree. If a user add an entry outside of the
overlay without noticing it, this entry will not be checked and the
user will wonder why. Put the end of the overlay at the end of the
subtree so that the user always knows if the entries she is adding
are within the current restriction.
We might need to find a less instrusive overlay color, though.
So Bastien felt that the entire subtree should have an overlay, but
maybe a softer color. I would also prefer the highlight just to be
on the headline as it used to be.
Bastien, how do you feel about reverting this change? I see why
you did it, but it is not so practical after all if you want to
work in this mode for extended time.
- Carsten
>
> I also noticed that the main heading is now also highlighted in the
> agenda which is okay I guess but also different from how this used to
> work :)
>
> I haven't tried this on my Linux system at home yet. Will do that this
> weekend.
>
> Thanks,
> Bernt
>
next prev parent reply other threads:[~2013-04-05 14:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 13:12 Highlighting bug with org-agenda-set-restriction-lock Bernt Hansen
2013-04-05 13:20 ` Bernt Hansen
2013-04-05 14:12 ` Carsten Dominik [this message]
2013-04-05 14:23 ` Carsten Dominik
2013-04-05 14:46 ` Carsten Dominik
2013-04-05 15:48 ` Bernt Hansen
2013-04-06 5:17 ` Carsten Dominik
2013-04-05 14:46 ` Bernt Hansen
2013-04-05 14:50 ` Carsten Dominik
2013-04-06 20:33 ` Bastien
2013-04-06 21:16 ` Bernt Hansen
2013-04-06 21:25 ` Bastien
2013-04-07 0:29 ` Bernt Hansen
2013-04-07 7:33 ` Bastien
2013-04-07 12:08 ` Bernt Hansen
2013-04-07 14:05 ` Christian Moe
2013-04-07 18:43 ` Bernt Hansen
2013-04-10 22:36 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCDD7529-1A1E-4567-98F6-A16A5E115A07@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.