From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#12705: 24.2.50; `Info-complete-menu-item' should use `add-to-list', not `push', to prevent duplicates Date: Mon, 22 Oct 2012 09:25:56 -0700 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1350923249 22143 80.91.229.3 (22 Oct 2012 16:27:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Oct 2012 16:27:29 +0000 (UTC) To: 12705@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 22 18:27:37 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TQKql-00026F-IG for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Oct 2012 18:27:35 +0200 Original-Received: from localhost ([::1]:36135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQKqd-0006tt-TJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Oct 2012 12:27:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQKqb-0006sz-Hy for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 12:27:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQKqR-0004JC-E9 for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 12:27:25 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQKqR-0004J4-Ac for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 12:27:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TQKsA-0006u9-9M for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 12:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Oct 2012 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12705 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.135092328326420 (code B ref -1); Mon, 22 Oct 2012 16:29:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Oct 2012 16:28:03 +0000 Original-Received: from localhost ([127.0.0.1]:56108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQKrC-0006s5-JV for submit@debbugs.gnu.org; Mon, 22 Oct 2012 12:28:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45631) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQKrA-0006rZ-NT for submit@debbugs.gnu.org; Mon, 22 Oct 2012 12:28:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQKpL-00044x-1L for submit@debbugs.gnu.org; Mon, 22 Oct 2012 12:26:08 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:43509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQKpK-00044t-UO for submit@debbugs.gnu.org; Mon, 22 Oct 2012 12:26:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQKpG-0005Wy-9B for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 12:26:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQKpE-000448-L2 for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 12:26:02 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:30255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQKpE-00043c-Dw for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 12:26:00 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q9MGPw3n016706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 22 Oct 2012 16:25:58 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q9MGPvGH016591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 22 Oct 2012 16:25:57 GMT Original-Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q9MGPvk1027983 for ; Mon, 22 Oct 2012 11:25:57 -0500 Original-Received: from dradamslap1 (/130.35.178.248) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 22 Oct 2012 09:25:56 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac2wcemfoJt4YDj1SbKNLRoZ5XHLDw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65850 Archived-At: Subject line says it all. This sexp: (push (match-string-no-properties 1) completions) should be changed to this: (add-to-list 'completions (match-string-no-properties 1)) Otherwise the same entry can be added to `completions' multiple times. This might not be manifested in *Completions*, because Emacs removes duplicate candidates. But in other completion setups (e.g. Icicles) duplicate candidates (e.g. same display string, but perhaps different alist elements) are sometimes allowed. Yes, such other completion setups can specifically remove dups here. But it would be more polite for `Info-complete-menu-item' to not create dups in the first place. There is never any reason for dups in this context. In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600) of 2012-10-15 on DANI-PC Bzr revision: 110553 monnier@iro.umontreal.ca-20121015164957-6zms5w2js1xkldtg Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -I../../libs/libxpm-3.5.8/include -I../../libs/libxpm-3.5.8/src -I../../libs/libpng-1.4.10 -I../../libs/zlib-1.2.6 -I../../libs/giflib-4.1.4-1/include -I../../libs/jpeg-6b-4/include -I../../libs/tiff-3.8.2-1/include -I../../libs/libxml2-2.7.8-w32-bin/include/libxml2 -I../../libs/gnutls-3.0.16/include -I../../libs/libiconv-1.14-2-mingw32-dev/include'