From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59977: 29.0.60; python-ts-mode does not fontify function-invocations using font-lock-function-name [PATCH] Date: Mon, 12 Dec 2022 14:54:32 -0800 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14243"; mail-complaints-to="usenet@ciao.gmane.io" Cc: fgallina@gnu.org, 59977@debbugs.gnu.org, jostein@kjonigsen.net To: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 23:55:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4rhV-0003Uv-8r for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 23:55:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4rhP-0003UU-KJ; Mon, 12 Dec 2022 17:55:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rhO-0003Tr-4P for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4rhN-0005MJ-Qo for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:55:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4rhN-0005Rg-K7 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:55:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 22:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59977-submit@debbugs.gnu.org id=B59977.167088568220918 (code B ref 59977); Mon, 12 Dec 2022 22:55:01 +0000 Original-Received: (at 59977) by debbugs.gnu.org; 12 Dec 2022 22:54:42 +0000 Original-Received: from localhost ([127.0.0.1]:55990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rh3-0005RJ-QL for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:54:42 -0500 Original-Received: from mail-pl1-f182.google.com ([209.85.214.182]:42504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rh2-0005R8-NI for 59977@debbugs.gnu.org; Mon, 12 Dec 2022 17:54:41 -0500 Original-Received: by mail-pl1-f182.google.com with SMTP id d7so13644859pll.9 for <59977@debbugs.gnu.org>; Mon, 12 Dec 2022 14:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=uKNpVq873066Q43ExHZyApx4EJT3h3wfyzSlZbtdhqY=; b=Jn4nxOegLhm4DgRAov9ZlAAHBSbbwBFJOV8ClFXR5SJ7NCvTxdh4jEdPZt+tp+V2J3 EkWlpAdtIFh34joE4krZNnylGlt15yK3R992fJ9pI/9SEPqHfbBy1i9BjXeI/QvAscTm holKuwDMjy21r9BFr6dWVS5UQiGqIEOih4n+m3+C4TSy9a4zCunnIxz5tbtUYljvp2EN 7XSiuERBXg4pBWa2ZEtxI04RtgXI5Bks+OZkkA9gAoaUNvMwvtZz9QewHCjdt33Uio7E xd2eTkHgBygYB72owTKoh1fTVdDRDNeDXvde4omF5i+FXVgXvGkJC4VvRKHNhmtiaFYH gQ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uKNpVq873066Q43ExHZyApx4EJT3h3wfyzSlZbtdhqY=; b=6KzPkPH5G9vopTQVKxKnUWIWSTjmkf6ZIgn6OcmYYL44ygXGlCa7GdD/m0YGfKLkSF /SQxvGhwbaeIo5YnTswcRKMsAyZjq4SRFY6xm5KGEe4tMyhrpopaSkpA2YUDgEq63WcH AZQw+JDVoTH8N5TFN+KwjwsmnrOmeZkIVEVhVqsHIgZTKLL+lN5TyzPvhembcltxJSis yLZsVEDd5/8WGjbUSQPiP5BVUsUfcrMYkQz6pbL5dSfKwDo8pxX9OcKX2qeajEE8m8rV anBpOihhNBaqzwOipCIGqRy846EA2IJcqIQxQNT6l705qVnp0Z9TDGfg9yvxZBSIC8JZ K4Ug== X-Gm-Message-State: ANoB5pmR/daVJIyro2Gxtq8ctVF/IH1QAfRYnejoNFPrqvObSosd7ycu 0iCFh1SIpSUwSY34VbkS4zk= X-Google-Smtp-Source: AA0mqf60h9wnN0P7WEZW3CbcWl3C+O+tG9sDOnnbRVJ6EASnWqqNnF+jt8rN4W81eXuGSqaQs4kZuA== X-Received: by 2002:a17:902:7441:b0:189:80d1:9d19 with SMTP id e1-20020a170902744100b0018980d19d19mr21568644plt.26.1670885674762; Mon, 12 Dec 2022 14:54:34 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id j16-20020a170902da9000b00189c62eac37sm6935453plx.32.2022.12.12.14.54.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Dec 2022 14:54:34 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250771 Archived-At: Jostein Kj=C3=B8nigsen writes: > Open a python buffer, activate python-ts-mode and write a simple = statement invoking a function. Example code: > > def somefunc(val) > return val > > result =3D someFunc("123"); > > Observe how function-name is fontified as function name in the = function definition, but not when invoked. > > This is inconsistent with how other major-modes fontify function > names. Ah, yes. That=E2=80=99s because the "definition" feature, which is by = enabled by default, only highlights definition and ignores invocation. OTOH, the "function" feature highlights every instance of a function identifier, but it isn=E2=80=99t enabled by default. Other tree-sitter major modes = doesn=E2=80=99t have "definition" and enable "function" by default, I think. I=E2=80=99m planning to standardize the features in each major mode = according to the list I showed you earlier. It=E2=80=99d be great if you can have a = look at that list and see if you have any opinions, before we decide on the final form of it and start to standardize those features in major modes. (Of course, each language is different, the standard feature list is just a base upon which major modes will extend/modify.) Yuan