From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: Path & Demo: Source View in Help Buffers Date: Wed, 22 Sep 2021 14:01:43 +0200 Message-ID: References: <87o88kj2oz.fsf@gnu.org> <87k0j8j0v3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39850"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 22 14:04:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mT0z4-000A6d-GZ for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 14:04:19 +0200 Original-Received: from localhost ([::1]:52832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT0z3-0001H3-5I for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Sep 2021 08:04:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT0wl-0008JH-Mi for emacs-devel@gnu.org; Wed, 22 Sep 2021 08:01:58 -0400 Original-Received: from mail-oln040092075072.outbound.protection.outlook.com ([40.92.75.72]:9709 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT0wj-0007qd-83; Wed, 22 Sep 2021 08:01:55 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T85/ygfX2luO9gwKVUBw3M928/X/ADnUnl5KBVwCpBRh1LJpblamfPO9qnoUpaXndfXc1inDUzn2upErLS649wQbS4vnjD/534LxA9mHJIeZKRBXoxA/jWrJfoxVkADHQhxKlGWAP0jlJyh5Q3AXEwb1c7/azIQkIBW3e6rUhaPFCfs3vXE6XDLza3THXsjT/MxT8YxW6tFBtsw5ZKsbyII+52k7p+zP98MzbexrO47wdXsyeq4Ny+73SoCmrost5k5cpkb3AYcLrcII7Yg7f0RKiE+0KijXqp6R+aGNwt68T78DxkGgbgzcNo3FF2LQjx9olgFkGkHm5hzuZyWOQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DXPXmFnRBdDa191RmVmmQL5t42C4mCUzXwjM1NK4ato=; b=KVJ+9tB2NLaABqfXIcu1d/t9ARUkdIFMc6n1YQxn4bLsdCkjZmPn6nQ8FBezcvo49IN80pmcKf6JXBhJEUzD9XV5WfiakXqmNGZuRYsiYPJuAwCjRa4+w6BpIdCJv4qmb4QiuXGHtMR+F/TpJLG+YrsWdtaIE6onxekBkq4vmUC7r3EyB0PhIjULJCeS/Vd9UhmYjUOp853HROVPiD9YgWiSd06Y+x2hBsLcV3vy6m1+O9G4Ti+OYYcKwmnd+W7qWLWaz657rcKeXQEMJcTHIb3U1Or7TTB9T7bF+Q2M6Vp3oJrcY4205k1jPnjtO0MKWFHxdPfkhBqi6saPdR/KzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DXPXmFnRBdDa191RmVmmQL5t42C4mCUzXwjM1NK4ato=; b=WNlzQwVTXyXixLfzP2vEt2sr3evRKIppStaUpJqUi3t057d24a6jLUcqPiplWYkt2C1mmceaCY/O2D2cKrC0KxsNnCx1poyk3fnsF5lTPNvaou7vkmdpjNJa/pKVNj454GOeiMcQIJ7H3ius9N05lyoLCsxHK0/2bFa/+6YWJGfQpvlmO86LRkQGoTlmKsW0i0eJWiwEuXqOLgnMRBldSdURnnFVlwf9kSCDyzCNPBcDaKUpbChztV3RxCbva9jLxZKMIr4ECEMrSJlej6UTLD2hO56wLNKYyibHKZJFsMbr+M34KwMnHdC91y0MvZ2gz4mlqwoZ1Nm+xpF8c1Oo/g== Original-Received: from DB9PR09MB4986.eurprd09.prod.outlook.com (2603:10a6:10:2a9::19) by DBBPR09MB3126.eurprd09.prod.outlook.com (2603:10a6:10:db::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Wed, 22 Sep 2021 12:01:45 +0000 Original-Received: from DB9PR09MB4986.eurprd09.prod.outlook.com ([fe80::80be:d528:d357:5d3a]) by DB9PR09MB4986.eurprd09.prod.outlook.com ([fe80::80be:d528:d357:5d3a%9]) with mapi id 15.20.4523.018; Wed, 22 Sep 2021 12:01:45 +0000 In-Reply-To: <87k0j8j0v3.fsf@gnu.org> (Tassilo Horn's message of "Wed, 22 Sep 2021 13:32:57 +0200") X-TMN: [PQHijW25qD3gyEEchAy4DGHxM7l8HFrn] X-ClientProxiedBy: HE1PR02CA0117.eurprd02.prod.outlook.com (2603:10a6:7:29::46) To DB9PR09MB4986.eurprd09.prod.outlook.com (2603:10a6:10:2a9::19) X-Microsoft-Original-Message-ID: <87a6k4x1i0.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (81.232.177.30) by HE1PR02CA0117.eurprd02.prod.outlook.com (2603:10a6:7:29::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Wed, 22 Sep 2021 12:01:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 220cabfa-a75a-4020-c54e-08d97dc0bf8d X-MS-TrafficTypeDiagnostic: DBBPR09MB3126: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lbrze6hJ18Ggu6unYIcJWSwmh0x2gcOX77vWA7e1DCEyhcsQo3lvu6LxSQA5dNMT7Ss+cwqOPSfJYM7X5got1fgqvRqPy9IMkDrcz9MZ8c1RWeCIvrmb+Iw61kT1hlT9I3LshiDZ8RVlaLpqGBT6yIlxws4YN05+NhIZQzKTNaDPK/re80bvNY+KrcKVEvUe2suAMiHa4Xrelv9B0qeoTmaULJ3z9FICNYJ0NqDPgW4lTTCF1ifKtoegr+FWLU2CuNnNd+K8VpIWzw9B4n/kMpvonxqP17sXC4VBFLReyxEHbECT7cXT2Dqm3thOhqjivfw+i3gRvivhhdRJPxR66RG5OdQYI+VjhqTB8OujrtBW/RokX71Pi0rKXxO4BUeV7+PwyM4nNC4tXMErPVvKQHa4UkPtVZFhnY4usI4TxOeYxUkA2CQg0T5i40TQitP3 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xQEr4k8e3ZCkLvz+4wMpTEywuqGCadBfQOpcm0svayV1g2V4zSVARqZJ1xQcYahpsJyDoLAZvy+R/vcfBdYq8N/OnbRbODuKbfo0hg4QnadwkG3f+VmjBXMy71p3h7AzQQ10yCdD5J+xZffXPP/42w== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-72e6e.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 220cabfa-a75a-4020-c54e-08d97dc0bf8d X-MS-Exchange-CrossTenant-AuthSource: DB9PR09MB4986.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2021 12:01:45.6253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR09MB3126 Received-SPF: pass client-ip=40.92.75.72; envelope-from=arthur.miller@live.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275314 Archived-At: Tassilo Horn writes: > Arthur Miller writes: > >>> Out of curiosity, why do you have fboundp-checks for font-lock-ensure >>> in the code? That's always true, isn't it? >> >> I don't know. Since font-lock has all its stuff abstracted into buffer >> local function variables, I am not sure if I can count it is not nil? > > But it's no buffer-local variable, it's a function. If you have emacs > 25.1 upwards, you have `font-lock-ensure'. > >> If I can I would gladly remove the check. I appreciate advice, I am >> not so familiar with all the details of everything. > > I think that's a common check for 3rd-party packages which want to keep > supporting emacs 24. But since you are hacking emacs core, there's no > need for that unless the function/variable is only defined if some > configure option is given or some lib is available. But none of the > latter applies to font-lock.el. Allright, thank you. I didn't know so much about font lock :).