From: "Gustav Wikström" <gustav@whil.se>
To: Kyle Meyer <kyle@kyleam.com>,
"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: RE: Minor fix for org-attach-dir
Date: Tue, 3 Sep 2019 20:20:42 +0000 [thread overview]
Message-ID: <DB6PR02MB3029DD29D7F7EE7472DE319EDAB90@DB6PR02MB3029.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <87h85u2wfu.fsf@kyleam.com>
Ah, I'll read up a bit more on that to make the commits conform better,
Thanks
G
> -----Original Message-----
> From: Kyle Meyer <kyle@kyleam.com>
> Sent: den 2 september 2019 23:57
> To: Gustav Wikström <gustav@whil.se>; emacs-orgmode@gnu.org
> Subject: Re: [O] Minor fix for org-attach-dir
>
> Hi Gustav,
>
> Gustav Wikström <gustav@whil.se> writes:
>
> > See commit 4b7eda1a2 for the fix.
>
> This commit, as well as several other recent commits by you, do not
> follow the project's convention regarding changelog-like entries in the
> commit message. Regardless of your opinion on this convention (I
> personally don't prefer it either), please try to follow it.
>
> --
> Kyle
prev parent reply other threads:[~2019-09-03 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 21:26 Minor fix for org-attach-dir Gustav Wikström
2019-09-02 21:57 ` Kyle Meyer
2019-09-03 20:20 ` Gustav Wikström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR02MB3029DD29D7F7EE7472DE319EDAB90@DB6PR02MB3029.eurprd02.prod.outlook.com \
--to=gustav@whil.se \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.