From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#73191: Acknowledgement (30.0.91; missing some keywords in c++-ts-mode) Date: Sat, 14 Sep 2024 11:11:19 -0700 Message-ID: References: <87o74tmldd.fsf@qq.com> <86cyl6h7of.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28515"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yang Yingchao , 73191-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 14 20:13:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1spXGc-0007IQ-E8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Sep 2024 20:13:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spXGP-0005nT-SZ; Sat, 14 Sep 2024 14:12:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spXGN-0005mo-UF for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 14:12:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1spXGN-000466-Ky for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 14:12:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=cLgSFyJX8D+UjAgOaX0XLsi8ff2d8f6ba8Aqg7iiVH4=; b=Hcr/QA/88YPbehgR08eVVkx+nIMtAW+r4wAYskOOre5rqc88codTMfws2tPZQ6WYmUCMIgUoLPHZD0jvsw3+YSbF13LQHmFH7W3D0SVapMzSwHjQY96AkVLAkRevyFROUD1Iut3q5JkpWs1IcuKb5uTVHeNIh24yhazH+xDIWdoMslMrN4Pg2+hYVP9EaOA5GzUrwyUxYwYEaMhgjSMvYVBeAQEYP0utWHlG5R3OQvUxCyPaZ15Z6gp4tREAsKs2U7z780mzYelWzrvwJSM7Qm+FnKW6pOrRsr4VY5mdkZeUTQH2c2e8lMZ8FLVnwOyFA9GBlE6ts4MLH/XthRhMuw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1spXGY-0006ah-1G for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 14:13:02 -0400 Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2024 18:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73191 X-GNU-PR-Package: emacs Mail-Followup-To: 73191@debbugs.gnu.org, casouri@gmail.com, yang.yingchao@qq.com Original-Received: via spool by 73191-done@debbugs.gnu.org id=D73191.172633757425311 (code D ref 73191); Sat, 14 Sep 2024 18:13:01 +0000 Original-Received: (at 73191-done) by debbugs.gnu.org; 14 Sep 2024 18:12:54 +0000 Original-Received: from localhost ([127.0.0.1]:47778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spXGP-0006aB-L5 for submit@debbugs.gnu.org; Sat, 14 Sep 2024 14:12:53 -0400 Original-Received: from mail-pl1-f180.google.com ([209.85.214.180]:51397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spXGL-0006Zt-5d for 73191-done@debbugs.gnu.org; Sat, 14 Sep 2024 14:12:51 -0400 Original-Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20536dcc6e9so14452635ad.2 for <73191-done@debbugs.gnu.org>; Sat, 14 Sep 2024 11:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726337491; x=1726942291; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cLgSFyJX8D+UjAgOaX0XLsi8ff2d8f6ba8Aqg7iiVH4=; b=nUnQTO1yCLDt41JLS088k6VOI1G1lkJ3SHR8Yx9PhOcsZCkG1SHLO3r4QVVsdb+nZK tfO0DoABUz72Jg2rORDynItu5FEluDzQEPKftQgdhGuG9yY8EVIaj3acjWQBcY+zpkQS aJr3G3xxmUMJCfW427v9//QcyDiK4kyav8EIjq65ZAP900sBYpetTs5UYAFBe3npL9IP FV+Fi11zzvMdkVm2s+SgK0JC5e3caHkoGvom7Ul0/Ck/pHxamnfFu3D1UVIOTBVdbj0v Ag6McQzqAnSfZuJwjjohZQkPuOJnJAfLFvaaa/RpVpcl5e1DjlyGZgJ50JB99u5jg288 59pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726337491; x=1726942291; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cLgSFyJX8D+UjAgOaX0XLsi8ff2d8f6ba8Aqg7iiVH4=; b=uM5386bc1AatvWJzimklnX0k7XmTuKxkJoR8PhqhcFB9cFdZxg1Ks7983EzITGjaNq 2bGwHrgkhK5gRc4YNesEey4mHbQd2cPmn4EQnWxBboPcv7Anxfsi3WZg7IZCtvqUZN3L 0B42CUJbXEf+9ggycXfasPp9wLsfvxyCu0YAlFPPIQuUX5O9KUUadKgFKp2kYCc2Zz+o 6zfatJTQqOzQOEuu+I0P6oRvumPXOupdFNbMGEOS71RLwt7hiDH5raG0+6VlJiSFE4PK Ynll2ijKAkjIndmQcEny6OGjmCYJb2TYYiFpyU674OYmSx7YsIQVpHkZlNRyVISV/QWy 2O7A== X-Forwarded-Encrypted: i=1; AJvYcCVpur9YDX8aLnoiX2GBRiZORALwJn6/JzBdDqcFR/ujSnixMoqvLfH4e29Pl18EAyLASEgkmlKk8Upl@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz8clqlIqMUaOkWXVsZebm3L3BH5MSMMVqShsXfP1sOsbajfMIx 4TsOrGmOc4OoOVY/2l/BOqXONo8Uh1dolOgtZgUTdnDTYKztdIL1 X-Google-Smtp-Source: AGHT+IErH7zeSiMDNdeB1o/t2KgCndb0OQ1oH0AH5CCV5R3teF1tXkvUynnyf/XyHNrpgi+vmqerlA== X-Received: by 2002:a17:903:1c5:b0:206:9ab3:2ec1 with SMTP id d9443c01a7336-2078295da1fmr80483645ad.22.1726337490978; Sat, 14 Sep 2024 11:11:30 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:c75:3002:9563:938e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-207946fab2bsm11896765ad.194.2024.09.14.11.11.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Sep 2024 11:11:30 -0700 (PDT) In-Reply-To: <86cyl6h7of.fsf@gnu.org> X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291797 Archived-At: > On Sep 14, 2024, at 3:05=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> Date: Thu, 12 Sep 2024 14:40:26 +0800 >> From: Yang Yingchao via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> On Thu, Sep 12 2024, GNU bug Tracking System wrote: >>=20 >> Update: `virtual` works fine, only `thread_local` is not = highlighted... >=20 > Yuan, >=20 > Could you please look at this? >=20 > It sounds like we lack "thread_local" (and also "virtual"?) in > c-ts-mode--keywords. But when I tried to add them I found a more > serious problem: with the current C++ grammar library I see the > following messages in *Messages*: >=20 > Error during redisplay: (jit-lock-function 1) signaled = (treesit-query-error "Node type error at" 677 "[\"_Atomic\" \"break\" = \"case\" \"const\" \"continue\" \"default\" \"do\" \"else\" \"enum\" = \"extern\" \"for\" \"goto\" \"if\" \"inline\" \"register\" \"restrict\" = \"return\" \"sizeof\" \"static\" \"struct\" \"switch\" \"typedef\" = \"union\" \"volatile\" \"while\" \"and\" \"and_eq\" \"bitand\" \"bitor\" = \"catch\" \"class\" \"co_await\" \"co_return\" \"co_yield\" \"compl\" = \"concept\" \"consteval\" \"constexpr\" \"constinit\" \"decltype\" = \"delete\" \"explicit\" \"final\" \"friend\" \"mutable\" \"namespace\" = \"new\" \"noexcept\" \"not\" \"not_eq\" \"operator\" \"or\" \"or_eq\" = \"override\" \"private\" \"protected\" \"public\" \"requires\" = \"template\" \"throw\" \"try\" \"typename\" \"using\" \"xor\" = \"xor_eq\"] @font-lock-keyword-face (auto) @font-lock-keyword-face = (this) @font-lock-keyword-face (virtual) @font-lock-keyword-face" "Debug = the query with `treesit-query-validate'") >=20 > Could you please look at this and fix it ASAP, since this is affecting > the release branch? >=20 > TIA Yeah, sorry that I missed this report. And lol, tree-sitter-cpp changed = =E2=80=9Cvirtual=E2=80=9D to (virtual) in May and then changed it back a = few days ago. I added =E2=80=9Cthread_local" keyword and added logic to use (virtual) = or =E2=80=9Cvirtual=E2=80=9D depending on the grammar. Yuan=