From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Yang Yingchao <yang.yingchao@qq.com>, 73191-done@debbugs.gnu.org
Subject: bug#73191: Acknowledgement (30.0.91; missing some keywords in c++-ts-mode)
Date: Sat, 14 Sep 2024 11:11:19 -0700 [thread overview]
Message-ID: <D9CB9763-252E-4FCA-9D50-4A505DB09274@gmail.com> (raw)
In-Reply-To: <86cyl6h7of.fsf@gnu.org>
> On Sep 14, 2024, at 3:05 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> Date: Thu, 12 Sep 2024 14:40:26 +0800
>> From: Yang Yingchao via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> On Thu, Sep 12 2024, GNU bug Tracking System wrote:
>>
>> Update: `virtual` works fine, only `thread_local` is not highlighted...
>
> Yuan,
>
> Could you please look at this?
>
> It sounds like we lack "thread_local" (and also "virtual"?) in
> c-ts-mode--keywords. But when I tried to add them I found a more
> serious problem: with the current C++ grammar library I see the
> following messages in *Messages*:
>
> Error during redisplay: (jit-lock-function 1) signaled (treesit-query-error "Node type error at" 677 "[\"_Atomic\" \"break\" \"case\" \"const\" \"continue\" \"default\" \"do\" \"else\" \"enum\" \"extern\" \"for\" \"goto\" \"if\" \"inline\" \"register\" \"restrict\" \"return\" \"sizeof\" \"static\" \"struct\" \"switch\" \"typedef\" \"union\" \"volatile\" \"while\" \"and\" \"and_eq\" \"bitand\" \"bitor\" \"catch\" \"class\" \"co_await\" \"co_return\" \"co_yield\" \"compl\" \"concept\" \"consteval\" \"constexpr\" \"constinit\" \"decltype\" \"delete\" \"explicit\" \"final\" \"friend\" \"mutable\" \"namespace\" \"new\" \"noexcept\" \"not\" \"not_eq\" \"operator\" \"or\" \"or_eq\" \"override\" \"private\" \"protected\" \"public\" \"requires\" \"template\" \"throw\" \"try\" \"typename\" \"using\" \"xor\" \"xor_eq\"] @font-lock-keyword-face (auto) @font-lock-keyword-face (this) @font-lock-keyword-face (virtual) @font-lock-keyword-face" "Debug the query with `treesit-query-validate'")
>
> Could you please look at this and fix it ASAP, since this is affecting
> the release branch?
>
> TIA
Yeah, sorry that I missed this report. And lol, tree-sitter-cpp changed “virtual” to (virtual) in May and then changed it back a few days ago.
I added “thread_local" keyword and added logic to use (virtual) or “virtual” depending on the grammar.
Yuan
next prev parent reply other threads:[~2024-09-14 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87o74tmldd.fsf@qq.com>
[not found] ` <handler.73191.B.172612294420292.ack@debbugs.gnu.org>
2024-09-12 6:40 ` bug#73191: Acknowledgement (30.0.91; missing some keywords in c++-ts-mode) Yang Yingchao via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14 10:05 ` Eli Zaretskii
2024-09-14 18:11 ` Yuan Fu [this message]
2024-09-14 19:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D9CB9763-252E-4FCA-9D50-4A505DB09274@gmail.com \
--to=casouri@gmail.com \
--cc=73191-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=yang.yingchao@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.