From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: Odd unused yank-handler arguments Date: Sun, 2 May 2010 06:54:29 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1272808493 23568 80.91.229.12 (2 May 2010 13:54:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 2 May 2010 13:54:53 +0000 (UTC) To: "'Stefan Monnier'" , Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 02 15:54:51 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O8ZdC-0005KA-Tz for ged-emacs-devel@m.gmane.org; Sun, 02 May 2010 15:54:51 +0200 Original-Received: from localhost ([127.0.0.1]:39410 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O8ZdC-000268-84 for ged-emacs-devel@m.gmane.org; Sun, 02 May 2010 09:54:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O8Zd6-00025t-ID for emacs-devel@gnu.org; Sun, 02 May 2010 09:54:44 -0400 Original-Received: from [140.186.70.92] (port=52385 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O8Zd5-00025g-An for emacs-devel@gnu.org; Sun, 02 May 2010 09:54:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O8Zd3-00054P-Sl for emacs-devel@gnu.org; Sun, 02 May 2010 09:54:43 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]:29445) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O8Zd3-00054B-JR for emacs-devel@gnu.org; Sun, 02 May 2010 09:54:41 -0400 Original-Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o42Dsc2K011662 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 2 May 2010 13:54:40 GMT Original-Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o42DgTiw010207; Sun, 2 May 2010 13:54:38 GMT Original-Received: from abhmt004.oracle.com by acsmt353.oracle.com with ESMTP id 228621641272808461; Sun, 02 May 2010 06:54:21 -0700 Original-Received: from dradamslap1 (/141.144.160.100) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 02 May 2010 06:54:21 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 Thread-Index: Acrpvu1ul0MbNrs1SOasfELxQfOG+wAPuaOA X-Auth-Type: Internal IP X-Source-IP: rcsinet13.oracle.com [148.87.113.125] X-CT-RefId: str=0001.0A090206.4BDD8420.0053:SCFMA4539811,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:124421 Archived-At: > Any objection to the patch below? > > -(defun kill-new (string &optional replace yank-handler) > +(defun kill-new (string &optional replace) > > -(defun kill-append (string before-p &optional yank-handler) > +(defun kill-append (string before-p) > > -(defun kill-region (beg end &optional yank-handler) > +(defun kill-region (beg end) 1. I don't use the `yank-handler' arg myself, so I don't have any objection a priori. 2. However, why not give the reason for the change? To understand this, I'm looking through the code (since Emacs 22, when this arg was introduced) to try to understand. It seems to all turn around `insert-for-yank-1', which still seems to respect a `yank-handler' property. At least in the 1-96 pretest and in your patch, I see no change to the `insert-for-yank-1' behavior, so this is apparently only to remove the arg for those three `kill-*' functions. Can you give an idea what is behind the proposed change? Perhaps the reason is that those functions should never have had such an arg. Or perhaps it is that they no longer need it. Or that no existing code using them uses the arg. Or... IOW, why not be clear, saying (a) whether there is also some associated general change to the yank-handler handling and (b) what the particular motivation for this change is? Removing an arg is like adding an arg. What's the reason?