From: "Drew Adams" <drew.adams@oracle.com>
To: 9353@debbugs.gnu.org
Subject: bug#9353: 24.0.50; default grep file name face is uglier now
Date: Tue, 23 Aug 2011 13:18:54 -0700 [thread overview]
Message-ID: <D6261054A49249E39889E3401FF3503D@us.oracle.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
See attached images. The old face inherited from `font-lock-type-face',
and the appearace was OK (though not wonderful).
The new face inherits from a face called `success'. It is uhhhhgggly.
For one thing, it should not be bold. We should almost never use a bold
face as the default face for something, because boldness does not work
well on some platforms and for some (many) faces.
I applaud not inheriting from a font-lock face: there is no logical
connection to a grepped file. But there is also no logical connection
to "success" here.
Anyway, whatever you inherit from (but why must you always inherit?),
the default appearance should not be ugly and difficult to read. That
just forces more users to customize it or live with the difficulty.
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2011-08-22 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt'
[-- Attachment #2: throw-grep-file-old.png --]
[-- Type: image/png, Size: 7298 bytes --]
[-- Attachment #3: throw-grep-file-new.png --]
[-- Type: image/png, Size: 10047 bytes --]
next reply other threads:[~2011-08-23 20:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 20:18 Drew Adams [this message]
2011-08-23 21:32 ` bug#9353: 24.0.50; default grep file name face is uglier now Juri Linkov
2011-08-24 0:19 ` Drew Adams
2011-08-24 9:01 ` Juri Linkov
2011-08-24 14:55 ` Stefan Monnier
2011-08-24 18:02 ` Juri Linkov
2011-08-24 0:24 ` Stefan Monnier
2011-08-24 9:04 ` Juri Linkov
2011-08-24 13:38 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6261054A49249E39889E3401FF3503D@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=9353@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.