From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#71012: 30.0.50; tree-sitter crash Date: Sat, 3 Aug 2024 20:01:24 -0700 Message-ID: References: <87ttiwpng0.fsf@gmail.com> <86wmnsfodz.fsf@gnu.org> <6F195712-81CE-4C75-8983-D1D909646CAC@gmail.com> <86zfs8ssyj.fsf@gnu.org> <6FC1345F-B7CE-4A95-84BA-E559D5A963E1@gmail.com> <792DB4FC-EB1E-4094-A4CF-14500DDA82C1@gmail.com> <87h6e52lkw.fsf@epfl.ch> <87r0d12hlw.fsf@epfl.ch> <87y15qrg5q.fsf@epfl.ch> <86cyn27nuo.fsf@gnu.org> <87frrywemm.fsf@epfl.ch> <86sevy59dj.fsf@gnu.org> <868qxp69g9.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16827"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71012@debbugs.gnu.org, eller.helmut@gmail.com, "Basil L. Contovounesios" To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 04 05:04:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saRXV-0004A0-MY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Aug 2024 05:04:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saRX9-0002Zb-5w; Sat, 03 Aug 2024 23:03:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saRX4-0002Z7-P1 for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 23:03:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saRX4-0005cL-F8 for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 23:03:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=A0HI1trgPNEhd7/vSMRinDqzBWdX0ElCi9b71uGlaC8=; b=D10H1Q1bv7DynjoHjnMtdVJKxADVgOFe7tJO8M3QxkfSZYO5XL3/7K3d7FDl/D8JEScRzhLc6+gHFzqiNsMw9lLzDV/aG2E/5t3/e1zzk8ExXnF8URFL9PJfe8f7CuPedwT3X9oJNi8LojqbPKSLExek8wSrCYW4DLG/mFfZhAmGsJReJx6Zc/2V2tSXe+xavrlbbce0Df/EhZW+o5wje0wZg405kE2CW43Ym7rwwv0BhatBltUmmtmVHeBhY7+r4EvORo4qJHYVOkPPvzwjG37OhYd33M7H71UaqS6ZC5XaOBqzqksV+EzwGql1T7erL06OvTq1Nv19jhHPAyTvcQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1saRXO-00076v-JO for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 23:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2024 03:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71012 X-GNU-PR-Package: emacs Original-Received: via spool by 71012-submit@debbugs.gnu.org id=B71012.172274058727181 (code B ref 71012); Sun, 04 Aug 2024 03:04:02 +0000 Original-Received: (at 71012) by debbugs.gnu.org; 4 Aug 2024 03:03:07 +0000 Original-Received: from localhost ([127.0.0.1]:54959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saRWV-00074L-BB for submit@debbugs.gnu.org; Sat, 03 Aug 2024 23:03:07 -0400 Original-Received: from mail-oo1-f45.google.com ([209.85.161.45]:52392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saRWR-00073X-63 for 71012@debbugs.gnu.org; Sat, 03 Aug 2024 23:03:05 -0400 Original-Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-5d5ed6f51cfso4338017eaf.0 for <71012@debbugs.gnu.org>; Sat, 03 Aug 2024 20:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722740497; x=1723345297; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=A0HI1trgPNEhd7/vSMRinDqzBWdX0ElCi9b71uGlaC8=; b=bhn7dm8PW6r6ySOQgEKFDp7xQ3xNimqgNsFeZHFRsTPlgGvd4zhHaEGf5RHfp/LOR2 KYyoOHS2BL0v5FAtSaptOZ9HHWL0GyRdEucHruRGH5EqBS6K7rRxY5YxMwhyIQSVlUU9 EzUXaPreqKLuyX+UyAz9LtTkGdn9rqCgMs7TkQMgsYKOSiF0G2SaDy3shjX/5NZkZuve cvG2GjeCu4U3148GID4ov0HbYByhwLlJTR2S3dnLRwwauRzSqYPBB7P/wgVGiBJeLl3l 5w4SPYNpKJ2+ybzBcYTQfpvSHeEmjxQscw2M8QoZ58m3lE2pfP4spx6Ba0lQNaFRUVKQ zdNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722740497; x=1723345297; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A0HI1trgPNEhd7/vSMRinDqzBWdX0ElCi9b71uGlaC8=; b=BUDMT7QDB6hYlkuZhA5jKqcoHo7kn0AuvToi5Bjw4h1oys7rPCfgYOzruSNfSpCra1 9B7C3VA203lZZeUqoPWYWurmdE5YBliCHM++rW4iwBPQRBr4qslsDUXLd5v8GLx4zFxw g7ojsn9PHpQORyDblUYN6REG776he00ISvs3GDWC9n1+QELHrNbAyWKqNMPoveik2Vkf YSGNzKRX5Bps/3JceaAG/We6zODY3LpZUzQDpg9XE3uGlB0g8wikykIbAAlDkq/27q9E M3uG1gf+uzTmcdUDUUP/8fqIAF+79d9sMgLUhdkOzMkxsHdP4eQ72G3u0xaQtwD9Ohrh sVow== X-Forwarded-Encrypted: i=1; AJvYcCWMktmTDEfS9cJ4LzKRNSLDn/rF5/QsrZVYK2j/4C6DH9BLkiJ9DRhDf56VqWXxIveQ6fkGBah+LxEwezVpBya10ErsZpc= X-Gm-Message-State: AOJu0YwW47FtX2sivggTE1wLRcA7qoRCg5HbnXvHZOtJJNKBj5ikse0A rcQ+P9NnZSfi5bCHBMv1SxguX6uYw+SRqAZJTB/oXwfWte4dp8Ka X-Google-Smtp-Source: AGHT+IGFfOuAClXVJM7/pkN0Y1xpEHuiMWjrF/WoMhxP2oOTJO1XMv8jwbizHikg5+/n2N0uMV0ZPA== X-Received: by 2002:a05:6358:724a:b0:1ac:f109:e248 with SMTP id e5c5f4694b2df-1af3ba8740amr870916355d.2.1722740496729; Sat, 03 Aug 2024 20:01:36 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:90c7:b430:aa7b:7b1f]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7b764fb50ccsm3406048a12.71.2024.08.03.20.01.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Aug 2024 20:01:35 -0700 (PDT) In-Reply-To: <868qxp69g9.fsf@gnu.org> X-Mailer: Apple Mail (2.3774.600.62) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289700 Archived-At: > On Jul 25, 2024, at 3:40=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> From: Yuan Fu >> Date: Thu, 25 Jul 2024 00:26:30 -0700 >> Cc: "Basil L. Contovounesios" , >> 71012@debbugs.gnu.org, >> Helmut Eller >>=20 >>> On Jul 24, 2024, at 10:27=E2=80=AFPM, Eli Zaretskii = wrote: >>>=20 >>>> From: "Basil L. Contovounesios" >>>> Cc: casouri@gmail.com, 71012@debbugs.gnu.org, = eller.helmut@gmail.com >>>> Date: Thu, 25 Jul 2024 01:32:01 +0200 >>>>=20 >>>> Eli Zaretskii [2024-07-24 19:31 +0300] wrote: >>>>=20 >>>>>> Cc: 71012@debbugs.gnu.org, eller.helmut@gmail.com >>>>>> From: "Basil L. Contovounesios" >>>>>> Date: Wed, 24 Jul 2024 16:57:53 +0200 >>>>>>=20 >>>>>> Ping: thoughts on whether this is an issue? >>>>>=20 >>>>> Thoughts about what? what is deemed to be a problem in this case? >>>>=20 >>>> That each call to treesit-parse-string now allocates a new internal >>>> buffer which is not automatically GCed. >>>>=20 >>>> If this cannot be avoided, I think the docs should at least warn = that >>>> it's the caller's responsibility to kill the return node's buffer = when >>>> finished with it. >>>=20 >>> If the buffers aren't killed by the code, it's indeed an issue that >>> needs to be solved. At the time I suggested that the node's buffer = is >>> killed when the node is GC'ed or deleted -- have this not been done? >>=20 >> No. I think it=E2=80=99s best to implement treesit-parse-string in C = with ts_parse_string now. That way we don=E2=80=99t need to worry about = the temp buffer. >=20 > That'd be fine as well, yes. Just to update that this is taking longer than I expected. I need to = change many things so the parsed tree ends up properly gc=E2=80=99ed. = Now I remember why I used with-temp-buffer at the first place :-) Yuan