From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: `isearch-allow-scroll' - a misnomer and a bad design Date: Sun, 11 Sep 2011 11:53:23 -0700 Message-ID: References: <20110909215255.GD2733@acm.acm><7002A9DA9A804F0B9F6F251FD3A2B263@us.oracle.com><20110911103940.GA3246@acm.acm><3C4B7E318EB04AE4B7DB9FD0E4C67629@us.oracle.com> <20110911173012.GA3088@acm.acm> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1315767221 20247 80.91.229.12 (11 Sep 2011 18:53:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 11 Sep 2011 18:53:41 +0000 (UTC) Cc: emacs-devel@gnu.org To: "'Alan Mackenzie'" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 11 20:53:36 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R2p9r-0006Xf-LV for ged-emacs-devel@m.gmane.org; Sun, 11 Sep 2011 20:53:35 +0200 Original-Received: from localhost ([::1]:46295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2p9r-0003hu-7T for ged-emacs-devel@m.gmane.org; Sun, 11 Sep 2011 14:53:35 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:53336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2p9o-0003ho-Eg for emacs-devel@gnu.org; Sun, 11 Sep 2011 14:53:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R2p9n-0008CC-8g for emacs-devel@gnu.org; Sun, 11 Sep 2011 14:53:32 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:55418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2p9n-0008C6-0D for emacs-devel@gnu.org; Sun, 11 Sep 2011 14:53:31 -0400 Original-Received: from rtcsinet22.oracle.com (rtcsinet22.oracle.com [66.248.204.30]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p8BIrR17026612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 11 Sep 2011 18:53:29 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by rtcsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p8BIrPdI029334 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 11 Sep 2011 18:53:26 GMT Original-Received: from abhmt114.oracle.com (abhmt114.oracle.com [141.146.116.66]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p8BIrKs8031573; Sun, 11 Sep 2011 13:53:20 -0500 Original-Received: from dradamslap1 (/10.159.62.110) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 11 Sep 2011 11:53:19 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <20110911173012.GA3088@acm.acm> Thread-Index: AcxwqQMOclBShILURJCIQ2LP/OTl+QAA0V+g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: rtcsinet22.oracle.com [66.248.204.30] X-CT-RefId: str=0001.0A090203.4E6D03A9.00AD,ss=1,re=0.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 141.146.126.227 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:143897 Archived-At: > `univeral-argument-minus' isn't used anymore. The C-- is now > handled by `negative-argument'. Huh? (defvar universal-argument-map (let ((map (make-sparse-keymap))) ... (define-key map [?-] 'universal-argument-minus) ... (define-key map [kp-subtract] 'universal-argument-minus) ...)) > > Can this patch please be installed? Or are there people > > who prefer that `C-u' exit Isearch? If there are, then can > > we please have a user option for this choice? > > Here's another version of the patch, this time with > `isearch-allow-prefix'. Its doc string isn't all that great; > perhaps you can improve it. I suggest "prefix-arg", not just "prefix", in the option name. There are lots of prefixes of different kinds in Emacs. I suggest that the default value allow `C-u' pass-through, not prevent it. It sounded like those weighing in so far on this all agreed that this should be the (new) behavior. I suggest turning it around: `isearch-prefix-arg-terminates' or `isearch-prefix-arg-terminates-search' (with default value nil, allowing pass-through). Easier to document, for one thing: "Non-nil means that a prefix argument terminates search. Ignored (treated as nil) if `isearch-allow-scroll' is non-nil." To me that's simpler and clearer. (It is misleading to say that a prefix arg is "allowed" - it is always allowed. The question is whether it gets passed to the command or it terminates search immediately.) Putting it this way also leaves open the possibility that termination might still occur if the value is nil (e.g. if the command itself chooses to exit). IOW, nil does not definitively prevent termination. (Yes, I know, it is not the `C-u' but the command that would terminate. Still, it's clearer not to state that a nil value prevents termination.) > As for installing it, it's fine by me, but you'd have to > negotiate with Stefan, since we're in feature freeze. Nothing to negotiate. He and Yidong can decide based on what's already been discussed. > Before installing, there really ought to be a mention of the > feature in the Emacs manual. Dunno about that. But if the new behavior is to allow `C-u' pass-through, then this would be a user-visible change and should be mentioned in NEWS.