* Remove redundant "Select link" prompt in C-c C-o
@ 2009-09-07 23:35 Bastien
2009-09-08 6:05 ` Carsten Dominik
0 siblings, 1 reply; 3+ messages in thread
From: Bastien @ 2009-09-07 23:35 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
Since the minibuffer already prompts the user to select a link
when C-c C-o triggers a choice, no need to prompt this again in
the temporary window.
Objections?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org.el.patch --]
[-- Type: text/x-diff, Size: 429 bytes --]
diff --git a/lisp/org.el b/lisp/org.el
index b58cacc..39ef466 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -8094,7 +8094,6 @@ there is one, offer it as link number zero."
(save-window-excursion
(delete-other-windows)
(with-output-to-temp-buffer "*Select Link*"
- (princ "Select link\n\n")
(mapc (lambda (l)
(if (not (string-match org-bracket-link-regexp l))
(princ (format "[%c] %s\n" (incf cnt)
[-- Attachment #3: Type: text/plain, Size: 14 bytes --]
--
Bastien
[-- Attachment #4: Type: text/plain, Size: 204 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Remove redundant "Select link" prompt in C-c C-o
2009-09-08 6:05 ` Carsten Dominik
@ 2009-09-08 3:13 ` Bastien
0 siblings, 0 replies; 3+ messages in thread
From: Bastien @ 2009-09-08 3:13 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
Carsten Dominik <carsten.dominik@gmail.com> writes:
> OK to this change as well.
Done as well.
--
Bastien
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Remove redundant "Select link" prompt in C-c C-o
2009-09-07 23:35 Remove redundant "Select link" prompt in C-c C-o Bastien
@ 2009-09-08 6:05 ` Carsten Dominik
2009-09-08 3:13 ` Bastien
0 siblings, 1 reply; 3+ messages in thread
From: Carsten Dominik @ 2009-09-08 6:05 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
OK to this change as well.
- Carsten
On Sep 8, 2009, at 1:35 AM, Bastien wrote:
> Since the minibuffer already prompts the user to select a link
> when C-c C-o triggers a choice, no need to prompt this again in
> the temporary window.
>
> Objections?
>
> diff --git a/lisp/org.el b/lisp/org.el
> index b58cacc..39ef466 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -8094,7 +8094,6 @@ there is one, offer it as link number zero."
> (save-window-excursion
> (delete-other-windows)
> (with-output-to-temp-buffer "*Select Link*"
> - (princ "Select link\n\n")
> (mapc (lambda (l)
> (if (not (string-match org-bracket-link-regexp l))
> (princ (format "[%c] %s\n" (incf cnt)
>
> --
> Bastien
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-08 9:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-07 23:35 Remove redundant "Select link" prompt in C-c C-o Bastien
2009-09-08 6:05 ` Carsten Dominik
2009-09-08 3:13 ` Bastien
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.