Tool-bar icons with disabled/selected states not displayed (Carbon port)

Tool-bar icons with disabled/selected states not displayed (Carbon port)

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

At least the Carbon port has an issue with drawing xpm icons (e.g.  
typical tool-bar icons) when icons for the "disabled" state are  
specified.
Key definitions for the tool-bar map allow for a vector of four image  
descriptors to be given.

This works fine for xpm on X, but not in the Carbon port. Here, if a  
"disabled" state is given, it is not displayed - see screenshot.  
Interestingly, png images may be specified here and things work fine  
then.
Have a look at the test case below to demonstrate.

(As a side-note, png masks don't seem to be supported, not even with  
bitmasks rather than a full alpha-channel. Is that correct? that's  
the reason why I find myself using xpm in the first place).



[-- Attachment #2: pastedGraphic.png --]
[-- Type: image/png, Size: 5433 bytes --]

[-- Attachment #3: Type: text/plain, Size: 1357 bytes --]



(setq save-as-active nil)
(let* ((image (find-image (list '(:type xpm :file "s1.xpm"))))
       (image-dis (find-image (list '(:type xpm :file "s1.dis.xpm"))))
       (images (vector image image image-dis image-dis)))
       (define-key-after tool-bar-map [save-icon]
	`(menu-item "Save As" '("Save as" (nil) . save-i) :image ,images
		    :enable save-as-active)))
(let* ((image (find-image (list '(:type png :file "s1.png"))))
       (image-dis (find-image (list '(:type png :file "s1.dis.png"))))
       (images (vector image image image-dis image-dis)))
       (define-key-after tool-bar-map [save-icon-2]
	`(menu-item "Save As x" '("Save as" (nil) . save-i) :image ,images
		    :enable save-as-active)))

;; at this point, only the png "disabled" icon is displayed, but not  
the xpm one.

(setq save-as-active t)




In GNU Emacs 22.0.50.1 (powerpc-apple-darwin7.9.0)
of 2006-04-14 on rodrigues.inf.ed.ac.uk
X server distributor `Apple Computers', version 10.4.6
configured using `configure '--without-x' '--prefix=/usr/local''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: nil
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: nil
   locale-coding-system: iso-8859-1
   default-enable-multibyte-characters: t



[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Tool-bar icons with disabled/selected states not displayed (Carbon port)

[YAMAMOTO Mitsuharu]

>>>>> On Mon, 1 May 2006 18:08:29 +0100, David Reitter <david.reitter@gmail.com> said:

> At least the Carbon port has an issue with drawing xpm icons (e.g.
> typical tool-bar icons) when icons for the "disabled" state are
> specified.  Key definitions for the tool-bar map allow for a vector
> of four image descriptors to be given.

> This works fine for xpm on X, but not in the Carbon port. Here, if a
> "disabled" state is given, it is not displayed - see screenshot.
> Interestingly, png images may be specified here and things work fine
> then.  Have a look at the test case below to demonstrate.

I suspect the issue is in displaying "s1.dis.xpm" simply, rather than
in general disabled image handling.  Can you show its contents?

> (As a side-note, png masks don't seem to be supported, not even with
> bitmasks rather than a full alpha-channel. Is that correct? that's
> the reason why I find myself using xpm in the first place).

For the Carbon port, yes.  Because QuickTime cannot tell the
difference between them as far as I know.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: Tool-bar icons with disabled/selected states not displayed (Carbon port)

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

On 1 May 2006, at 23:26, YAMAMOTO Mitsuharu wrote:
>
> I suspect the issue is in displaying "s1.dis.xpm" simply, rather than
> in general disabled image handling.  Can you show its contents?

Sure, these are the two files. Generated with ImageMagick.

However, I'm getting the same effect with the other toolbar buttons  
that I've replaced.



[-- Attachment #2: s1.xpm --]
[-- Type: application/octet-stream, Size: 5771 bytes --]

/* XPM */
static char *saveas[] = {
/* columns rows colors chars-per-pixel */
"28 28 257 2",
"   c #3B2D19",
".  c #272728",
"X  c #342D21",
"o  c #312F2C",
"O  c gray20",
"+  c #3B3532",
"@  c #3C3B3A",
"#  c #5E3415",
"$  c #4B3C29",
"%  c #523423",
"&  c #793A0E",
"*  c #42403F",
"=  c #544422",
"-  c #514535",
";  c #544A3B",
":  c #5B4E3A",
">  c #6E400C",
",  c #7C4D08",
"<  c #764B17",
"1  c #784B17",
"2  c #434343",
"3  c #4C4C4C",
"4  c #4E5053",
"5  c #5D5240",
"6  c #535352",
"7  c #56595E",
"8  c #5C5D5D",
"9  c #4D596B",
"0  c #525760",
"q  c #525964",
"w  c #515D6E",
"e  c #585B60",
"r  c #5F6163",
"t  c #556070",
"y  c #596474",
"u  c #625746",
"i  c #675B46",
"p  c #65594C",
"a  c #6A5B4A",
"s  c #6A5E50",
"d  c #745F4E",
"f  c #676056",
"g  c #67615E",
"h  c #6D6252",
"j  c #6F6559",
"k  c #6F685B",
"l  c #766A5A",
"z  c #636362",
"x  c #666869",
"c  c #6B6663",
"v  c #6A6864",
"b  c gray42",
"n  c #606B7A",
"m  c #6F706E",
"M  c #6D737B",
"N  c #756E63",
"B  c #72706E",
"V  c #787065",
"C  c #747373",
"Z  c #71767C",
"A  c #76797E",
"S  c #787877",
"D  c #7C7C7B",
"F  c #677180",
"G  c #6B7584",
"H  c #6F7988",
"J  c #727C8B",
"K  c #7D7F80",
"L  c #7A828D",
"P  c #7B8592",
"I  c #7E8897",
"U  c #9F4604",
"Y  c #B84B00",
"T  c #8E6240",
"R  c #907B5D",
"E  c #9D7552",
"W  c #D70101",
"Q  c #DA0F01",
"!  c #D51919",
"~  c #D81F1F",
"^  c #DB2801",
"/  c #DA2727",
"(  c #DB2D2C",
")  c #DE3B39",
"_  c #E30602",
"`  c #EC0701",
"'  c #F30601",
"]  c #FA0500",
"[  c #E62F01",
"{  c #EC3400",
"}  c #FF2F00",
"|  c #F43300",
" . c #FA3400",
".. c #C64F00",
"X. c #CC4C00",
"o. c #C45000",
"O. c #CC5100",
"+. c #D74300",
"@. c #D04C00",
"#. c #D05002",
"$. c #D25E10",
"%. c #D26518",
"&. c #D67935",
"*. c #F54C00",
"=. c #DF4341",
"-. c #E35553",
";. c #E4605E",
":. c #E76F6D",
">. c #E87876",
",. c #E97B7B",
"<. c #AB8262",
"1. c #C58250",
"2. c #D48043",
"3. c #E19F74",
"4. c #F3967F",
"5. c #858584",
"6. c #838588",
"7. c #8B8B8B",
"8. c #828A98",
"9. c #8B8D90",
"0. c #87909E",
"q. c #8C929D",
"w. c #939393",
"e. c #92969D",
"r. c #9A9B9C",
"t. c #8E96A1",
"y. c #9097A2",
"u. c #9198A3",
"i. c #979FAB",
"p. c #989CA2",
"a. c #9EA2A7",
"s. c #99A0AA",
"d. c #9FA8B4",
"f. c #A2A3A3",
"g. c #A3A7AC",
"h. c #AAAAAA",
"j. c #A1A8B1",
"k. c #AAADB2",
"l. c #AAAFB8",
"z. c #AFB2B6",
"x. c #A9B0BA",
"c. c #B2B2B3",
"v. c #B3B6BB",
"b. c #B5B8BC",
"n. c #B8B8B7",
"m. c #BBBBBB",
"M. c #B0B7C1",
"N. c #BBBDC2",
"B. c #BEC0C3",
"V. c #BFC5CE",
"C. c #C8A88F",
"Z. c #CBB29F",
"A. c #D5A98C",
"S. c #CBB9AB",
"D. c #E68484",
"F. c #E78885",
"G. c #EC8580",
"H. c #E89086",
"J. c #E99A86",
"K. c #E1A682",
"L. c #E9A086",
"P. c #E9A48A",
"I. c #EAA98B",
"U. c #EBA3A2",
"Y. c #EEB0A1",
"T. c #EFB5B3",
"R. c #CDC0B6",
"E. c #C8C2BB",
"W. c #F0C1B0",
"Q. c #C2C3C3",
"!. c #C2C6CC",
"~. c #C4C8CD",
"^. c #C8C8C7",
"/. c #CBCBCB",
"(. c #C4C9D1",
"). c #CDCFD1",
"_. c #CFD0D0",
"`. c #D2D2D2",
"'. c #D3D5D8",
"]. c #DDD9D6",
"[. c gray86",
"{. c #F1C5C4",
"}. c #F3CEC2",
"|. c #F4D4D3",
" X c #F6DBD2",
".X c #E0E0DF",
"XX c #F8E6DF",
"oX c #E3E3E2",
"OX c #EAEAEA",
"+X c #F8E2E2",
"@X c #F0F0EF",
"#X c #FAF0EC",
"$X c #F1F1F1",
"%X c #FEF1F0",
"&X c gray80",
"*X c black",
"=X c black",
"-X c black",
";X c black",
":X c black",
">X c black",
",X c black",
"<X c black",
"1X c black",
"2X c black",
"3X c black",
"4X c black",
"5X c black",
"6X c black",
"7X c black",
"8X c black",
"9X c black",
"0X c black",
"qX c black",
"wX c black",
"eX c black",
"rX c black",
"tX c black",
"yX c black",
"uX c black",
"iX c black",
"pX c black",
"aX c black",
"sX c black",
"dX c black",
"fX c black",
"gX c black",
"hX c black",
"jX c black",
"kX c black",
"lX c black",
"zX c black",
"xX c black",
"cX c black",
"vX c black",
"bX c black",
"nX c black",
"mX c black",
"MX c black",
"NX c black",
"BX c black",
"VX c black",
"CX c black",
"ZX c black",
"AX c black",
"SX c black",
"DX c black",
"FX c black",
"GX c black",
"HX c black",
"JX c black",
"KX c black",
"LX c black",
"PX c black",
"IX c black",
"UX c black",
"YX c None",
/* pixels */
"YXYXOXoX[.[.[.[.'.[.[.[.[.[.[.[.[.[.[.[.[.[.oXYXYXYXYXYX",
"YXOX'.(.~.!.`.oXoXoXoXoXoX.X.X.XoXoX.X.X/.~.~..XYXYXYXYX",
"YX.X!.B.B.B.[.$X$X$X$X$X$X[././.`.$X@X@X/.B.V.V.OXYXYXYX",
"YX~.N.m.n.n.`.$X$X$X$X$X$X_.n.n.^.@X@X@XQ.n.m.N._.OXYXYX",
"YXN.v.c.c.h./.$XOX$X$X$X$X_.c.c.B.@X@XOXm.c.c.v.M.'.OXYX",
"YXN.l.h.h.h.Q.$X$X$XOX$X$X^.f.h.n.OX@XOXc.h.h.h.l.x.oXYX",
"YXv.j.f.f.f.E.$XOX$XOXOXOXE.r.r.c.OXOXOXh.f.a.a.a.d.^.YX",
"YXl.i.r.r.w.m.$XOX$X$X$X$X`.n.n.E.OXOXOXf.r.r.r.r.s.B.YX",
"YXk.u.w.w.w.f.N.m.m.m.m.m.n.m.S.h.S B 5.w.w.w.w.w.y.N.YX",
"YXj.0.9.7.7.5.5.5.7.5.5.5.7.6.L 2 h.].B 8 7.9.I 7.0.b.YX",
"YXa.I P 5.5.5.5.5.5.7.7.5.7.7.C v #X#XE.3 5.5.P 5.8.v.YX",
"YXp.P L <.5.5.5.5.D S S C C C r N XX+XR.3 5.5.<.5.P z.YX",
"YXe.P K D S z 3 2 @ + O O O O . f  X|.S.@ B A K K J l.YX",
"YX9.H b 8 2 2 D 5.5.5.5.5.5.5.b k }.{.Z.o O 6 z B H k.YX",
"YXL t 6 3 @ Q.oX.XoX[._././._.k.l T.T.C.c r O 4 4 9 a.YX",
"OXM w 8 3 v .X[..XN.g h h h h i R Y.U.A.a u $ ; ; $ K YX",
"OXM y z 4 b .X[.[.k <.I.I.P.I.P.J.F.D.H.L.P.P.P.P.L.s [.",
"OXM n b 6 b .X.X`.p 3.F.>.;.=.( ~ ! ! ! / ) -.:.D.J.E ~.",
"OXM M C 8 b .X[.[.S T 2.%.O.X.O.+.Q W ^ X.X.#.$.&.&.a .X",
"OXC G A g b .X[.[./.D i i i s : , [ _ o.= :   $ $ + 9.YX",
"OXZ L K x b .X[.[..X[.[.'.[.[.b.< { _ ..V h.3 D K G p.YX",
"OXZ L 7.m x .X.X[.[.[.[.[.[.[.m.< | ` ..V h.6 5.5.H r.YX",
"OXZ I 9.<.3 m..X.X.X.X.X.X.X.XN.< | ' ..k B b 7.7.J r.YX",
"OXA I t.I C 6 C D D D D D D D x > | ' O.X 8 7.w.w.J r.YX",
"YX7.I r.w.w.7.S C C C C C C C z >  .] O.; e.w.w.r.H g.YX",
"YX_.q I q.q.q.e.q.q.y.q.y.y.q.P # *.} Y 4 t.t.t.I 7 [.YX",
"YXYX`.7.Z A A Z A A b q q 7 7 7 $ & U % 4 e q q 6.'.YXYX",
"YXYXYXYXOXOXOXOXOXoXOXOXOXoXOXoXoX`.^.[.oXOXoXOXOXYXYXYX"
};

[-- Attachment #3: s1.dis.xpm --]
[-- Type: application/octet-stream, Size: 3696 bytes --]

/* XPM */
static char *saveas.dis[] = {
/* columns rows colors chars-per-pixel */
"28 28 119 2",
"   c #2B2B2C",
".  c #363635",
"X  c #393735",
"o  c #3A3A3A",
"O  c #403D39",
"+  c #444343",
"@  c #4B4A4A",
"#  c #524F4B",
"$  c #56504C",
"%  c #545454",
"&  c #585652",
"*  c #5C5851",
"=  c #5C5B5A",
"-  c #5F6061",
";  c #675E57",
":  c #65625D",
">  c #626264",
",  c #6B6965",
"<  c #6C6C6B",
"1  c #6F7175",
"2  c #716E6C",
"3  c #796E63",
"4  c #74716E",
"5  c #747473",
"6  c #73767A",
"7  c #7A7775",
"8  c #7A7875",
"9  c #7C7C7C",
"0  c #7D7E80",
"q  c #7F8082",
"w  c #83756B",
"e  c #82796D",
"r  c #887E6E",
"t  c #807F7B",
"y  c #84827F",
"u  c #828383",
"i  c #87898C",
"p  c #888887",
"a  c #8B8B8B",
"s  c #8C8D90",
"d  c #8F9090",
"f  c #9C928B",
"g  c #939393",
"h  c #94969A",
"j  c #96989C",
"k  c #9E9993",
"l  c #9B9B9C",
"z  c #9C9EA0",
"x  c #9FA1A5",
"c  c #AE9B8D",
"v  c #ABA39B",
"b  c #A2A3A3",
"n  c #A3A5A8",
"m  c #AAABAB",
"M  c #ADAEB1",
"N  c #AFB0B2",
"B  c #BCB3AC",
"V  c #B2B3B3",
"C  c #B7B7B8",
"Z  c #B7B8BB",
"A  c #BBBBBB",
"S  c #BFBFC0",
"D  c #BFC0C1",
"F  c #CAB2A1",
"G  c #D7BEAC",
"H  c #D9BFAE",
"J  c #ECBDBD",
"K  c #DDC2B0",
"L  c #D8C9BE",
"P  c #E1C5B4",
"I  c #E4C8B7",
"U  c #E7CEBD",
"Y  c #ECCBBD",
"T  c #C2C3C3",
"R  c #C7C7C8",
"E  c #C7C8CA",
"W  c #CCCCCC",
"Q  c #CECFD1",
"!  c #DCD4CF",
"~  c #D3D4D4",
"^  c #D6D7D8",
"/  c #D7D8D9",
"(  c #DFD9D5",
")  c #DCDCDC",
"_  c #DEDFE0",
"`  c #DFE0E1",
"'  c #ECC2C1",
"]  c #EFC8C8",
"[  c #EBD6C7",
"{  c #E9D6C9",
"}  c #E1DEDC",
"|  c #F6C6C5",
" . c #F0C9C0",
".. c #F0CACA",
"X. c #FECCCB",
"o. c #F4D0CF",
"O. c #FED2CC",
"+. c #FFD9CD",
"@. c #F5D2D2",
"#. c #FFD5D4",
"$. c #FFDCD1",
"%. c #FCDBDA",
"&. c #EAE0DA",
"*. c #F7E8DF",
"=. c #FFE0D4",
"-. c #FFE5DA",
";. c #FFE8D7",
":. c #E4E4E4",
">. c #E7E8E8",
",. c #EAEAEA",
"<. c #F7EAE2",
"1. c #FEE5E5",
"2. c #FFEAE0",
"3. c #FEEBE9",
"4. c #FFF1EB",
"5. c #F4F4F4",
"6. c #FFF4F1",
"7. c #FFF8F4",
"8. c #FEFEFD",
/* pixels */
",.,.,.,.:.:.:.>.:.:.,.:.:.,.:.:.:.:.:.,.:.:.,.,.,.,.,.,.",
",.,.,.,.` ) >.5.8.5.5.5.5.5.5.5.5.5.5.5.) :._ :.,.,.,.,.",
",.,.:.^ ~ ~ ,.8.8.8.8.8.8.5.&.` ,.8.8.8.) ^ _ ) ,.,.,.,.",
",.^ ^ W W E >.8.8.8.8.8.8.>.E E ) 8.8.8./ W Q / &.,.,.,.",
",.Q Q T D D &.8.8.8.8.8.8.&.D D W 8.8.8.Q D L W ~ ` ,.,.",
",.W E A A A ) 8.8.8.8.8.8.) Z Z W 8.8.8.R Z Z A D W ,.,.",
",.R S V V V ~ 8.8.8.8.8.8.~ m m A 8.8.8.A N V V Z D ^ >.",
",.D Z m m b W 8.8.8.8.8.8.:.W W ) 8.8.8.C n n m m S Q >.",
",.Z N v b b N Q W W Q W Q W Q Q L q 6 d z x v x x N E >.",
",.Z m l k l g g g h g g g g f a @ A 5.9 , l l l l m E >.",
",.N x g g g g g h g g g g h k 9 5 8.8.( % g g h h x S >.",
",.m z d d d d d a a p y y 0 q < 8 8.8.} % d d a d z L ,.",
",.x j a i q < % + + o o . . .   2 8.8.) + 9 p i a j Z ,.",
",.z d 5 , + @ p d g d d g g g 8 8 8.8.( . o = < 9 d Z ,.",
",.s 6 - % + ~ 8.8.5.5.:.` &.:.S 0 7.7.! 2 < o $ & 1 m ,.",
",.0 6 , % 2 5.5.5.~ 2 4 5 7 4 < k 7.6.&.< , * = = + i ,.",
",.q 0 < = 1 5.5.,.5 B 4.4.4.4.3.4.3.1.3.3.3.4.4.4.<.8 _ ",
">.q q 5 - 1 5.5.>.< *.4.1.*.@.] ' ' J Y ..@.%.1.3.6.v W ",
",.q i 0 , 5 5.5.5.q f [ U P P P Y Y J | I P L Y [ L < :.",
",.q d p < 6 5.5.5.&.p < 4 4 4 : r O.| H * : o # $ o g ,.",
",.u g d 1 6 5.5.5.5.5.5.,.,.5.W 8 +.X.G t A & a a a n ,.",
",.u j g 9 2 5.5.5.5.5.,.5.5.5.W w $.O.K y C = g h d b ,.",
",.q z l d % W 5.5.5.5.5.5.5.5.~ e =.#.K 8 9 5 l j h b ,.",
",.u b z x y = u p p a p p i i 1 3 ;.#.P X > l l z z v ,.",
",.g x m b n g u y q q 9 9 9 9 < 3 -.%.P & n n n m h m ,.",
",.^ < x m m m m m m m N N N N l ; ;.-.F % N m N b > _ ,.",
",.,.^ g u u u u q q 5 - - - - - + w c $ % - - - a ) ,.,.",
",.,.,.,.,.,.,.,.,.,.,.,.,.:.,.,.:.~ ~ ) ,.:.>.,.,.,.,.,."
};

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Tool-bar icons with disabled/selected states not displayed (Carbon port)

[YAMAMOTO Mitsuharu]

>>>>> On Tue, 2 May 2006 00:43:40 +0100, David Reitter <david.reitter@gmail.com> said:

>> I suspect the issue is in displaying "s1.dis.xpm" simply, rather
>> than in general disabled image handling.  Can you show its
>> contents?

> Sure, these are the two files. Generated with ImageMagick.

> However, I'm getting the same effect with the other toolbar buttons
> that I've replaced.

Don't they contain `.' in their variable_name part (the part between
"static char *" and "[]" in the second line)?

The file "s1.dis.xpm" contains the following line:

  static char *saveas.dis[] = {

The specification of XPM (http://koala.ilog.fr/lehors/doc/xpm.PS) does
not explicitly state the syntax of the variable_name.  But I think it
is reasonable to assume that it coincides with that of identifiers in
C or C++, because XPM is designed so as to be included in these
languages.  (Chapter 2 starts with "The XPM format presents a C
syntax".)

I could display s1.dis.xpm if the variable_name part is replaced with
`saveas_dis'.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: Tool-bar icons with disabled/selected states not displayed (Carbon port)

[David Reitter]

On 2 May 2006, at 01:39, YAMAMOTO Mitsuharu wrote:

> Don't they contain `.' in their variable_name part (the part between
> "static char *" and "[]" in the second line)?
>
> The file "s1.dis.xpm" contains the following line:
>
>   static char *saveas.dis[] = {
>
> The specification of XPM (http://koala.ilog.fr/lehors/doc/xpm.PS) does
> not explicitly state the syntax of the variable_name.  But I think it
> is reasonable to assume that it coincides with that of identifiers in
> C or C++, because XPM is designed so as to be included in these
> languages.  (Chapter 2 starts with "The XPM format presents a C
> syntax".)
>
> I could display s1.dis.xpm if the variable_name part is replaced with
> `saveas_dis'.

Yes, I see your point. I assume that these files are parsed by X  
rather than by Emacs?
That would explain why it's working just fine on X.

I've changed my files and all is good now. I don't think this bug is  
terribly important to fix in Emacs, but I'll take it up with the  
ImageMagick people, whose code has produced the xpms.

Thanks.