From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Wed, 8 May 2019 13:48:51 +0200 Message-ID: References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="143797"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Michael Albinus , 35418@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 08 13:49:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOL4R-000bDf-6S for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2019 13:49:11 +0200 Original-Received: from localhost ([127.0.0.1]:35430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOL4Q-0005xF-0A for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2019 07:49:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOL4J-0005x7-7g for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 07:49:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOL4I-0006LV-4x for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 07:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46949) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOL4I-0006LN-27 for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 07:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hOL4H-00084B-WE for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 07:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 11:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155731614030999 (code B ref 35418); Wed, 08 May 2019 11:49:01 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 8 May 2019 11:49:00 +0000 Original-Received: from localhost ([127.0.0.1]:60493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOL4F-00083v-U7 for submit@debbugs.gnu.org; Wed, 08 May 2019 07:49:00 -0400 Original-Received: from mail82c50.megamailservers.eu ([91.136.10.92]:60834 helo=mail18c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOL4D-00083i-I3 for 35418@debbugs.gnu.org; Wed, 08 May 2019 07:48:58 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557316134; bh=jQqBGuPRyOMhYLjPlZLQ+pGXknma0ObhwkTZgBm6myA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=s8un8Y+gnQ9YDeDUjch7oKv1ZHQCKuY5dfpQi0I6DB7bZmzFyujV+600c17ACsBCZ Fl+ha8iWqcA7lxVO8K4TPoI7Km6+dzedG9RfvTkBKxBy9uvELtDSaerUBM/wPFY1C6 LxQjOhXUAqclayFH0DLBC3ybEYCKPJywyTd/nvlo= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x48BmqNA009765; Wed, 8 May 2019 11:48:54 +0000 In-Reply-To: <835zqli55l.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0206.5CD2C226.0097, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ZIj5Z0zb c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=wJQ6xCftTWwP08vqMlEA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158935 Archived-At: 8 maj 2019 kl. 12.58 skrev Eli Zaretskii : > IOW, I wonder whether your proposed patch could be made more general > in some way. So do I, but since I could not come up with one, this ad-hoc solution = appeared as a placeholder. The code can be improved later on, but the patch is a strict improvement = on the code in master. An example of a generalisation: We could add a buffer-specific variable = that tells autorevert that yes, this buffer can rely on directory = notifications despite not having a buffer-file-name. All modes to which = this applies would need to set that variable. I don't think there is a passive condition, and furthermore, because of = the nature of directory notifications, any mode that qualifies is likely = to be some kind of variation on Dired: a buffer whose contents is = determined by the set of files in its default-directory, but not their = data.