all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Will Farrington <wcfarrington@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: comment-dwim has no behavior to comment out the current line without a region
Date: Wed, 10 Dec 2008 07:22:58 -0500	[thread overview]
Message-ID: <D34B9C6A-69A2-4D8C-B494-F817A1D356ED@gmail.com> (raw)
In-Reply-To: <jwvzlj5w2t5.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]

On second inspection, C-M-; is not bound by default.

How would you feel about binding the following function to that  
keybinding?

(defun comment-dwim-line (&optional arg)
   ""
   (interactive "*P")
   (comment-normalize-vars)
   (if (not (region-active-p))
       (comment-or-uncomment-region (line-beginning-position) (line- 
end-position))
     (comment-dwim arg)))

Obviously a better description than "" is needed, but the behavior of  
this has changed a bit since it can now afford to (being a different  
function and keybinding). Rather than relying on the position of  
(point), it has a clear established behavior of commenting out the  
current line unless the region is active.

On Dec 9, 2008, at 2:48 PM, Stefan Monnier wrote:

>> Generally speaking, what makes BOL a "common starting point" to  
>> perform
>> comment-indent more-so than any other part of the line?
>
> I'm not sure it's much more so, but it's at least as common as
> current-indentation, end of line, etc...
>
>> Additionally, is not BOL semantically the clearest place to run  
>> comment-dwim
>> and expect it to comment out a given line rather than having it run
>> comment-indent?
>
> Could be.  I'm not saying your idea isn't good.  I'm just saying  
> that it
> is not compatible with the current behavior and that the current
> behavior makes sense as well.  You may find some other way to combine
> comment-indent, comment-kill, and comment-region onto a single key.
> E.g. M-; M-; is currently unused.
>
>
>        Stefan


[-- Attachment #2: Type: text/html, Size: 11577 bytes --]

  parent reply	other threads:[~2008-12-10 12:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09  6:06 comment-dwim has no behavior to comment out the current line without a region Will Farrington
2008-12-09  8:28 ` Will Farrington
2008-12-09  9:22   ` Will Farrington
2008-12-09 12:40   ` Eli Zaretskii
2008-12-09 18:27     ` Stefan Monnier
2008-12-09 22:54       ` Eli Zaretskii
2008-12-09 18:40 ` Stefan Monnier
2008-12-09 18:50   ` Will Farrington
2008-12-09 19:48     ` Stefan Monnier
2008-12-09 20:03       ` Will Farrington
2008-12-10 12:22       ` Will Farrington [this message]
2008-12-11 15:27         ` Stefan Monnier
2008-12-11 18:26           ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D34B9C6A-69A2-4D8C-B494-F817A1D356ED@gmail.com \
    --to=wcfarrington@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.