From: "Jan Djärv" <jan.h.d@swipnet.se>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: David Reitter <david.reitter@gmail.com>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: Possible fix for crash in NS's tooltip showAtX:Y:for:
Date: Thu, 2 May 2013 07:08:44 +0200 [thread overview]
Message-ID: <D28F4CB8-0A18-4A6D-9EF4-071440658E4A@swipnet.se> (raw)
In-Reply-To: <wlsj26asot.wl%mituharu@math.s.chiba-u.ac.jp>
Hello.
2 maj 2013 kl. 06:53 skrev YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>:
>>>>>> On Mon, 29 Apr 2013 13:56:49 -0400, David Reitter <david.reitter@gmail.com> said:
>
>> Suggest to initialize ns_tooltip as shown below. I've been seeing
>> occasional crash reports in Fx_show_tip (and showAtX). This may be
>> the culprit. (I am not sure if variables in ObjC default to nil all
>> the time.)
>
>> --- a/src/nsfns.m
>> +++ b/src/nsfns.m
>> @@ -88,7 +88,7 @@ Lisp_Object Qfontsize;
>> /* hack for OS X file panels */
>> char panelOK = 0;
>
>> -EmacsTooltip *ns_tooltip;
>> +EmacsTooltip *ns_tooltip = nil;
>
> Objective C is not different from the usual C in this respect (i.e.,
> implicit initialization of objects that have static storage duration).
> So the above change does not give any effect in theory, because `nil'
> is actually a null pointer.
>
ns_tooltip isn't static.
Jan D.
next prev parent reply other threads:[~2013-05-02 5:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 17:56 Possible fix for crash in NS's tooltip showAtX:Y:for: David Reitter
2013-05-01 7:01 ` Glenn Morris
2013-05-02 4:53 ` YAMAMOTO Mitsuharu
2013-05-02 5:08 ` Jan Djärv [this message]
2013-05-02 8:55 ` Andreas Schwab
2013-05-02 10:57 ` David Reitter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D28F4CB8-0A18-4A6D-9EF4-071440658E4A@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.