From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: [kzeitler@lucent.com: Re: compose key on SUN keyboard creates 2 characters (and beeps)] Date: Mon, 12 Jan 2004 03:55:46 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 (Apple Message framework v609) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1073876269 9428 80.91.224.253 (12 Jan 2004 02:57:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 12 Jan 2004 02:57:49 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Jan 12 03:57:46 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AfsGw-0007ON-00 for ; Mon, 12 Jan 2004 03:57:46 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AfsGv-0004Ag-00 for ; Mon, 12 Jan 2004 03:57:45 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AftE0-00025Z-20 for emacs-devel@quimby.gnus.org; Sun, 11 Jan 2004 22:58:48 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AftDg-00025I-5q for emacs-devel@gnu.org; Sun, 11 Jan 2004 22:58:28 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AftDA-00022c-CM for emacs-devel@gnu.org; Sun, 11 Jan 2004 22:58:27 -0500 Original-Received: from [193.201.16.94] (helo=stubby.bodenonline.com) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AftD9-00022O-OA; Sun, 11 Jan 2004 22:57:55 -0500 Original-Received: from accessno42.bodenonline.com (accessno42.bodenonline.com [193.201.16.44]) by stubby.bodenonline.com (8.12.1/8.12.1) with ESMTP id i0C3n6wq023933; Mon, 12 Jan 2004 04:49:07 +0100 In-Reply-To: Original-To: rms@gnu.org X-Mailer: Apple Mail (2.609) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19137 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19137 > Can somebody who knows these issues better than I do please think > about whether this is correct? > > I'm assuming these lines are to be added rather than subtracted since they are not in xterm.c 1.823. The internals of XComposeStatus is intended to be hidden, i.e. can change at any time, so looking inside it might be unportable. But a check for > 0 (no need to limit ourselves to 1 or 2) can be done. But we should do break instead of goto OTHER. Checking for nbytes <= 0 is not an option as we would then miss several keys that returns 0 (function keys, the key, keypad keys ...). Jan D. > *** xterm.c Thu Jan 8 09:31:58 2004 > --- xterm.c.~1.823.~ Thu Jan 8 09:31:00 2004 > *************** > *** 6305,6316 **** > &compose_status); > #endif > > - /* Check if we're processing a composed key. In this case we need > - 3 key presses till the key is complete. */ > - if ((compose_status.chars_matched == 1) || > - (compose_status.chars_matched == 2)) > - goto OTHER; > - > orig_keysym = keysym; > > if (numchars > 1) > --- 6305,6310 ---- > > --=-=-= > > > as I said in my original post instead of these lines it also works if > one > checks nbytes instead, i.e. > --- snip --- > if (nbytes <= 0) > goto OTHER; > --- snip --- > should also work. > > Since you asked if this is still needed I'm guessing that the compose > key > works for other operating systems, e.g. GNU/Linux. Is that so? > > Klaus > > -- > ------------------------------------------ > | Klaus Zeitler Lucent Technologies | > | Email: kzeitler@lucent.com | > ------------------------------------------ > --- > Early to rise, and early to bed / Makes a man healthy but socially dead > --=-=-=-- > > > > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://mail.gnu.org/mailman/listinfo/emacs-devel