From: "Jan D." <jan.h.d@swipnet.se>
Cc: emacs-devel@gnu.org
Subject: Re: [kzeitler@lucent.com: Re: compose key on SUN keyboard creates 2 characters (and beeps)]
Date: Mon, 12 Jan 2004 03:55:46 +0100 [thread overview]
Message-ID: <D1F2EC5B-44AA-11D8-A2E7-00039363E640@swipnet.se> (raw)
In-Reply-To: <E1Aev65-00057F-1m@fencepost.gnu.org>
> Can somebody who knows these issues better than I do please think
> about whether this is correct?
>
>
I'm assuming these lines are to be added rather than subtracted since
they
are not in xterm.c 1.823.
The internals of XComposeStatus is intended to be hidden, i.e. can
change at any time, so looking inside it might be unportable. But a
check for > 0 (no need to limit ourselves to 1 or 2) can be done. But
we should do break instead of goto OTHER.
Checking for nbytes <= 0 is not an option as we would then miss several
keys that returns 0 (function keys, the <menu> key, keypad keys ...).
Jan D.
> *** xterm.c Thu Jan 8 09:31:58 2004
> --- xterm.c.~1.823.~ Thu Jan 8 09:31:00 2004
> ***************
> *** 6305,6316 ****
> &compose_status);
> #endif
>
> - /* Check if we're processing a composed key. In this case we need
> - 3 key presses till the key is complete. */
> - if ((compose_status.chars_matched == 1) ||
> - (compose_status.chars_matched == 2))
> - goto OTHER;
> -
> orig_keysym = keysym;
>
> if (numchars > 1)
> --- 6305,6310 ----
>
> --=-=-=
>
>
> as I said in my original post instead of these lines it also works if
> one
> checks nbytes instead, i.e.
> --- snip ---
> if (nbytes <= 0)
> goto OTHER;
> --- snip ---
> should also work.
>
> Since you asked if this is still needed I'm guessing that the compose
> key
> works for other operating systems, e.g. GNU/Linux. Is that so?
>
> Klaus
>
> --
> ------------------------------------------
> | Klaus Zeitler Lucent Technologies |
> | Email: kzeitler@lucent.com |
> ------------------------------------------
> ---
> Early to rise, and early to bed / Makes a man healthy but socially dead
> --=-=-=--
>
>
>
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2004-01-12 2:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-09 11:46 [kzeitler@lucent.com: Re: compose key on SUN keyboard creates 2 characters (and beeps)] Richard Stallman
2004-01-12 2:55 ` Jan D. [this message]
2004-01-12 9:33 ` Klaus Zeitler
2004-01-12 11:48 ` Jan D.
2004-01-12 14:25 ` Klaus Zeitler
2004-01-13 16:30 ` Jan D.
2004-01-14 10:46 ` Klaus Zeitler
2004-01-16 10:25 ` Jan D.
2004-01-16 12:57 ` Klaus Zeitler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1F2EC5B-44AA-11D8-A2E7-00039363E640@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.