From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS Date: Fri, 21 Aug 2020 16:53:34 +0200 Message-ID: References: <83lfidgtc7.fsf@gnu.org> <838sedgq2x.fsf@gnu.org> <02F52D43-7EAB-4E61-A567-E8CCD11D856B@acm.org> <20200817195610.GA70682@breton.holly.idiocy.org> <3F71EF82-A143-4E3A-AEF3-8A236091891D@acm.org> <20200818084306.GA89999@breton.holly.idiocy.org> <243A5DA8-2865-485D-A8A2-1F543B046BAA@acm.org> <20200818172824.GA90575@breton.holly.idiocy.org> <83h7sxcux5.fsf@gnu.org> <5719A3A9-06A2-42AF-A290-726D96B6E6F1@acm.org> <834koxcere.fsf@gnu.org> <83ft8gb05o.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_8420675B-ECF9-4B50-A662-D373F4D826CA" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32837"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42904@debbugs.gnu.org, alan@idiocy.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 21 16:54:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k98Qk-0008RV-Sb for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 16:54:10 +0200 Original-Received: from localhost ([::1]:41302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k98Qj-0005H7-VA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 10:54:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k98Qc-0005Fh-Hs for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 10:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36468) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k98Qc-0001qA-8J for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 10:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k98Qc-0002ba-6o for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 10:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42904 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42904-submit@debbugs.gnu.org id=B42904.15980216249981 (code B ref 42904); Fri, 21 Aug 2020 14:54:02 +0000 Original-Received: (at 42904) by debbugs.gnu.org; 21 Aug 2020 14:53:44 +0000 Original-Received: from localhost ([127.0.0.1]:48014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k98QK-0002au-08 for submit@debbugs.gnu.org; Fri, 21 Aug 2020 10:53:44 -0400 Original-Received: from mail211c50.megamailservers.eu ([91.136.10.221]:40438 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k98QG-0002ai-Vm for 42904@debbugs.gnu.org; Fri, 21 Aug 2020 10:53:42 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1598021618; bh=YS773kL1EwMm7xxQRucKTKe0UFRN/ruTStAYy6zR9uk=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=VH0pgjkHuz5Tlr8Oz8lKXZ+j/9X7e+ZSKTrNx0nNowKYU4iaWdnWe9sWpGUMFMJdg jtCyg2TVTlw65nrv8XAv6wICIXXfLbJ42ivBxt5PBvKVPJ2Zf+5DQnCjDvYelFqCAr 4VF6gp+tMx8EIPJPqIwwnzitf5xQIO7M2NshQsIM= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 07LErZF4012154; Fri, 21 Aug 2020 14:53:37 +0000 In-Reply-To: <83ft8gb05o.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.15) X-CTCH-RefID: str=0001.0A782F1A.5F3FDFF2.0031, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=KsozJleN c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=TWrO6TkA-wukqx8Q5AwA:9 a=QEXdDO2ut3YA:10 a=Ee3TwFF96ZHXJ2WqImsA:9 a=B2y7HmGcmWMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185883 Archived-At: --Apple-Mail=_8420675B-ECF9-4B50-A662-D373F4D826CA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 21 aug. 2020 kl. 15.26 skrev Eli Zaretskii : > That is true, but str_as_multibyte simply interprets any valid UTF-8 > sequence as a character, and any invalid sequence as a raw bytes. I > thought this was precisely what you wanted for this use case, no? Sorry, I read the comment for that function and got the impression that = it would interpret raw bytes as Latin-1. Fortunately that wasn't true, = and using it seems to be a clear improvement. Now a mixture of non-ASCII = and raw bytes, like "a\377b=C3=BCc" results in the title "a=EF=BF=BD=EF=BF= =BDb=C3=BCc", which is one =EF=BF=BD too many but good enough. What about the attached patch then? Only tested on macOS, admittedly. --Apple-Mail=_8420675B-ECF9-4B50-A662-D373F4D826CA Content-Disposition: attachment; filename=0001-Always-make-a-multibyte-string-for-the-frame-title-b.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Always-make-a-multibyte-string-for-the-frame-title-b.patch" Content-Transfer-Encoding: quoted-printable =46rom=20dbe9ee59a179a3d42f337c60b5f426f6ff2913ca=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Fri,=2021=20Aug=202020=2016:09:04=20+0200=0A= Subject:=20[PATCH]=20Always=20make=20a=20multibyte=20string=20for=20the=20= frame=20title=0A=20(bug#42904)=0A=0A*=20src/xdisp.c=20= (gui_consider_frame_title):=20Multibyte-encode=20any=20raw=0Abytes=20in=20= the=20title,=20and=20then=20pass=20a=20multibyte=20string=20to=20the=20= back-end=0Afor=20use=20as=20a=20frame=20title.=20=20This=20cuts=20down=20= a=20little=20on=20the=20rubbish=0Ashown=20when=20raw=20bytes=20sneak=20= in=20by=20mistake=20(as=20part=20of=20the=20buffer=20name,=0Afor=20= instance).=0A---=0A=20src/xdisp.c=20|=2012=20+++++++++---=0A=201=20file=20= changed,=209=20insertions(+),=203=20deletions(-)=0A=0Adiff=20--git=20= a/src/xdisp.c=20b/src/xdisp.c=0Aindex=20ad03ac4605..9eeae43a52=20100644=0A= ---=20a/src/xdisp.c=0A+++=20b/src/xdisp.c=0A@@=20-12482,6=20+12482,11=20= @@=20gui_consider_frame_title=20(Lisp_Object=20frame)=0A=20=20=20=20=20=20= =20display_mode_element=20(&it,=200,=20-1,=20-1,=20fmt,=20Qnil,=20= false);=0A=20=20=20=20=20=20=20len=20=3D=20MODE_LINE_NOPROP_LEN=20= (title_start);=0A=20=20=20=20=20=20=20title=20=3D=20mode_line_noprop_buf=20= +=20title_start;=0A+=20=20=20=20=20=20/*=20Make=20sure=20any=20raw=20= bytes=20in=20the=20title=20are=20properly=0A+=20=20=20=20=20=20=20=20=20= multibyte-encoded.=20=20*/=0A+=20=20=20=20=20=20ptrdiff_t=20nchars=20=3D=20= 0;=0A+=20=20=20=20=20=20len=20=3D=20str_as_multibyte=20(title,=20= mode_line_noprop_buf_end=20-=20title,=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20len,=20= &nchars);=0A=20=20=20=20=20=20=20unbind_to=20(count,=20Qnil);=0A=20=0A=20= =20=20=20=20=20=20/*=20Set=20the=20title=20only=20if=20it's=20changed.=20= =20This=20avoids=20consing=20in=0A@@=20-12493,9=20+12498,10=20@@=20= gui_consider_frame_title=20(Lisp_Object=20frame)=0A=20=20=20=20=20=20=20=20= =20=20=20=20||=20SBYTES=20(f->name)=20!=3D=20len=0A=20=20=20=20=20=20=20=20= =20=20=20=20||=20memcmp=20(title,=20SDATA=20(f->name),=20len)=20!=3D=20= 0)=0A=20=20=20=20=20=20=20=20=20=20=20&&=20FRAME_TERMINAL=20= (f)->implicit_set_name_hook)=0A-=09FRAME_TERMINAL=20= (f)->implicit_set_name_hook=20(f,=0A-=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20make_string=20(title,=20= len),=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20Qnil);=0A+=20=20=20=20=20=20=20=20{=0A+=20=20=20=20=20=20=20= =20=20=20Lisp_Object=20title_string=20=3D=20make_multibyte_string=20= (title,=20nchars,=20len);=0A+=20=20=20=20=20=20=20=20=20=20= FRAME_TERMINAL=20(f)->implicit_set_name_hook=20(f,=20title_string,=20= Qnil);=0A+=20=20=20=20=20=20=20=20}=0A=20=20=20=20=20}=0A=20}=0A=20=0A--=20= =0A2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_8420675B-ECF9-4B50-A662-D373F4D826CA--