From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select Date: Fri, 23 Jul 2021 19:16:02 +0200 Message-ID: References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28573"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Juri Linkov , 39121@debbugs.gnu.org, Tino Calancha To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 23 19:25:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6yvF-0007E7-Lz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jul 2021 19:25:17 +0200 Original-Received: from localhost ([::1]:48510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6yvE-0005mJ-O3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jul 2021 13:25:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6ynG-0005Gq-7V for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 13:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32966) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6ynF-00044q-Uk for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 13:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6ynF-0000iD-Rt for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 13:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jul 2021 17:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39121 X-GNU-PR-Package: emacs Original-Received: via spool by 39121-submit@debbugs.gnu.org id=B39121.16270605762662 (code B ref 39121); Fri, 23 Jul 2021 17:17:01 +0000 Original-Received: (at 39121) by debbugs.gnu.org; 23 Jul 2021 17:16:16 +0000 Original-Received: from localhost ([127.0.0.1]:44506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6ymW-0000gr-58 for submit@debbugs.gnu.org; Fri, 23 Jul 2021 13:16:16 -0400 Original-Received: from mail1475c50.megamailservers.eu ([91.136.14.75]:56854 helo=mail118c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6ymS-0000gb-QX for 39121@debbugs.gnu.org; Fri, 23 Jul 2021 13:16:15 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627060565; bh=K50NbWq7BMtRGMRBjXs30YQ8oymWLdOy5pQDpcHj1ZQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=PdBxIqGnmas5WOytJn9bqzNN/vuvSiLVWG401ifL7NPPzD3MOqHadRqTktlFNvHr4 MXe8Jysb7kN1k4Cb/g+01GUsqXhavDWSjQlHFas/rx9HZMjfxRlK7FpjGSd0BW2o5+ yMiN52uDCIAQPlWjvkRjP1SNbmTMzZyUhuvOkPG0= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16NHG2uP018396; Fri, 23 Jul 2021 17:16:04 +0000 In-Reply-To: <871r7pazx1.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F18.60FAF955.0022, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Ro+70xuK c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=TuURfhSrCEVh8Uy_U5kA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210601 Archived-At: 23 juli 2021 kl. 16.05 skrev Lars Ingebrigtsen : > (defvar occur-highlight-regexp t > "Regexp matching part of visited source lines to highlight = temporarily. > Highlight entire line if t; don't highlight source lines if nil.") >=20 > So I think your patch looks correct. Well yes, but that variable itself isn't really useful -- it is really = just something transplanted from compilation-mode in order to achieve = the same highlighting effect in Occur, but Occur shouldn't need it at = all. So my patch is a bit rubbish; we could do better. Currently, Occur buffers use `occur-target` properties to direct each = line to the start of the first match on that line. We could use the = property to indicating the exact extents (intervals) of matches, = instead. For example, a buffer containing VENI VIDI VICI with the Occur search regexp "VI.I", currently results in a line in = *Occur* having the property `occur-target` with a marker to the start of = 'VIDI' as value. Instead, we could make the value be ((m1 . m2) (m3 . = m4)) where m1..m4 mark the beginning and end of 'VIDI' and 'VICI' = respectively. Then occur-highlight-regexp could be done away entirely.