From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eshel Yaron <me@eshelyaron.com>, Randy Taylor <dev@rjt.dev>
Cc: Evgeni Kolev <evgenysw@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
60805@debbugs.gnu.org
Subject: bug#60805: [PATCH] Extend go-ts-mode with command to add docstring to function
Date: Sat, 21 Jan 2023 08:34:43 +0100 [thread overview]
Message-ID: <D03DA892-A001-4D0A-8845-23D63738E880@thornhill.no> (raw)
In-Reply-To: <m1tu0kz8kv.fsf@gmail.com>
On 21 January 2023 07:48:48 CET, Eshel Yaron <me@eshelyaron.com> wrote:
>
>A quick thought from someone interested in using this new command:
>
>IMO the current implementation is a bit too opinionated to be really
>useful. Inserting the function's name at the beginning of the comment
>is not always desired because different teams have different conventions
>for doc comments, and sometimes you just want to add a nolint
>directive[0] which again doesn't start with the function's name.
>
>My suggestion is to add some way for users to customize/extend the
>contents of the inserted doc comment. One option is to have a variable
>that'll hold a function responsible for determining the text of the
>comment. This variable can then default to a function that returns the
>current Go function's name.
>
>Thanks,
>Eshel
>
>
>[0] https://golangci-lint.run/usage/false-positives/#nolint-directive
Why not just
(insert "// ")
Theo
next prev parent reply other threads:[~2023-01-21 7:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 6:45 bug#60805: [PATCH] Extend go-ts-mode with command to add docstring to function Evgeni Kolev
2023-01-14 7:48 ` Eli Zaretskii
2023-01-14 11:43 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-14 12:24 ` Eli Zaretskii
2023-01-14 13:08 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-18 6:26 ` Evgeni Kolev
2023-01-18 11:59 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-20 9:41 ` Evgeni Kolev
2023-01-20 10:14 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-20 11:39 ` Evgeni Kolev
2023-01-20 14:56 ` Evgeni Kolev
2023-01-20 20:39 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-21 3:30 ` Randy Taylor
2023-01-21 6:48 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-21 7:34 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-01-21 14:39 ` Evgeni Kolev
2023-01-21 20:37 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-21 21:26 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-18 7:46 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D03DA892-A001-4D0A-8845-23D63738E880@thornhill.no \
--to=bug-gnu-emacs@gnu.org \
--cc=60805@debbugs.gnu.org \
--cc=dev@rjt.dev \
--cc=eliz@gnu.org \
--cc=evgenysw@gmail.com \
--cc=me@eshelyaron.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.