From: David Reitter <david.reitter@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system
Date: Mon, 13 Jun 2016 17:12:21 +0800 [thread overview]
Message-ID: <D038BEDE-4D55-4CE6-B8CA-D4FAC0C35973@gmail.com> (raw)
In-Reply-To: <jwvporp6pk3.fsf-monnier+emacsdiffs@gnu.org>
On Jun 10, 2016, at 11:54 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> Could you add a comment explaining why it's OK to ignore `from` and `to`
> here (as well as rename those args to `_from` and `_to` to make it
> clear to the byte-compiler that we purposefully ignore them)?
I could, and I have.
Is it okay to commit this bug fix in emacs-25?
(Is cherry-picking of the two commits okay for this purpose?)
next prev parent reply other threads:[~2016-06-13 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160610080445.616.81209@vcs.savannah.gnu.org>
[not found] ` <20160610080445.5113D220143@vcs.savannah.gnu.org>
2016-06-10 15:54 ` [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system Stefan Monnier
2016-06-13 9:12 ` David Reitter [this message]
2016-06-13 12:22 ` Stefan Monnier
2016-06-13 14:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D038BEDE-4D55-4CE6-B8CA-D4FAC0C35973@gmail.com \
--to=david.reitter@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.