From: Carsten Dominik <carsten.dominik@gmail.com>
To: Anders Waldenborg <anders@0x63.nu>
Cc: Nicolas Goaziou <n.goaziou@gmail.com>,
Org mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: PATCH Make org-open-at-point only ask once
Date: Thu, 6 Oct 2011 10:00:38 +0200 [thread overview]
Message-ID: <D0086051-D308-4DB3-8105-EE316C3B8CF6@gmail.com> (raw)
In-Reply-To: <20110828200542.GS5700@0x63.nu>
Hi Anders, Nicolas
I am wondering what the status of this patch is. There was a discussion, but I am not sure about the conclusion...
- Carsten
On Aug 28, 2011, at 10:05 PM, Anders Waldenborg wrote:
> Hi!
>
> If an org buffer is narrowed, and one tries to do org-open-at-point on
> a link that points to outside of the restriction it asks: "No match -
> create this as a new heading?". When answering no the buffer is
> widened and the reseach is done, and if the link still can't be
> resolved the question is asked again.
>
> For nonexistant links this happens even if the buffer isn't narrowed -
> one needs to answer "n" twice.
>
> I also attached an alternate patch which (IMHO) simplifies the
> implementation by hiding the hard work in a macro, and as a bonus it
> only calls org-link-search once. But it is much more intrusive.
>
> anders
>
> ;; simple testcase to show the bug
> (progn
> (insert "* A\n\n* B\n\n[[A]]")
> (org-narrow-to-subtree)
> (org-open-at-point))
> <org-open-at-point.patch><org-open-at-point-alternate.patch>
- Carsten
next prev parent reply other threads:[~2011-10-06 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-28 20:05 PATCH Make org-open-at-point only ask once Anders Waldenborg
2011-08-29 7:14 ` Nicolas Goaziou
2011-08-29 9:21 ` Anders Waldenborg
2011-08-29 9:36 ` Nicolas Goaziou
2011-08-29 10:53 ` Anders Waldenborg
2011-08-29 11:25 ` Nicolas Goaziou
2011-10-06 8:00 ` Carsten Dominik [this message]
2011-10-06 8:43 ` Anders Waldenborg
2011-10-06 8:54 ` Carsten Dominik
2011-10-06 9:51 ` Anders Waldenborg
2011-10-06 9:57 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0086051-D308-4DB3-8105-EE316C3B8CF6@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=anders@0x63.nu \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.