From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#65621: [PATCH] `dired-next-line' go to meaningful line Date: Wed, 30 Aug 2023 14:54:39 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35280"; mail-complaints-to="usenet@ciao.gmane.io" To: Shynur Xie , "65621@debbugs.gnu.org" <65621@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 30 16:56:40 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbMca-0008vN-HI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Aug 2023 16:56:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbMau-00025K-Ez; Wed, 30 Aug 2023 10:54:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbMat-0001wR-6f for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 10:54:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbMas-0000sP-Tq for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 10:54:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbMb0-0004k9-By for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 10:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Aug 2023 14:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65621 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65621-submit@debbugs.gnu.org id=B65621.169340729618217 (code B ref 65621); Wed, 30 Aug 2023 14:55:02 +0000 Original-Received: (at 65621) by debbugs.gnu.org; 30 Aug 2023 14:54:56 +0000 Original-Received: from localhost ([127.0.0.1]:53743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbMau-0004jk-CZ for submit@debbugs.gnu.org; Wed, 30 Aug 2023 10:54:56 -0400 Original-Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:19692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbMaq-0004jZ-6h for 65621@debbugs.gnu.org; Wed, 30 Aug 2023 10:54:54 -0400 Original-Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37U9iWUr008969; Wed, 30 Aug 2023 14:54:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=fAJfh17HgzZ4Pi6EN3VMXQczz7nHYQEd19dt+uqTpYs=; b=I07vr+IQ/x0i65HyYZfPbgapPTBl719dlYGTubQ4w1h6sMKvQWFjPMRH0ICy1BWX/xtf qNZK2eorDVKU5pCKS6ioXiCrEKIQaK5PcIyGOppguAXqaqh2TW1Dlf1RvnZIArpMlmF3 2dMwcIeoJnV/DZL04PfCwNooJ3fB8X79SP7nVKEPD6GRaz1TAkkyUTtPr/Ht6WL+3VVc d6mhtf1xVErJXV1Hw26H2zu3zkW4/OOxqq+OGMMwOhiVTjo+LyrIBu/W3GHMl9veJU0u c37xAxJXHruyQ5Otw+7LgLeY6wJAfqVjnonp6P4XtuxZrK7CJPniCOGVK5JiOGDCpp8w uQ== Original-Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3sq9xt7m9b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Aug 2023 14:54:43 +0000 Original-Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 37UDHmRP000493; Wed, 30 Aug 2023 14:54:41 GMT Original-Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3sr6gcp3cu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Aug 2023 14:54:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b9sDTTrkGJ2ZtIFpWTbfWK2skSVe1kk2WGHGHF11viO+o05sQB4ojVmZRklsJqqo1RjeOdapgWY91dfabq9A4yKiLlzn6ZeldKo7iStrzCFTsCXil5N1MwSSDdsvxTBl50x0QwXFvFHAMpcFQCjbpT+xIFRJ+RsOnzs988d20yb4i3y0ic8+aqfLOcTWvPREEoJswWh1Th/kA+LPP3pxLMKX32I2k4m6comY2BJEzHOXNYXtA+7mmq/Qik7SVAFIj2DXMwSUon08PsDkha5TvscX3UNs7ElMNWq+NnDhRCqPav1wifIA2wYVdBq9YKas4ju+xo/aM1NpsDfpYRLJ/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fAJfh17HgzZ4Pi6EN3VMXQczz7nHYQEd19dt+uqTpYs=; b=HEJg0PrcVKMX+FuVcedxCJVG+l0Ai+0Yl6xYi+Gc/epBn1KeWVAHvzfXN88TsA88MAlcgIf7ROtdwC/b9IUcwWxNjVcMhXMsR2w3Oa4jTs6N95nNPeovUJQ9AroF8cGvgdvDuAkW5Ls65w8HAXLE5T3w+pvjzswTp1HX7Z/HHCPEYcD5CpvsAX59E+v7G1xzfTIHwMWH6LUhoVt9W5ZQrGLiQmnX0OyxpdMEulV97IecUMd2qNivJCLNh7/ZHzCa8PIi5LvIaPifzqSaP2+pSECVDjMQWmFeXMOu2WLQhewBbHpsAXCOKbjiPdHneyYEjE1iUZfmPDOTE1mkdBhxTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fAJfh17HgzZ4Pi6EN3VMXQczz7nHYQEd19dt+uqTpYs=; b=Oiw/yKtkA3dv6HnHM9IlTX9Izyub+g2mDzZ1AERxPujNa+u07AYV/jp2C5oeQ13IRppU03MTEaYpm/BpvLr2lnLn2ey45v/Zd4kv6EQiqXDuEnwkb3+TmNDcG9BVIKO9m7LTAHGB+K38y3IiNYDiqMZ7LP3Jl3K7x9ILMQvuKzc= Original-Received: from CO6PR10MB5473.namprd10.prod.outlook.com (2603:10b6:5:355::21) by SA1PR10MB5735.namprd10.prod.outlook.com (2603:10b6:806:23e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.20; Wed, 30 Aug 2023 14:54:39 +0000 Original-Received: from CO6PR10MB5473.namprd10.prod.outlook.com ([fe80::a261:8fd:40b4:e4cd]) by CO6PR10MB5473.namprd10.prod.outlook.com ([fe80::a261:8fd:40b4:e4cd%4]) with mapi id 15.20.6699.035; Wed, 30 Aug 2023 14:54:39 +0000 Thread-Topic: [PATCH] `dired-next-line' go to meaningful line Thread-Index: AQHZ20HT/8wr5daoKU60WYHNTQV+4bAC6fZg In-Reply-To: Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR10MB5473:EE_|SA1PR10MB5735:EE_ x-ms-office365-filtering-correlation-id: 73bb777a-d5cd-4d44-5ec1-08dba969095c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O9MOY5LriZactb5tS3WaAh1pI0X5IGnLwEPWxju46Pm7mbh2JTKaS3Lh5/P/S/tocvrvwHW5rwbmE2XjOI6PfXLyy2gIICjXbzaLECmt7Bwp2zY0nr1bIPwN0EizHS0xbLusXsh5oAlVyH5FkseTsUHFK/c3xq4PfXy2LfveVyscYjQxPDORUmIlP7C5t2CMx6zOs3f20HW3BiKaFmvk2TEZj8S4S1D++sGi+76OBBxV5rmJ3GcVIU6dYQuXrRP8EpLpXPjaWAqn/F/D9C+IvUWWq6u3v2azCOtZey1cfCdHK3rHNjTgsuAeqHDhQxfVHx0tqEw7cYskAYZPgzFuvgxK9mh40loy4pWRDEW1RDesMKUXiaix3WdElBP8Lhpjd6hxiuC8jxp2IPeGfeVDQ+JJqePQNX/a08ykrimWje4ICKaBb+a1zbfcoWco7A/JOFDWvgPzXCnaHEgTy9aeBaSPxf4xM4GDp4kmLFCx0yeR9dx7FNSWms6U1EsX2uZntbzPGVU9J4lfUxgcI3IqkY4Wfj4ZlpIH8E5Ml4PSkDQo8ZE7uD6FK/IYGrhaAp3RNqmqMsTQDMjzVyKq9K7vDSAml0z5N3U4BCHwp8J1ZIQksR9nlr5tXEESafklSlzEpOkC8lgO1DQJw8qE2G6k1A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR10MB5473.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(376002)(366004)(39860400002)(346002)(1800799009)(186009)(451199024)(66899024)(2906002)(4744005)(5660300002)(33656002)(86362001)(122000001)(44832011)(38070700005)(38100700002)(52536014)(55016003)(8676002)(41300700001)(8936002)(66556008)(26005)(316002)(9686003)(6506007)(7696005)(66446008)(66476007)(478600001)(71200400001)(64756008)(76116006)(110136005)(66946007)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: m55tolQm9rCxrO+y3DlyU8G7lTLpSKkJiikn75croNu5FUiLFORS/0bBWhUtdxrSf0FYdzbT+1w9MQAjN1G9/WOD8wFeLTcvmsiLPmt05Sp1s+cOt+NwYyJbkGd9MeACYUhBS3/ud5DSc9anHnJ4deqVZPDljXVcpr4Mz4zv9YviC1LHA5oSbN6e52SvnrmYr8xAPs0+vDPvqn5XGEYtceAtYSjvwa7SM3693IOjc5CrvVvpyZ6QPz/txm6hv2z+aIaT4XqMR81yB49uRkwORUEueZx/RcZRHrWcwqggc47PrEZGPu7GC3OI5poSSL4wRTWoe7Mq3gn0zQ0IJpLWyLBGFkbKgORleiRlyFYXtQW8XqzvkAUAq5QKvcrv3NVCNVUMtBpZLiPO/4SHEy9GgXUAVeM5FkxDkbZTFSZeHm8+Vk/H2FFo2tFI0XFM1GoNLFvqRIkULt1jca+z2XAlogrLRVzhNSqDIiycI4eSMZ4UYvyT13xhXSpn5+WihThP1RI3d9/eQL2w//hqLKAmrOH7cQ4Er0EY44vj+Nglay2nvrU6A8M9Qdt2asKmRSB6urdTqAMy43orF9qmM1qCZT4Ev/SR5tDxUeEp26M/pmkAiIE4E4cNcFnaDzSs6mvGDBeStRgIL9RvR5QomrB3uBJBRbnkNZssyql51Jl0FtRTcShY1NxssqJ6KofghWtjgFXgw86t2+dwQbcX0M4iZReMa8RbZJWKdB9FEyAEJCGSSOp8BFBf/7w0Yi a2IxdipInGg+Ln+RDcPTrjSHGTpM9kFjB4GL05u+NINhyXbRw/0Zor3bYqtDdDPpjKUa0I/iiXyXyxHfkcN3CA9yvpE7ImZKhF X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qrxFnPwGCXXjdaW3RLPjaKQtwNDsdALXNtRapYfnVmXYaiY9FebiHrIiOIavdajUYuK055hwV7nPz6alFO8FeZCimJDtSnlIYuigR33tB00WZd4pLfqMBvGN3bnusDNm6QluapnKvK0NJQGr32tT/ziidHX9sIn3DoF6oB6lgsKrah37tjIHJShu977dhJ5o2nslVODjY4dVGIKgdNEE/H+lSY9S1Vf2cRDzONM8/1q5E9ip91rf73eX8gsv2pOeNz/WTM5c98NQkCb5QEN9ZBV+aX0Z7XYrlFa9CjT/t+GaDalc6koRgxYW0koktYXk2lB/vQAAdVCZqrbNxt+5s5P2GQV0SaUADP8724dqfRvlm5p1To5WtwC5DYLwRH1rwcsrr7N22jp2/yUNOR6hM0LV4L+UH+Hg34HdCc4MElU4Q/rTIxtLn8wx6xdtNK7VUVzwYjuI7a4o2+jk4uBtsfeyiDNfjGTUDtEXE1Pppv7QCjpS+4DOvXrDApTQNURr0v5x79U7Rheryk8+RCZdyf8Rn5IWGSv0vCqvpcttBkZN8t4H9RmtYp5RGyV8nHBg945MFMf1TpWephlbveImRZA9AaxDDDL7A7Qf+dq6p8JueGcoH7RpQaglP17WW+rT02pTZcxlkQdpbc6JKztsyyTVXdyUYxxDczlMnE8v5efuv6im2Ya0mJiOWRut3KA0YmxLmPLJZJJduAkYGPxHGCfVvah6FMZqy+ikCBWWyC6mFa zL5Aj+Af7KjKmZSJzEIAppKmFZR5AoUQOn1tQW8b5hDJ9aQLMVw5zT/yneK5w= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5473.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73bb777a-d5cd-4d44-5ec1-08dba969095c X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2023 14:54:39.6571 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1ju4LJ0fliuCui46/EB4ujQtdsI+Nk7MCzs1iQaxH+86WlP4OjUc1sNawJJweR8lpSfQnzegvPDIqxHBQx3CoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5735 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-29_16,2023-08-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 spamscore=0 phishscore=0 suspectscore=0 mlxlogscore=860 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2308300139 X-Proofpoint-ORIG-GUID: GeSbTAGgdbgzQs1S2zv_n2x_8fZ3FMCK X-Proofpoint-GUID: GeSbTAGgdbgzQs1S2zv_n2x_8fZ3FMCK X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268716 Archived-At: Be sure to consider also the behavior when=20 subdir listings are inserted in the buffer. (Didn't try your patch; just sayin'.) ___ FWIW, I think that the right way to deal with this is what's done in `dired+.el': 1. There's an option, `diredp-wrap-around-flag', which controls wrapping around to the buffer beginning/end when using `n'/`p'. That is, it says whether moving down when there's no file/dired/header line further down wraps to the beginning (first such line in the buffer), and similarly when moving up when there's no such line above. 2. Commands `dired-(next|previous)-line' have their keys remapped to commands that respect the option (`diredp-(next|previous)-line'). Simple, useful, IMO. (Likely suggested before to `emacs-devel' but rejected.) ___ Commands `diredp-(next|previous)-line' also have the improvement that they respect var `goal-column': If non-nil then they put the cursor at that column.