From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#48798: 26.3; `define-minor-mode': Message should name the current buffer where enabled/disabled Date: Wed, 2 Jun 2021 19:36:22 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31892"; mail-complaints-to="usenet@ciao.gmane.io" To: 48798@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 02 21:37:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loWg2-000865-T0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Jun 2021 21:37:19 +0200 Original-Received: from localhost ([::1]:46524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loWg1-0000rO-VD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Jun 2021 15:37:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loWfm-0000r1-KR for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 15:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58057) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loWfm-0000t2-Bq for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 15:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loWfm-0006rC-9Z for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 15:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Jun 2021 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48798 X-GNU-PR-Package: emacs X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.162266259126317 (code B ref -1); Wed, 02 Jun 2021 19:37:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Jun 2021 19:36:31 +0000 Original-Received: from localhost ([127.0.0.1]:41370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loWfH-0006qP-2R for submit@debbugs.gnu.org; Wed, 02 Jun 2021 15:36:31 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:34018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loWfG-0006qH-4b for submit@debbugs.gnu.org; Wed, 02 Jun 2021 15:36:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loWfF-0000qI-Tp for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 15:36:29 -0400 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:53776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loWfD-0000Xl-IW for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 15:36:29 -0400 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 152JT5Hf139350 for ; Wed, 2 Jun 2021 19:36:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=m9RRk9WaGxGCNWLdpEI+eczXPUQfcgOK8NaT4m6B6PQ=; b=PPKWEorq4lMyCKlS6DEpcPQWVayjdZjz8oUpmr7vhAoeAPMOSY5s2QRdqPq9j99ujBO1 vmo1RAcUUOpruVX2S8hIsgeCwUgZcGpU0XWV/uX0WzNOMS/hMuZ4btXywyhbl1oxXAHZ 13b9j0gtddrIqXHZprc7lA0FSlI7hIzkOz1OFVqOaMoQl9yClm7w+MAXHAlmS5xeypih F1eO4MOO4Lyev73EHCMX7DYvd+X3sdd4DhnYC2zWnNr8lO95Vw3M8qQZxgOJ8k0E1lea 9q08bk/eOG4qBfRZXC78viI2URR2/jUWscgwNURQ7U/uU6887Js+o0MZgf70PxVEioqN Qg== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 38ub4csm5j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 02 Jun 2021 19:36:25 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 152JU12J063883 for ; Wed, 2 Jun 2021 19:36:25 GMT Original-Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2174.outbound.protection.outlook.com [104.47.57.174]) by userp3030.oracle.com with ESMTP id 38uaqxjq78-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 02 Jun 2021 19:36:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9dPUcGxAMqu7wfiDHSDzAkvFlRLp8hrriYBJupRQOqrVC3q7lllv+GRSd6fVh3IQojOi+2gg+TnvgUn8ZqQelBraQdwZ9TwDpxxbNLE1PRKvD+ndZ70xB3Z6mFgzVXHJO+9mah+884TaMA31dBDvzNsPUDRnx1Es3WzZiWkO2vY2AmoloF1XibJQjHdpy6cAtz0k5EGBGppWWTBIOOVvRhP7zVvSaSO8NqyyeU4F/N1nHkPkWyA+SGna81lvikytmuWCtoU6gzkihn7ua9s+AI7QHTq0tktdFJfTV+pbiKvrTTveyWPeKOImcLafkD30rzQmaPH5yDc/mCtGvXh8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9RRk9WaGxGCNWLdpEI+eczXPUQfcgOK8NaT4m6B6PQ=; b=ADqC92cuNakoEXR4y7kE105XgHBh74NbyXu0kfKQrK2Pa5ticC7/WE3MFbirkBfY77y0nShiT+cf6jErhDY+V1/k6epPoh3g6AP2AfOW2D0KbToDnUnp2qzqb9QPUtzojXS5LFM2SX0wlvxCinbGDAnu3jfgoK0+XoAO1jooCGWF6iKTT393EaRWVZoWBKuvJVZhtKxs4vipg7UpnJHFDnx23+AGtPAhGTW83d0ABqL9BAsIWlhwwvfBBYttzAVJjbI09+BzLjkb1gS1yytrHwxoJzA87IliMPkTp2sFqbTPk4g1zU9d6Adced+pKd8xnyHivhEWzCLQ74IJ0rwOlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9RRk9WaGxGCNWLdpEI+eczXPUQfcgOK8NaT4m6B6PQ=; b=v3z870Fgr8oFAB7+tT9Mpm4r8/ZiqRZzSh6S0em8Je7JwL/S9LxjPxsT32Djkx1IboBh+HsIV0j6Dz42nmDyh2rek4h1Nkynqen/vOue7vVD0j8zLYWl97/8HraIgvYbYo8IT7x7jSgFkhnXG+ONkUrkwxxTGAHZjN+c+OJ+P10= Original-Received: from CO1PR10MB4466.namprd10.prod.outlook.com (2603:10b6:303:9b::10) by CO1PR10MB4577.namprd10.prod.outlook.com (2603:10b6:303:97::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.21; Wed, 2 Jun 2021 19:36:22 +0000 Original-Received: from CO1PR10MB4466.namprd10.prod.outlook.com ([fe80::f8ce:e306:cfd7:6f9f]) by CO1PR10MB4466.namprd10.prod.outlook.com ([fe80::f8ce:e306:cfd7:6f9f%7]) with mapi id 15.20.4173.030; Wed, 2 Jun 2021 19:36:22 +0000 Thread-Topic: 26.3; `define-minor-mode': Message should name the current buffer where enabled/disabled Thread-Index: AddX5nVCpRLn8cYyRbipS5oBO9VO7g== Accept-Language: en-US Content-Language: en-US authentication-results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=oracle.com; x-originating-ip: [73.170.83.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cf1faa3c-9f90-4400-b842-08d925fdb3fb x-ms-traffictypediagnostic: CO1PR10MB4577: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1850; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y/QkMLDLMOhrAzEKSfHAKbJSHTivTV2KpQK0rnGyJEu3SwMhYsPhpqib6Z/mX8emkLdkcRDy9enb6ZnnOOPERRGnwGDgOMfugvAd7b4pYTnpFX2EcNOyASsKVtR5bJYXLBEN7CtAmKsPBTwcFJ4r3aQHeSIPpwey3nmQ5mcx/QE1VgK738FsOE9kbKcHkv/ZtM9fKZWHOigHwt31XAOQGA6VOvhaNPdSjrHiuS7p1jOTysqLiQyd5QzZYDgye2H8qrm8US/Pede3Q04alzJSvdv6eH/hLJoN8KEPgCTmDrPj47OqfkawhnHH/VWcfyfyAx77qGoT6F8o2lgHTQapxyrWQStW8K69+m/41Q5JMAuD7JAhMxKXXPLENzghfcZgEBu8t5C1de9AwwIbiztvDXdSllGZacp2MHwUtdZClD4h8hwCeQ9YPfCriYLX4mlS7TypK0A1EwnZrv0P/Nr/KVjqdsx0F1qt9A+VpGze8Pe2HJpODZNK/rbAiUuVn8Zu8+KTv9u1FBzopk0EQODVLk5Duj5azP+h4JbPEf/ZtPuZSKItBjJHTm+Ndgt5sajL3T0chULvF/o91md7+Cf1+0Pe26ptXMKd5u5Gg+yU+fTzuGjnUa4/zN27KMdvtlu4guvAWvv5f3KPuAX75i1dUg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR10MB4466.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(136003)(346002)(396003)(366004)(376002)(38100700002)(6916009)(122000001)(71200400001)(55016002)(66476007)(8676002)(15650500001)(44832011)(8936002)(478600001)(9686003)(33656002)(76116006)(186003)(5660300002)(7696005)(26005)(316002)(6506007)(52536014)(2906002)(66946007)(86362001)(45080400002)(66446008)(64756008)(83380400001)(66556008)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: uT9EHo+G6+O+s7+iVuWLsUPuFpGOXQvZSfisoGJ6lhu9D+DEj7lezfKUCYK5qvmFL4IeQXTVTg1AcaryIOUKj6O3r6zE6VKFcdGRMVOu3MtV+kZQRH/y2mxQ2sHT5IenQ7kDrqWojn7uH2ycqKvJqrPhdkB9miMoZ7RnQOIriLhAorXfY9aK2T1/hm0hgod4EBZVBkDIErNfPYUhWhZ6ptZ4Q733Hef35SRq8bSgBmjurKWKoSPZX8mNRiXn+W2eJ878FA9qq+VJS77wioR+c2M9JGmgTU4Cn4XwkMSLh+poFo/TUGj/SfAd9NfE2vUSOt0hFlWWqOIZFGpwquYZfcxejyUJc+NIT2XkGkZRakZ2ro1nfP/aq21SBQFLMWBEphplMo8kS2CN/Q38Rs3DN0Jn0QVekI98e/bdUKRIx8Q0UFaP3HXOirH49CsrFujIILvhwhFm8eR9Nis1Nwa7R6qokbxfb6hWCyBlLyxHhdX02x5H7fbG8buAPb6M+uEYBbb3X8i/1MBsao9SraPibus21BqiakPq+dP+gCS8GXtT8njelOAaetHJ1Oy8ljpJc8Kzo93pOx1mthZMa5mpUd4Uetliz29GjaQkr3NuZSFljIKI5jPo4P5GwtFXfgIc01i7JQNU0gSMnhG0m+Vanx7K1bxO00NfaEVNpd+sDJjeqCzZh1XEosfezZaSeBdvKfHQp/HgA/4q+Eyo9t8TbnlnSPQUljXBiogCI++BqNwt7iccXF8EaEgc9tDS wKC1rpQVOSq+OQlISN8vXDEZ4dVjOASo9rGJUnTYFCViM+6mRCbSoBrNMv/Znw+U6EY0gDxdUralIimM2YN3ONQkwdL3PFuOdS x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4466.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf1faa3c-9f90-4400-b842-08d925fdb3fb X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2021 19:36:22.5242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WXnIxVoW3OnHdZMfxBY8QiDirRcxlkk9EZPzBc4bw9uDh8HDgh1rdEy0MLt/NH1vs1ZMJhz5TMpOQaN6Qp6D9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4577 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10003 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=894 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106020124 X-Proofpoint-GUID: w3f3t_VvKh67c_gFTH_LbLS7EEGGGD8W X-Proofpoint-ORIG-GUID: w3f3t_VvKh67c_gFTH_LbLS7EEGGGD8W X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10003 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106020124 Received-SPF: pass client-ip=141.146.126.79; envelope-from=drew.adams@oracle.com; helo=aserp2130.oracle.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207879 Archived-At: A user can easily think s?he's in one window when another is actually selected. Or s?he can think that the buffer in the selected window is a different one from what it actually is. The confirmation/status message you get when you toggle a (local) minor mode just tells you that the mode is enabled or disabled "in the current buffer". It should provide more help than that, naming the buffer. That confirms what you expected or lets you know that you were wrong about your expectation. For example, when you use `C-x C-q', it's better to see "Read-Only mode enabled in buffer `foobar'" than it is to see "Read-Only mode enabled in current buffer". Just that bit of information and reassurance can help. Without bothering with a complete patch, I think this is the only code change needed, in library `easy-mmode.el': (let ((local ,(if globalp "" " in current buffer"))) should be=20 (let ((local ,(if globalp "" '(format " in buffer `%s'" (current-buffer))))) In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32) of 2019-08-29 Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd Windowing system distributor `Microsoft Corp.', version 10.0.19041 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3''