From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: MPS: unable to build due to assertion violation in igc_dump_check_object_starts Date: Tue, 23 Jul 2024 19:12:49 +0000 Message-ID: References: <861q3k9sfb.fsf@gnu.org> <86y15s893y.fsf@gnu.org> <86ttgg867k.fsf@gnu.org> <86ikww7zvf.fsf@gnu.org> <86h6cg7y59.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_vcwhAA2jBuv8LJAlki4YpTwpUnvjAjJZI4ngjxrf5s" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26377"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , eller.helmut@gmail.com, emacs-devel@gnu.org To: =?utf-8?Q?Gerd_M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 24 04:23:06 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWRek-0006hg-2x for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Jul 2024 04:23:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWRdx-0002E3-L8; Tue, 23 Jul 2024 22:22:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWKwV-0000vq-8R for emacs-devel@gnu.org; Tue, 23 Jul 2024 15:12:59 -0400 Original-Received: from mail-4322.protonmail.ch ([185.70.43.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWKwS-0004Wt-M7 for emacs-devel@gnu.org; Tue, 23 Jul 2024 15:12:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1721761974; x=1722021174; bh=fVd5JEw9bIYsARHs0iO4EouobCN+FPmr7KVY6HAfP8Y=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=U9B7xJL0eehbQf5IlcMs8HCkhds9tFbyQeJkjYaC6u5ro8ZNKZeperWPrm5ANxOx3 COyOX4/qBcRNlPVuQZzysuNi/Fe4V5ljX8GBmsVayG6J++LgAHlYZ541Yg9/hxSwPC DHlRNK6qRliv5hkmcfxe2tEL+1jJBWEmXgpmm44tWZTJIFXF509qA40ZCj69tzGj5H tdZWOgpnF5ZCw9KAeYFxMExh1ktIiVhqpGPdE3guYSSZd6Zh5rk4JO1allslntBW7I gFdu7U015cQSzJNHrOfSzerE+rW3wQ4IJeuSpDDnsAJ3v2Bj56mHqqjPPhYR4LQaaP vZvmBRnPUdFZA== In-Reply-To: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 806fba5d697943cd8d4c3b9fc875153ea55cc241 Received-SPF: pass client-ip=185.70.43.22; envelope-from=pipcet@protonmail.com; helo=mail-4322.protonmail.ch X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 23 Jul 2024 22:22:14 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322022 Archived-At: This is a multi-part message in MIME format. --b1_vcwhAA2jBuv8LJAlki4YpTwpUnvjAjJZI4ngjxrf5s Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tuesday, July 23rd, 2024 at 18:48, Gerd M=C3=B6llmann wrote: > Pip Cet pipcet@protonmail.com writes: >=20 > > On Tuesday, July 23rd, 2024 at 18:37, Eli Zaretskii eliz@gnu.org wrote: > >=20 > > > So this is IGC_OBJ_STRING_DATA, but why doesn't igc_dump_finish_obj d= o > > > its job in this case? What are we missing? > >=20 > > I'm pretty sure it's the bignum thing, currently testing a fix. I > > underestimated the complexity of how bignums are dumped, and wrongly > > assumed that on 64-bit systems, we would be dumping bignums; it seems > > we don't do so anymore. (BIGNUM_DATA, unlike the bignum PVEC, doesn't > > have a header; it should, and if I add bignums to the dump manually > > things work now...). > >=20 > > Pip >=20 >=20 > Ok, good to hear :-). Here's a patch which includes both a reproducer for the bug (defining a glo= bal bignum in loadup.el which then gets dumped) and a tentative fix. If bignum dumping is indeed broken on all architectures, including just the= change to loadup.el should reproduce the bug even on 64-bit archs. Pip --b1_vcwhAA2jBuv8LJAlki4YpTwpUnvjAjJZI4ngjxrf5s Content-Type: text/x-patch; name=0001-dump-bignums-properly.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-dump-bignums-properly.patch RnJvbSA4ZTUzNDkzYzA2Y2Q3OTg0NzZhNzkyMzg1MjNkNTY2NTgyYTA0MzBhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAcHJvdG9ubWFpbC5jb20+CkRhdGU6 IFR1ZSwgMjMgSnVsIDIwMjQgMTg6NTc6MzQgKzAwMDAKU3ViamVjdDogW1BBVENIXSBkdW1wIGJp Z251bXMgcHJvcGVybHkKCi0tLQogbGlzcC9sb2FkdXAuZWwgfCAyICsrCiBzcmMvYWxsb2MuYyAg ICB8IDIgKy0KIHNyYy9iaWdudW0uYyAgIHwgMyArKysKIHNyYy9pZ2MuYyAgICAgIHwgNiArKy0t LS0KIHNyYy9wZHVtcGVyLmMgIHwgNiArKysrLS0KIDUgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0 aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2xvYWR1cC5lbCBiL2xp c3AvbG9hZHVwLmVsCmluZGV4IDZkMWUxM2Y0NGJmLi5kZjE3OGIzYmIyZiAxMDA2NDQKLS0tIGEv bGlzcC9sb2FkdXAuZWwKKysrIGIvbGlzcC9sb2FkdXAuZWwKQEAgLTE4NCw2ICsxODQsOCBAQAog ICAoZmlsZS1lcnJvcgogICAgKGxvYWQgImxkZWZzLWJvb3QuZWwiKSkpCiAKKyhzZXRxIGZvbyAo bHNoIDEgOTIpKQorCiAobGV0ICgobmV3IChtYWtlLWhhc2gtdGFibGUgOnRlc3QgIydlcXVhbCkp KQogICA7OyBOb3cgdGhhdCBsb2FkZGVmcyBoYXMgcG9wdWxhdGVkIGRlZmluaXRpb24tcHJlZml4 ZXMsIHB1cmlmeSBpdHMgY29udGVudHMuCiAgIChtYXBoYXNoIChsYW1iZGEgKGsgdikgKHB1dGhh c2ggKHB1cmVjb3B5IGspIChwdXJlY29weSB2KSBuZXcpKQpkaWZmIC0tZ2l0IGEvc3JjL2FsbG9j LmMgYi9zcmMvYWxsb2MuYwppbmRleCAzMjBhNWFkYWYwYi4uM2MxMGExYjYwNWYgMTAwNjQ0Ci0t LSBhL3NyYy9hbGxvYy5jCisrKyBiL3NyYy9hbGxvYy5jCkBAIC02MTE4LDcgKzYxMTgsNyBAQCBt YWtlX3B1cmVfZmxvYXQgKGRvdWJsZSBudW0pCiAvKiBWYWx1ZSBpcyBhIGJpZ251bSBvYmplY3Qg d2l0aCB2YWx1ZSBWQUxVRSBhbGxvY2F0ZWQgZnJvbSBwdXJlCiAgICBzcGFjZS4gICovCiAKLXN0 YXRpYyBMaXNwX09iamVjdAorTGlzcF9PYmplY3QKIG1ha2VfcHVyZV9iaWdudW0gKExpc3BfT2Jq ZWN0IHZhbHVlKQogewogICBtcHpfdCBjb25zdCAqbiA9IHhiaWdudW1fdmFsICh2YWx1ZSk7CmRp ZmYgLS1naXQgYS9zcmMvYmlnbnVtLmMgYi9zcmMvYmlnbnVtLmMKaW5kZXggMWZlMTk1ZDc4ZWEu LjU3ZTkyNTk5Y2M2IDEwMDY0NAotLS0gYS9zcmMvYmlnbnVtLmMKKysrIGIvc3JjL2JpZ251bS5j CkBAIC00OCw2ICs0OCw5IEBAIHhmcmVlX2Zvcl9nbXAgKHZvaWQgKnB0ciwgc2l6ZV90IGlnbm9y ZSkKICAgeGZyZWUgKHB0cik7CiB9CiAKK2V4dGVybiBMaXNwX09iamVjdAorbWFrZV9wdXJlX2Jp Z251bSAoTGlzcF9PYmplY3QgdmFsdWUpOworCiB2b2lkCiBpbml0X2JpZ251bSAodm9pZCkKIHsK ZGlmZiAtLWdpdCBhL3NyYy9pZ2MuYyBiL3NyYy9pZ2MuYwppbmRleCBhZDVmN2NjM2U3YS4uZDFj ZGNlODJmOTggMTAwNjQ0Ci0tLSBhL3NyYy9pZ2MuYworKysgYi9zcmMvaWdjLmMKQEAgLTQ3NjYs OCArNDc2Niw3IEBAIGlnY19kdW1wX2ZpbmlzaF9vYmogKHZvaWQgKmNsaWVudCwgZW51bSBpZ2Nf b2JqX3R5cGUgdHlwZSwKIAlpZ2NfYXNzZXJ0IChiYXNlICsgb2JqX3NpemUgKGgpID49IGVuZCk7 CiAJaWYgKHR5cGUgIT0gSUdDX09CSl9EVU1QRURfQllURVMgJiYKIAkgICAgdHlwZSAhPSBJR0Nf T0JKX0RVTVBFRF9DT0RFX1NQQUNFX01BU0tTICYmCi0JICAgIHR5cGUgIT0gSUdDX09CSl9EVU1Q RURfQlVGRkVSX1RFWFQgJiYKLQkgICAgdHlwZSAhPSBJR0NfT0JKX0RVTVBFRF9CSUdOVU1fREFU QSkKKwkgICAgdHlwZSAhPSBJR0NfT0JKX0RVTVBFRF9CVUZGRVJfVEVYVCkKIAkgICpvdXQgPSAq aDsKIAlpZ2NfYXNzZXJ0IChoZWFkZXJfbndvcmRzIChvdXQpID4gMCk7CiAJcmV0dXJuIGJhc2Ug KyBvYmpfc2l6ZSAoaCk7CkBAIC00NzgwLDggKzQ3NzksNyBAQCBpZ2NfZHVtcF9maW5pc2hfb2Jq ICh2b2lkICpjbGllbnQsIGVudW0gaWdjX29ial90eXBlIHR5cGUsCiAgIHR5cGUgPSAoaXNfcHVy ZSAoY2xpZW50KQogCSAgPyBwdXJlX29ial90eXBlX2FuZF9oYXNoICgmaGFzaCwgdHlwZSwgY2xp ZW50KQogCSAgOiBidWlsdGluX29ial90eXBlX2FuZF9oYXNoICgmaGFzaCwgdHlwZSwgY2xpZW50 KSk7Ci0gIGlmICh0eXBlICE9IElHQ19PQkpfRFVNUEVEX0JJR05VTV9EQVRBKQotICAgIHNldF9o ZWFkZXIgKG91dCwgdHlwZSwgbmJ5dGVzLCBoYXNoKTsKKyAgc2V0X2hlYWRlciAob3V0LCB0eXBl LCBuYnl0ZXMsIGhhc2gpOwogICByZXR1cm4gYmFzZSArIG5ieXRlczsKIH0KIApkaWZmIC0tZ2l0 IGEvc3JjL3BkdW1wZXIuYyBiL3NyYy9wZHVtcGVyLmMKaW5kZXggOTk2YmRjNzkxMDYuLjBmODJi ZTQ2ZTc1IDEwMDY0NAotLS0gYS9zcmMvcGR1bXBlci5jCisrKyBiL3NyYy9wZHVtcGVyLmMKQEAg LTkxMyw3ICs5MTMsOCBAQCBkdW1wX2lnY19zdGFydF9vYmogKHN0cnVjdCBkdW1wX2NvbnRleHQg KmN0eCwgZW51bSBpZ2Nfb2JqX3R5cGUgdHlwZSwKICAgY3R4LT5pZ2NfYmFzZV9vZmZzZXQgPSBj dHgtPm9mZnNldDsKICAgaWYgKGN0eC0+ZmxhZ3MuZHVtcF9vYmplY3RfY29udGVudHMgJiYKICAg ICAgICh0eXBlID09IElHQ19PQkpfRFVNUEVEX0JZVEVTIHx8Ci0gICAgICAgdHlwZSA9PSBJR0Nf T0JKX0RVTVBFRF9DT0RFX1NQQUNFX01BU0tTKSkKKyAgICAgICB0eXBlID09IElHQ19PQkpfRFVN UEVEX0NPREVfU1BBQ0VfTUFTS1MgfHwKKyAgICAgICB0eXBlID09IElHQ19PQkpfRFVNUEVEX0JJ R05VTV9EQVRBKSkKICAgICB7CiAgICAgICAvKiBUaGlzIHNhdmluZyBvZiBvYmpfb2Zmc2V0IGlz IEJlY2F1c2Ugb2YgYW4gYXNzZXJ0aW9uIGluCiAJIGR1bXBfd3JpdGUuICovCkBAIC0zNjM4LDgg KzM2MzksOSBAQCBkdW1wX2NvbGRfYmlnbnVtIChzdHJ1Y3QgZHVtcF9jb250ZXh0ICpjdHgsIExp c3BfT2JqZWN0IG9iamVjdCkKICAgZWFzc2VydCAoc3pfbmxpbWJzIDwgRFVNUF9PRkZfTUFYKTsK ICAgZHVtcF9hbGlnbl9vdXRwdXQgKGN0eCwgYWxpZ25vZiAobXBfbGltYl90KSk7CiAgIGR1bXBf b2ZmIG5saW1icyA9IChkdW1wX29mZikgc3pfbmxpbWJzOworICBjaGFyICpkdW1teSA9ICh2b2lk ICopaWdjX2FsbG9jX2J5dGVzIChubGltYnMgKiBzaXplb2YgKG1wX2xpbWJfdCkpOwogIyBpZmRl ZiBIQVZFX01QUwotICBkdW1wX2lnY19zdGFydF9vYmogKGN0eCwgSUdDX09CSl9EVU1QRURfQklH TlVNX0RBVEEsIG4pOworICBkdW1wX2lnY19zdGFydF9vYmogKGN0eCwgSUdDX09CSl9EVU1QRURf QklHTlVNX0RBVEEsIGR1bW15IC0gc2l6ZW9mICh1aW50NjRfdCkpOwogIyBlbmRpZgogICBMaXNw X09iamVjdCBkZXNjcmlwdG9yCiAgICAgPSBsaXN0MiAoZHVtcF9vZmZfdG9fbGlzcCAoY3R4LT5v ZmZzZXQpLAotLSAKMi40NS4yCgo= --b1_vcwhAA2jBuv8LJAlki4YpTwpUnvjAjJZI4ngjxrf5s--