bug#34946: proposed configure.ac change for emacs-26.2

bug#34946: proposed configure.ac change for emacs-26.2

[Nelson H. F. Beebe]

Testing of the release candidate for emacs-26.2 on Oracle Solaris 11.4
shows that a build fails because lcms2.h is not found in /usr/include.
On that system, and on Hipster, an OpenSolaris relative, that file is
present in /usr/include/lcms.

Discussions with Eli Zaretskii <eliz@gnu.org> suggest that emacs'
configure.ac needs to use pkg-config to identify the correct include
directory for lcms2.h:

	% pkg-config --cflags lcms2
	-I/usr/include/lcms

-------------------------------------------------------------------------------
- Nelson H. F. Beebe                    Tel: +1 801 581 5254                  -
- University of Utah                    FAX: +1 801 581 4148                  -
- Department of Mathematics, 110 LCB    Internet e-mail: beebe@math.utah.edu  -
- 155 S 1400 E RM 233                       beebe@acm.org  beebe@computer.org -
- Salt Lake City, UT 84112-0090, USA    URL: http://www.math.utah.edu/~beebe/ -
-------------------------------------------------------------------------------

bug#34946: proposed configure.ac change for emacs-26.2

[Alan Third]

On Fri, Mar 22, 2019 at 08:09:17AM -0600, Nelson H. F. Beebe wrote:
> Testing of the release candidate for emacs-26.2 on Oracle Solaris 11.4
> shows that a build fails because lcms2.h is not found in /usr/include.
> On that system, and on Hipster, an OpenSolaris relative, that file is
> present in /usr/include/lcms.
> 
> Discussions with Eli Zaretskii <eliz@gnu.org> suggest that emacs'
> configure.ac needs to use pkg-config to identify the correct include
> directory for lcms2.h:
> 
> 	% pkg-config --cflags lcms2
> 	-I/usr/include/lcms

This change already exists in master (Bug#30346). The commit is:

    cb3863370cbe574810f796726faa39ba0de0a429

I tried cherry picking it into emacs-26 and while it needed some
manual cleanup, which was simple, Emacs still builds here after
applying it.
-- 
Alan Third

bug#34946: proposed configure.ac change for emacs-26.2

[Eli Zaretskii]

> Date: Fri, 22 Mar 2019 15:22:02 +0000
> From: Alan Third <alan@idiocy.org>
> Cc: 34946@debbugs.gnu.org
> 
> > Discussions with Eli Zaretskii <eliz@gnu.org> suggest that emacs'
> > configure.ac needs to use pkg-config to identify the correct include
> > directory for lcms2.h:
> > 
> > 	% pkg-config --cflags lcms2
> > 	-I/usr/include/lcms
> 
> This change already exists in master (Bug#30346). The commit is:
> 
>     cb3863370cbe574810f796726faa39ba0de0a429

Thanks for pointing this out.

> I tried cherry picking it into emacs-26 and while it needed some
> manual cleanup, which was simple, Emacs still builds here after
> applying it.

Thanks.  It's too late for Emacs 26.2, I think, but we could
cherry-pick it after the release, in case there will be 26.3.