all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Vince Salvino <salvino@coderedcorp.com>
To: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: RE: Dark mode on Windows
Date: Tue, 26 Oct 2021 04:29:29 +0000	[thread overview]
Message-ID: <CH2PR12MB42313226D36D9C8DA7A6CDD0A5849@CH2PR12MB4231.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CH2PR12MB42310AB24F93852E96F35E79A5829@CH2PR12MB4231.namprd12.prod.outlook.com>

All right everyone, thanks for all your help. I managed to work out the library loading issue, and now have it querying the preferred theme from the registry. I will submit shortly following the CONTRIBUTE guide.

Info and download: https://github.com/vsalvino/emacs

Patch: https://github.com/vsalvino/emacs/pull/1/files

It currently works as so:
* Queries if emacs is running on a supported version of Windows, and OS theme is set to "dark" (light is default).
* Applies system dark title bar
* Applies system dark scroll bars

The following is needed to "complete" the dark mode, but requires a lot more rabbit holes, so will have to be saved for a later date:
* Dark menu bar (no idea how to do this)
* Dark tool bar (probably same implementation as menu bar)

Feel free to debate among yourselves as to the meaning of life:
* Automatically switching the faces/theme to a light/dark theme. This would be cool but also kind of useless as most people configure their own theme anyhow. And nearly every other editor DOES NOT do this, so I think trying to automatically switch user settings is pointless. Maybe add a link on the splash screen to set your theme.
* Make sure themes support dark tab bars. Most do not style it (since it is a newer feature) so it still appears light even on a dark theme.
* I do not want to implement a watcher that receives system light/dark mode changes to dynamically update the window theme. Just restart emacs, it's not a big deal.


Vince Salvino

-----Original Message-----
From: Vince Salvino 
Sent: Sunday, October 24, 2021 6:27 PM
To: emacs-devel@gnu.org
Subject: Dark mode on Windows

Windows 10 has a system-wide "dark mode", which if supported by an app, can tell the app to use dark title bars, scrollbars, etc.

In a fit of rage after staring at the blinding white titlebar on my Emacs frame, I researched the issue and implemented "dark mode" in Emacs for Windows (the rage had been building for years).

Here is a work in progress, which seemingly works quite well, but needs a bit more work. Would anyone be able to help, or possibly help get such a feature merged in?

See README.md in my fork: https://github.com/vsalvino/emacs 


Vince Salvino



  parent reply	other threads:[~2021-10-26  4:29 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-24 22:27 Dark mode on Windows Vince Salvino
2021-10-25  1:17 ` Po Lu
2021-10-25  1:22   ` Po Lu
2021-10-25  3:25     ` Óscar Fuentes
2021-10-25  4:32       ` Po Lu
2021-10-25 12:31         ` Óscar Fuentes
2021-10-26  5:02           ` Po Lu
2021-10-25  4:14     ` Vince Salvino
2021-10-25  4:27       ` Po Lu
2021-10-25  5:20         ` Vince Salvino
2021-10-25  6:25           ` Po Lu
2021-10-25 12:37             ` Eli Zaretskii
2021-10-25 15:44               ` Vince Salvino
2021-10-25 16:34                 ` Eli Zaretskii
2021-10-25 12:15           ` Eli Zaretskii
2021-10-25 13:17       ` Eric S Fraga
2021-10-25  9:59   ` Alan Third
2021-10-25 11:55   ` Eli Zaretskii
2021-10-25 12:22     ` Stefan Monnier
2021-10-25 12:52       ` Eli Zaretskii
2021-10-25 16:52         ` Michael Albinus
2021-10-26  2:04         ` Po Lu
2021-10-26 12:10           ` Eli Zaretskii
2021-10-26 13:35             ` Po Lu
2021-10-26 14:11               ` Eli Zaretskii
2021-10-25 13:02       ` Óscar Fuentes
2021-10-25 13:28         ` Stefan Monnier
2021-10-25 13:56           ` Óscar Fuentes
2021-10-25 17:20             ` Stefan Monnier
2021-10-26  0:56     ` Po Lu
2021-10-26  1:08       ` Óscar Fuentes
2021-10-26  2:02         ` Po Lu
2021-10-26 12:09           ` Eli Zaretskii
2021-10-27  0:36             ` Po Lu
2021-10-27 12:02               ` Eli Zaretskii
2021-10-26 12:08       ` Eli Zaretskii
2021-10-27  0:37         ` Po Lu
2021-10-27 14:36   ` Richard Stallman
2021-10-27 16:28     ` Vince Salvino
2021-10-27 19:49       ` Óscar Fuentes
2021-10-28  6:19         ` Eli Zaretskii
2021-10-25 12:42 ` Óscar Fuentes
2021-10-25 15:45   ` Vince Salvino
2021-10-26  4:29 ` Vince Salvino [this message]
2021-10-26  7:32   ` Po Lu
2021-10-26 14:03     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH2PR12MB42313226D36D9C8DA7A6CDD0A5849@CH2PR12MB4231.namprd12.prod.outlook.com \
    --to=salvino@coderedcorp.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.