bug#47124: 28.0.50; [PATCH] Init archive and add noconfirm to 'package-install-selected-packages'

[Gabriel <gabriel376@hotmail.com>]

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

>>  ;;;###autoload
>> -(defun package-install-selected-packages ()
>> +(defun package-install-selected-packages (&optional noconfirm)
>>    "Ensure packages in `package-selected-packages' are installed.
>> -If some packages are not installed propose to install them."
>> +If some packages are not installed, propose to install them.
>> +If optional argument NOCONFIRM is non-nil, don't ask for
>> +confirmation to install packages."
>>    (interactive)
>>    ;; We don't need to populate `package-selected-packages' before
>>    ;; using here, because the outcome is the same either way (nothing
>>    ;; gets installed).
>> +  (package--archives-initialize)
>
> I would put this new line above the comment, as the comment relates to
> this next line:

Hi Stefan, good catch! Thank you for the suggestion. Here is an updated
patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Init-archive-and-add-noconfirm-to-package-install-se.patch --]
[-- Type: text/x-diff, Size: 2306 bytes --]

From 61f6bcdc3534c0d3a47d7f5e04e1f7c952539b6b Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel.nascimento@nubank.com.br>
Date: Sat, 13 Mar 2021 16:12:47 -0300
Subject: [PATCH] Init archive and add noconfirm to
 'package-install-selected-packages'

* lisp/emacs-lisp/package.el (package-install-selected-packages):
Add call to 'package--archives-initialize' and add optional argument
NOCONFIRM to skip user confirmation when installing packages.
---
 lisp/emacs-lisp/package.el | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 0973963af2..2ecd92cee9 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2206,10 +2206,13 @@ package-install-file
     (package-install-from-buffer)))
 
 ;;;###autoload
-(defun package-install-selected-packages ()
+(defun package-install-selected-packages (&optional noconfirm)
   "Ensure packages in `package-selected-packages' are installed.
-If some packages are not installed propose to install them."
+If some packages are not installed, propose to install them.
+If optional argument NOCONFIRM is non-nil, don't ask for
+confirmation to install packages."
   (interactive)
+  (package--archives-initialize)
   ;; We don't need to populate `package-selected-packages' before
   ;; using here, because the outcome is the same either way (nothing
   ;; gets installed).
@@ -2220,10 +2223,11 @@ package-install-selected-packages
            (difference (- (length not-installed) (length available))))
       (cond
        (available
-        (when (y-or-n-p
-               (format "Packages to install: %d (%s), proceed? "
-                       (length available)
-                       (mapconcat #'symbol-name available " ")))
+        (when (or noconfirm
+                  (y-or-n-p
+                   (format "Packages to install: %d (%s), proceed? "
+                           (length available)
+                           (mapconcat #'symbol-name available " "))))
           (mapc (lambda (p) (package-install p 'dont-select)) available)))
        ((> difference 0)
         (message "Packages that are not available: %d (the rest is already installed), maybe you need to `M-x package-refresh-contents'"
-- 
2.27.0