From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Newsgroups: gmane.emacs.bugs Subject: bug#50176: [PATCH] 28.0.50; repeat-mode does not clear echo-area after timeout Date: Mon, 23 Aug 2021 19:25:30 -0300 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1103"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 50176@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 24 00:31:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIITe-0000Ae-ES for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Aug 2021 00:31:34 +0200 Original-Received: from localhost ([::1]:59400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIITc-0005K6-VM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Aug 2021 18:31:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIIT8-0005IU-OY for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 18:31:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIIT8-0002MU-B4 for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 18:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIIT8-0002sF-2N for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 18:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Aug 2021 22:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50176 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.162975784811022 (code B ref -1); Mon, 23 Aug 2021 22:31:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Aug 2021 22:30:48 +0000 Original-Received: from localhost ([127.0.0.1]:42731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIISu-0002ri-15 for submit@debbugs.gnu.org; Mon, 23 Aug 2021 18:30:48 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:34560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIISr-0002rX-N4 for submit@debbugs.gnu.org; Mon, 23 Aug 2021 18:30:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIISr-0005E2-Fq for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 18:30:45 -0400 Original-Received: from mail-bn8nam12olkn2080e.outbound.protection.outlook.com ([2a01:111:f400:fe5b::80e]:26816 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIISm-00025T-SD for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 18:30:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ltT9AgWEJ7GmtJYCaxQZ73wy55BO2kho50p8xQD+WZwyAY8p5Rz85MARih8rvkBGgUyhLFBueP2eC3JLDZJNg719Le9OZ7tAyBFirZKGEGuYTJjNr3W/sAXD0KI6DQhw8sUbg/a5zzj7E8Qf0Le43nhsIQoIrFMloTEzZsZ0yeGvDcF2IXQbXX1NR9GdQU2KkReWIwhYbcQ3fhyZG3PWFl7gLlvj6DyTVByWfLqUiWmQeRzagOrenzK3klotl63v5RoriM4fIwC5fyh/wUyG864cGvyYA6brr41KArl/+M7/2izSFdG8FgPPF029iSgO9yv2E4kr7e6SbBg6P+GMfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xQ5VuEmzeDFhoe3Z56jniaDYiQshMOa4kA3eXvUcbfE=; b=VfOlS/Hv+kD6m2gzYPKYhJ1/fydD6BLFzdp9E2hGW6sDjm9xkyp9Q2omMiQ/8uAue6zpyNH7Rt0VRu2+De2WMoEQiXCTne4OfhEfKvlpP3xkGSnLuif4MKc8adfoj5H/pgFh/GHdaHESRcAdKl89er+CH7sB2AjlY9X8AEEcK7KJHyzlNnMWQWmELbMhjbakMCtWlmmnR1HtSID/3YuXmo7U4xiuAwVyOUfc7ttKgaqkf94K7B5PFwLsY6jagwR3QFvw9j+acz8QYT+uVa0VK2uFDKDtKTo7B678bsPsdv/+HKCtYByWf2bduTVFNeLuyKF0AOD4+bfUAr3xqRR/RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xQ5VuEmzeDFhoe3Z56jniaDYiQshMOa4kA3eXvUcbfE=; b=iG2mACDad3jBbP8Oa0JhTCCPFLH3jHuGf32MLYTNDe216hEHl0x6Z31EdLwzktv4J09knMpByi23Yc+TI8wcLunpo6MEFgAVAK2J9zAQFZN9boX4CIQfWUW6HLBSY0U47lCtIFyUXEFZW7qx0JLFPuzcLY9iUvcvSQ6GjCEXtnO8BQKMpAn+xObYerCyvk3o+SxrxxSAUL14mMoR3T89XdzBWqo1QrTtuSZlbm/8SjubU7nm+kHNNUy3C3QaDFPFGP90PB2dqqCpoXkS/sCNMj9jFvFTUVnYPAn8BubRxvFL0hQ9+JWxN+rWELXl/t/2pxwAdilu9haIgvup3PPj6Q== Original-Received: from CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) by CH0PR01MB6921.prod.exchangelabs.com (2603:10b6:610:102::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Mon, 23 Aug 2021 22:25:35 +0000 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::5c64:1750:c3c7:c182]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::5c64:1750:c3c7:c182%2]) with mapi id 15.20.4436.024; Mon, 23 Aug 2021 22:25:35 +0000 X-TMN: [7o4HPzDsYmnpzaA7Qpt7kRVYIlcWL0zozkhaGM38lqRWzd4Q+p+vfFrsH7PBu5DH] X-ClientProxiedBy: CP2P215CA0024.LAMP215.PROD.OUTLOOK.COM (2603:10d6:102:1::34) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <87fsuz4x45.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from desktop (2804:431:c7f2:c40e:2a3a:aa3e:7959:7f66) by CP2P215CA0024.LAMP215.PROD.OUTLOOK.COM (2603:10d6:102:1::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Mon, 23 Aug 2021 22:25:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5cfbecf5-11ab-48df-d9ec-08d96684ed2e X-MS-TrafficTypeDiagnostic: CH0PR01MB6921: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yYgs1RIIoyijxyPfh45Kzzw1F0KoeDigtIiEGIPQPdV5tNRf0b8Pn4i/AGzrX3FxxqLpmfVBT8DDntKUm/VTXSyimjapJMxk+djNgIMwNpKO2M6l58e7tyEPUINuBL05Z/St9JZv5mf6sz4lkWbYYROfXTyCrqy7a/aK2O4tYWMeY/un9IVYvHdmGewB1LPBY5evkNWNmXpk+OZWEgqvsbSYkbP3/Zyi6cNHwTKKj5VjK14k/PQClgDZZ4j+THPs16ySR+IiwNiNJ9tJ056RK+0XLT8VGHaKqliTydvzaUEzrIs/pzw1ujwSvAvPm/vmGAakiCPeG9s7SXCrY2ntq8h+kvzUq3ByURhybJf1nsbJ7VI7iPNNbO6PG9YYpkjo3nS1/60nIa7PtPsjnxgMcwXcV2rxzHFZRsco+veB19gh71YjB+J7mFv6L7X4GsGc X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LXWsoxZF+PmpIkSGwwwf+5PpPrLsJ1fSqAcXqpKfIEJ1aIITddtuoX9UcoyQUjsk2lmbTweNZnxPl2LurFpd2/1L7nWbrBmrTlezvlW2+9xjwZ80RzHSLgr0gT4Jfffih3mhYeY8X0gs5BuqIsN5r/6wGQ0mOq//LsPojTMhv3fXuRDFAJJdi3PZlLZNoGCwcI8iy+F918AqnaX+/eGFXQ== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-48c30.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 5cfbecf5-11ab-48df-d9ec-08d96684ed2e X-MS-Exchange-CrossTenant-AuthSource: CH2PR01MB5879.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2021 22:25:35.8128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR01MB6921 Received-SPF: pass client-ip=2a01:111:f400:fe5b::80e; envelope-from=gabriel376@hotmail.com; helo=NAM12-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212521 Archived-At: --=-=-= Content-Type: text/plain Description: When repeat-mode is enabled and a repeat-exit-timeout is set, the echo-area is not cleared in case the echo-area has some content and a single repeat-command is executed. Steps: 1) emacs -Q (from master branch) 2) eval (setq repeat-exit-timeout 1) (repeat-mode 1) 3) create some windows with 'C-x 2' and 'C-x 3' 4) 'C-x' 5) wait prefix "C-x" to appear on echo-area 6) 'o' (echo-area will now contain "C-x o [Repeat with o, O]") 7) wait a few seconds so 'repeat-exit-timeout' takes effect Expected: the echo-area is cleared Actual: the echo-area is not cleared If 'o' is pressed again, it will run 'self-insert-command' even though the echo-area is still showing "C-x o [Repeat with o, O]". Now repeat steps 1-5 but press 'o' quickly to invoke the repeat command multiple times (which will trigger other-window multiple times). The echo-area changes to "Repeat o, O" and is properly cleaned after 'repeat-exit-timeout' seconds. Patch: I created a simple patch that seems to fix this probem. The 'string-prefix-p' was replaced with 'string-match-p' to handle cases where echo-area contains some other message. This check seems very poor, though, so any better approach is welcome. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-to-clear-echo-area-after-repeat-exit-timeout.patch >From e6de15337bf4516740c0e790f6a2bfb3deaf9b5b Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Mon, 23 Aug 2021 19:05:58 -0300 Subject: [PATCH] Fix to clear echo-area after repeat-exit-timeout. * lisp/repeat.el (repeat-echo-message): Use 'string-match-p' to handle cases where echo-area contains other messages. --- lisp/repeat.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/repeat.el b/lisp/repeat.el index cec3cb643a..054eacf8ec 100644 --- a/lisp/repeat.el +++ b/lisp/repeat.el @@ -474,7 +474,7 @@ repeat-echo-message (if (current-message) (message "%s [%s]" (current-message) mess) (message mess))) - (when (string-prefix-p "Repeat with " (current-message)) + (when (string-match-p "Repeat with " (current-message)) (message nil)))) (defvar repeat-echo-mode-line-string -- 2.32.0 --=-=-=--