From: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
To: emacs-devel@gnu.org
Subject: Re: Pushing the mark from a primitive like goto-char
Date: Wed, 06 Jan 2021 16:26:45 -0300 [thread overview]
Message-ID: <CH2PR01MB58795CA80593341C20BC653F8BD00@CH2PR01MB5879.prod.exchangelabs.com> (raw)
In-Reply-To: <m1czyji4p7.fsf@yahoo.es> ("Daniel MartÃn via \"Emacs development discussions."'s message of "Tue, 05 Jan 2021 20:06:28 +0100")
"Daniel MartÃn via \"Emacs development discussions."
<emacs-devel@gnu.org> writes:
> martin rudalics <rudalics@gmx.at> writes:
>
>>>> I'd then try to make it behave like 'M-g g' in this regard.
>>>
>>> Some interactive versions of low-level primitives have the suffix
>>> `...-command' in their names, so a command like 'M-g g' and bound to
>>> 'M-g c' could be named 'goto-char-command'.
>>
>> I was more concerned about not pushing the mark when the region is
>> already active so one can use M-g c to extend the region. BTW, is there
>> a reason why 'goto-map' is so terribly unpopulated?
>>
>
> This sounds like a good idea:
>
> - Create a 'goto-char-command' command in ELisp.
>
> - Move the interactive spec that is in 'goto-char' to this new command
> and make it push the mark smartly (e.g. be careful when a region is
> active). Then call 'goto-char'.
>
> - Rebind 'M-g c' to 'goto-char-command'.
>
> - Announce the new command.
>
> What do you think? Could it break something? Thanks.
Thank you!
I guess we missed the :group definition, here is a patch:
========================================================
diff --git a/lisp/mb-depth.el b/lisp/mb-depth.el
index ea2ea174b5..22315cd93f 100644
--- a/lisp/mb-depth.el
+++ b/lisp/mb-depth.el
@@ -37,7 +37,8 @@ minibuffer-depth-indicator-function
(defface minibuffer-depth-indicator '((t :inherit highlight))
"Face to use for minibuffer depth indicator."
- :version "28.1")
+ :version "28.1"
+ :group 'basic-faces)
;; An overlay covering the prompt. This is a buffer-local variable in
;; each affected minibuffer.
========================================================
prev parent reply other threads:[~2021-01-06 19:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1im8mgmb7.fsf.ref@yahoo.es>
2020-12-28 12:14 ` Pushing the mark from a primitive like goto-char Daniel Martín
2020-12-28 14:17 ` Philipp Stephani
2020-12-28 14:45 ` Daniel Martín
2020-12-28 14:49 ` Eli Zaretskii
2020-12-28 14:56 ` Stefan Kangas
2020-12-28 15:32 ` Philipp Stephani
2020-12-28 16:49 ` martin rudalics
2020-12-28 17:15 ` Juri Linkov
2020-12-29 8:54 ` martin rudalics
2020-12-29 14:41 ` Stefan Kangas
2020-12-29 16:59 ` martin rudalics
2020-12-29 17:56 ` Drew Adams
2020-12-29 19:25 ` Juri Linkov
2020-12-29 19:47 ` Eli Zaretskii
2020-12-30 9:36 ` Juri Linkov
2020-12-29 19:54 ` Drew Adams
2020-12-30 9:41 ` Juri Linkov
2020-12-30 17:32 ` Drew Adams
2020-12-30 5:26 ` Richard Stallman
2020-12-31 2:43 ` Howard Melman
2021-01-05 19:06 ` Daniel Martín via "Emacs development discussions.
2021-01-05 19:17 ` Stefan Monnier
2021-01-05 19:19 ` Stefan Monnier
2021-01-05 19:52 ` Philipp Stephani
2021-01-05 20:01 ` Stefan Monnier
2021-01-05 20:29 ` Drew Adams
2021-01-06 5:12 ` Richard Stallman
2021-01-05 19:29 ` Eli Zaretskii
2021-01-05 19:53 ` Philipp Stephani
2021-01-08 19:30 ` Daniel Martín via "Emacs development discussions.
2021-01-05 19:56 ` Philipp Stephani
2021-01-06 19:26 ` Gabriel do Nascimento Ribeiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR01MB58795CA80593341C20BC653F8BD00@CH2PR01MB5879.prod.exchangelabs.com \
--to=gabriel376@hotmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.