From: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
To: 45808@debbugs.gnu.org
Subject: bug#45808: 28.0.50; [PATCH] Add option remember-diary-regexp
Date: Tue, 12 Jan 2021 12:53:29 -0300 [thread overview]
Message-ID: <CH2PR01MB58794F0CA8F9EF082080DCEA8BAA0@CH2PR01MB5879.prod.exchangelabs.com> (raw)
In-Reply-To: <83k0sidw5e.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Jan 2021 17:15:09 +0200")
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
>> Date: Tue, 12 Jan 2021 00:26:25 -0300
>>
>> The regexp to extract diary entries on remember.el is hardcoded.
>> Here is a patch to add a new option to configure a custom regexp.
>
> Thanks, but can you please describe the situation where this regexp
> will need to be modified?
There are multiple cases, for example, if the user wants to
automatically extract diary entries of lines that starts with a date
pattern (e.g.: dd/mm/yyyy). This new option does not target a specific
user case but rather opens a range of possibilities by not relying on a
hardcoded (and not documented) behavior.
By the way, here is a patch with updated docstring.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-option-remember-diary-regexp.patch --]
[-- Type: text/x-diff, Size: 1587 bytes --]
From eaff2fb472a0f5911ee11287156d46ed7acbdbb0 Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel.nascimento@nubank.com.br>
Date: Tue, 12 Jan 2021 12:52:07 -0300
Subject: [PATCH] Add option remember-diary-regexp
---
lisp/textmodes/remember.el | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/lisp/textmodes/remember.el b/lisp/textmodes/remember.el
index 98d3a3856e..5558bd7ec5 100644
--- a/lisp/textmodes/remember.el
+++ b/lisp/textmodes/remember.el
@@ -159,7 +159,8 @@
;; ;; This should be before other entries that may return t
;; (add-to-list 'remember-handler-functions 'remember-diary-extract-entries)
;;
-;; This module recognizes entries of the form
+;; This module recognizes entries of the form (defined by
+;; remember-diary-regexp)
;;
;; DIARY: ....
;;
@@ -532,13 +533,18 @@ remember-diary-convert-entry
(autoload 'diary-make-entry "diary-lib")
+(defcustom remember-diary-regexp "^DIARY:\\s-*\\(.+\\)"
+ "Regexp to extract diary entries."
+ :type 'regexp
+ :version "28.1")
+
;;;###autoload
(defun remember-diary-extract-entries ()
- "Extract diary entries from the region."
+ "Extract diary entries from the region based on `remember-diary-regexp'."
(save-excursion
(goto-char (point-min))
(let (list)
- (while (re-search-forward "^DIARY:\\s-*\\(.+\\)" nil t)
+ (while (re-search-forward remember-diary-regexp nil t)
(push (remember-diary-convert-entry (match-string 1)) list))
(when list
(diary-make-entry (mapconcat 'identity list "\n")
--
2.27.0
next prev parent reply other threads:[~2021-01-12 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 3:26 bug#45808: 28.0.50; [PATCH] Add option remember-diary-regexp Gabriel do Nascimento Ribeiro
2021-01-12 15:15 ` Eli Zaretskii
2021-01-12 15:53 ` Gabriel do Nascimento Ribeiro [this message]
2021-01-20 16:46 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR01MB58794F0CA8F9EF082080DCEA8BAA0@CH2PR01MB5879.prod.exchangelabs.com \
--to=gabriel376@hotmail.com \
--cc=45808@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.