From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Newsgroups: gmane.emacs.devel Subject: Re: Little improvements on pulse.el Date: Thu, 11 Mar 2021 20:42:40 -0300 Message-ID: References: <83ft13p5ow.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3276"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 12 01:01:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKVEu-0000jv-6h for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Mar 2021 01:01:12 +0100 Original-Received: from localhost ([::1]:55290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKVEt-0005lH-8V for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Mar 2021 19:01:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKVBq-0003Mr-2X for emacs-devel@gnu.org; Thu, 11 Mar 2021 18:58:02 -0500 Original-Received: from mail-oln040092009057.outbound.protection.outlook.com ([40.92.9.57]:48369 helo=NAM04-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKVBn-00022Z-KG for emacs-devel@gnu.org; Thu, 11 Mar 2021 18:58:01 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e0Fih04HEDD33nOm9Jiu0JT0TTsFumFjWDWCFBuO84RtZJgfrZEPoM2dMTtxVjybuWhEMxfsXb7JLA8LcvpOZIcL7wt86vqYw6TuFxSEbAv5oUs1h2aPjaAE0fflgZTP7J6aeoARa0wxfiuaLb/AIVWGnCWK+awX5zL9abbSgYXwowzh6tm0bMygI5cZJs/8vmqAo5SEpJE6ybRJ79R7WkC5dCcnD8cmPh+gM6UUQDFnQeiE5cwBFrwNapPOfZ2bGVrFiRizaIZI3GLtDOe2KpVPKownGkaE7SRz7L1rFnbmuvMmanc9DMm9+c42VT9wkecbG/vNaTeBRqXkJyaGBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=giguElJG8QsIzg30WLKc3gSjVNCTM+ciESPVrxinS0I=; b=IxYKnciwiKIjSIlE2OC2euIKeJOULQGCgOrtkZkaA3SzuuK0w9OjGVGJ8HL1K+/0dBYETz0UcWqocXseBNQuCYXplu5ODfsSaXkorzhDmjXFDqeP+jSUjkiIQqyAzb//Pull7YPQV0mYiuZHF91dGSBj46YHXi2FuhkdvZIrPfx3fz51gxAmDpV5T+epavI1LS+7Atl6Vs+G0XZjcruw8cpVq2n1UNYXwojNfZr0H2FUXx/B3Ya1pAcmQGHj1mpOoXVg67gdg4EvsGvQYVCy7Au8gh9B2lgPL4R9Gqc2v+uHQUY0ZDBDTIMqFfhkQhqn3CagaCR9oAT0uKMxG3455g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=giguElJG8QsIzg30WLKc3gSjVNCTM+ciESPVrxinS0I=; b=L1WhwsoH0NyB31q4R90aY+LFBooSE3aEwK9kkWYtdlNwEWXZZu+DBJWR2z+MwjVvnB+urxCiKuzHPaR9Oy4H8BpG0SJ+YzV8uWMKqOuQPpSt5bjoWaNmLaTAOHy3vCD9KCXTeTpbxTG7Pxp2ZqR5jzd7Osnx5jYSIDIMPew0+fxHJ04KSwypY54GfImJnZTiFNOlvgnNGqXdRvwCUTxLbSvO6VniHq5RZrT7fGq0ps+TnEGzOnb+0twIFj2PnqZjUYtsQHm2YdGD2xtjedYJ3MoKb5E7Z+zPrWlg6x9YsmPL9oF1af0oyw19C0a7CuK3g81SJhh0OuXF1G+Z6Tsrrw== Original-Received: from CO1NAM04FT024.eop-NAM04.prod.protection.outlook.com (10.152.90.55) by CO1NAM04HT031.eop-NAM04.prod.protection.outlook.com (10.152.91.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.25; Thu, 11 Mar 2021 23:42:54 +0000 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com (2a01:111:e400:7e4d::42) by CO1NAM04FT024.mail.protection.outlook.com (2a01:111:e400:7e4d::105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.25 via Frontend Transport; Thu, 11 Mar 2021 23:42:54 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:4B38A169934F8FAC5BE7332E5AF6B0A490479A5B5A6946BBE7CE63B4E8F1EFAA; UpperCasedChecksum:90A94A15E72E007EDF0F56ED6BEE3A15BDF80559FAF6474FFDA20CAAFA665F5D; SizeAsReceived:7484; Count:45 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::592f:9a58:d8cd:d9c9]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::592f:9a58:d8cd:d9c9%7]) with mapi id 15.20.3912.028; Thu, 11 Mar 2021 23:42:54 +0000 In-Reply-To: <83ft13p5ow.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 Mar 2021 14:13:35 +0200") X-TMN: [R9lqhT/FF4WORYt/54mKmewsojVwOL9WqQa5o9EwjVYWbS/DzrnJfdxmHxWK/Fbv] X-ClientProxiedBy: CP3P284CA0050.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:6d::25) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <87h7lhdzpr.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from precision5540 (2804:431:c7f2:d29a:abdc:28c1:c75d:6170) by CP3P284CA0050.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:6d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Thu, 11 Mar 2021 23:42:51 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 17c1e2e0-0989-44de-ae29-08d8e4e76315 X-MS-TrafficTypeDiagnostic: CO1NAM04HT031: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7WOvG7JXVAQOQRJIHnkfq6qQFHgAy9nqh0SxLhm2X+n2dsH/uk/aMOfQ2AFrOPzwM01PD/QL1y9dARj4DdKhVMopc5dSZxeSNR4/ipJZbcKUbhafXUDKDCiHF6vhnXxXNjoQkxN6rBfIVlDSbgzOa1tBq4iqWszzjTC1fpNmNvskuXn6fSvugVL3MdVNvcX/YUwhMaGKNDKAnGk+IbzBECv8xJ86TqOBQOik0IdZZVjo/Lrq0nU1Zp9rx4JdQizpzdtStroJ7LAPI8QR9Px6B/PUiHfNay8w0Mq4OAv+pr9TLTrXq3oYmz34UyOKvqB8WrCDNiMrFaHHMKs9CVQam6UHmgq0+UQpbh3yv4pTQgVm1TJ1oAS/zuX/b/+0TbZWTgjyGKSYx31sZ3Ncn9wlOw== X-MS-Exchange-AntiSpam-MessageData: GffoGGrYohj9XaaxomjZ8sb21pyX3+T3yoQi4KBj1jlnoZHICnrgcEQP89iw490QuxCIO7XmH/tgwca1W+oIk2Kl7okwrYfyQMP88NQchk135wgt9IJLdLHWbEzLurwnvtU0yP70LlalaaUg21QO/7aucuU8i64Lwpj/0V4d44hhUw3VdBfYru3cRbczsbyD+1YdutdOhntFrLSF+eQ+ag== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17c1e2e0-0989-44de-ae29-08d8e4e76315 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 23:42:53.9719 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: CO1NAM04FT024.eop-NAM04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM04HT031 Received-SPF: pass client-ip=40.92.9.57; envelope-from=gabriel376@hotmail.com; helo=NAM04-BN3-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266375 Archived-At: >> 3. I could not find any documentation or usage in emacs source code for >> 'pulse-line-hook-function' and 'pulse-command-advice-flag'. Is the flag >> 'pulse-command-advice-flag' really needed ? The git history says the >> last modification of this code was 12+ years ago. > > You will find one usage of the hook in CEDET. In any case, after so > many years I don't think we should consider removing these without a > good reason. Is there such a reason? The only reason to remove it was because I thought it was not being used anywhere. If it's used by CEDET, we can keep as it is. >> 5. The code on 'pulse-lighten-highlight' can be significantly improved >> by replacing 'pulse-int-to-hex' and 'pulse-color-values-to-hex' with >> 'color-gradient' from color.el. The idea is to build the list of color >> gradients beforehand and use a timer to set each color according to >> 'pulse-iterations' and 'pulse-delay'. A very basic example: > > I'm not sure I understand the improvement, can you elaborate? I will try to briefly explain how it works and how it could be improved. The main function ('pulse-momentary-highlight-overlay') runs 'pulse-tick' with a timer, passing a stop-time as parameter. The 'pulse-tick' calls 'pulse-lighten-highlight' that has a complex logic to calculate the next color for the pulse overlay. It basically checks for the current iteration number and calculates the appropriate RGB (a little bit lighter than the previous one), using a helper function in the same file ('pulse-color-values-to-hex'). All this code can be replaced by 'color-gradient' from 'color.el' that, according to Stefan Monnier in another thread, was added to Emacs after pulse.el. The pseudo-code is: for each color in color-gradients(start, stop, length): update-overlay(color) sleep()