From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#71863: 31.0.50; Wrong argument type for treesit-query-range in treesit-update-ranges Date: Sun, 14 Jul 2024 23:18:18 -0700 Message-ID: References: <86y16e530r.fsf@gnu.org> <86ikxh3gti.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8020"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Noah Peart , 71863-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 15 08:20:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sTF4f-0001sA-Hj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Jul 2024 08:20:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTF46-0008Eq-O6; Mon, 15 Jul 2024 02:20:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTF45-0008DH-6T for bug-gnu-emacs@gnu.org; Mon, 15 Jul 2024 02:20:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sTF44-0005o3-TQ for bug-gnu-emacs@gnu.org; Mon, 15 Jul 2024 02:20:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sTF46-0006p2-B9 for bug-gnu-emacs@gnu.org; Mon, 15 Jul 2024 02:20:02 -0400 Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jul 2024 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71863 X-GNU-PR-Package: emacs Mail-Followup-To: 71863@debbugs.gnu.org, casouri@gmail.com, noah.v.peart@gmail.com Original-Received: via spool by 71863-done@debbugs.gnu.org id=D71863.172102437626177 (code D ref 71863); Mon, 15 Jul 2024 06:20:02 +0000 Original-Received: (at 71863-done) by debbugs.gnu.org; 15 Jul 2024 06:19:36 +0000 Original-Received: from localhost ([127.0.0.1]:58830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sTF3g-0006o9-5w for submit@debbugs.gnu.org; Mon, 15 Jul 2024 02:19:36 -0400 Original-Received: from mail-pl1-f179.google.com ([209.85.214.179]:49251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sTF3e-0006o0-9z for 71863-done@debbugs.gnu.org; Mon, 15 Jul 2024 02:19:35 -0400 Original-Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1fb05b0be01so27357345ad.2 for <71863-done@debbugs.gnu.org>; Sun, 14 Jul 2024 23:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721024311; x=1721629111; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JXLE3iukbD64gbNL4nDL4mbypf04YCKorSEYSFUObLo=; b=ejilgl3TutPSSl25M9gyWJVOcsKOXpX9fZnFETl26YQ1nTpbLsGXbB4xu8fziFBshZ H8l5JklaFkN2Wm6Kf08CmTNM5goTs8zE6Vhi9nbV6mdMzgpsWDFWfyrP1wMJ8VM1v6/7 BAby34IP73xapUvob3LvC5JsC/BHZlHhP0T3PN2YKRKMT+R2dDHXttzti7J6xKMRjI2U 7VeXLxTZkYFKr5nShi6u1fq/SRJ3dl/yLYTqn34C5ifX4HQPAjLRDbz5XDeCVEow9C0Z qXK3Th63BZRl7nopf1od1uOGXWw8fyvXWnJIrTuk+MJz1aXFDzj4AssToeZmHTX3+mJr hTjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721024311; x=1721629111; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JXLE3iukbD64gbNL4nDL4mbypf04YCKorSEYSFUObLo=; b=pkOPJ/Fa5FFsi9pR64os8VIvntQQvCd4bm6sHYiX3P5HIWRwlkcEgk7ZpuZlYmv+xF DkGeoSNFhAnaLwWZrpGuK84e5FAsehlf9n6jvf4xbAkOl85QtWOS9h5oZTbQGTPXUbut qmLG2cWFRRlQXgghwjxxWZEhVlJffKNv/NDWdMec8HIDYw9Z/r6IV9PDAiBs1EiLqhUi b8Z7lBycEOhw356n7PDo9XLu70nJCaz/Mz2vTKkXQSntn671gysbup62ziI9BPzPjOvb FhMZ43SSxFJdddrrAdBS2/7n2IaLRv+GZNF4SBr+zbyq2Dt+qAa+ES1SWrVHXgkv847T tWow== X-Forwarded-Encrypted: i=1; AJvYcCVzaHkzWPXZYysiDrnp3ODOTsMDEEserBJF6JWtoiy6sRp7la/Ap09u+vbmH5c3eqSedDkx35eXuWNLzIV08ZNr3kp4Ald0646wsg== X-Gm-Message-State: AOJu0YzgMd4A75jokBu9OS4YCd5FJJn81fWqIK6LeKZfhPZLD1Qg3Ndi akSRk3xWqxVE5a+Qvl7bN+vOZdNwH1Q8AYkn/221pEi0Q0U2BNlc X-Google-Smtp-Source: AGHT+IEPl75Cn3g3UKsZ9hg7bl1xc1ZXgyvtxeDKtrcbbMIjpY3XLP+hE91V7suQXuGXzZs0UgUO8w== X-Received: by 2002:a17:903:984:b0:1f8:6bae:28f with SMTP id d9443c01a7336-1fbb6d2ac8amr165923785ad.9.1721024311171; Sun, 14 Jul 2024 23:18:31 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:c931:36dd:b6ff:8bfc]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fc0bc285c5sm32584555ad.132.2024.07.14.23.18.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jul 2024 23:18:30 -0700 (PDT) In-Reply-To: <86ikxh3gti.fsf@gnu.org> X-Mailer: Apple Mail (2.3774.600.62) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288853 Archived-At: > On Jul 6, 2024, at 10:35=E2=80=AFPM, Eli Zaretskii = wrote: >=20 >> From: Yuan Fu >> Date: Sat, 6 Jul 2024 13:50:10 -0700 >> Cc: Noah Peart , >> 71863@debbugs.gnu.org >>=20 >>=20 >>=20 >>> On Jul 6, 2024, at 1:38=E2=80=AFAM, Eli Zaretskii = wrote: >>>=20 >>>> From: Noah Peart >>>> Date: Sun, 30 Jun 2024 16:12:06 -0400 >>>>=20 >>>> I just noticed this after building latest Emacs. In >>>> `treesit-update-ranges`, during redisplay, the first argument to >>>> `treesit-query-range` is a tree-sitter language symbol, not a node. >>>>=20 >>>> At treesit.el:760 >>>>=20 >>>> (let* ((host-lang (treesit-query-language query)) >>>> (parser (treesit-parser-create language)) >>>> (old-ranges (treesit-parser-included-ranges parser)) >>>>>>> host-lang isnt a node >>>> (new-ranges (treesit-query-range >>>> host-lang query beg end offset)) >>>>=20 >>>> This causes a an error in modes that have set = `treesit-range-settings` >>>> eg., `js-ts-mode`: >>>>=20 >>>>> Error muted by safe_call: = (treesit--font-lock-mark-ranges-to-fontify >>>>> ((1 . 940)) #) signaled >>>>> (wrong-type-argument treesit-node-p javascript) Error during >>>>> redisplay: (jit-lock-function 1) signaled (wrong-type-argument >>>>> treesit-node-p javascript) >>>>=20 >>>> And in `syntax-propertize-function`, for example in `ruby-ts-mode`, >>>>=20 >>>>> QuitError muted by safe_call: (internal--syntax-propertize 46) >>>>> signaled (wrong-type-argument treesit-node-p ruby)=20 >>>=20 >>> Yuan, could you please look into this issue? >>=20 >> This is a bug I introduced on emacs-30 and later fixed. So once = emacs-30 is merged into master the issue should go away. Sorry for the = trouble :-( >=20 > When did you fix it on emacs-30? The merges to master happen very > frequently lately; the last one was yesterday. Could it be that this > is already fixed? I checked with master (with php-ts-mode) and it=E2=80=99s working fine. = So I=E2=80=99m closing this report. Fell free to reopen if there=E2=80=99r= e problems. Yuan=